Michael Voříšek
f4272804d6
Rename test files for PHPUnit 10+ ( #9477 )
2024-06-05 07:46:51 +02:00
Michael Voříšek
52d8172b0f
Allow composer autoloading (to coexist) ( #9407 )
...
* Replace custom loader in favor of composer native
* Load plugins using composer
* finish debug_logger plugin
* finish markasjunk plugin
* finish password plugin
* finish enigma plugin
* finish managesieve plugin
* fix ExtensionInstaller run on first install
* fix phpstan "Implicit array creation" in plugin config files
* simplify composer.json
* keep non-composer autoloading relying on include_path set in plugins
* update minimal "roundcube/plugin-installer" version
* "plugins.roundcube.net" root-only package repo is not needed
* REVERT ALL
* fix phpstan "Implicit array creation" in plugin config files
* update minimal "roundcube/plugin-installer" version
* reland composer.json changes
* fix ExtensionInstaller run on first install
* Roundcube (non plugin) tests are fine to rely on composer autoload
* fix CS of master
* not needed until strict composer autoloading
* improve comment
* revert rcmail_oauth change - fixed in plugin installer
* require fixed plugin installer
2024-04-10 12:27:43 +02:00
Aleksander Machniak
58d28297a3
Code improvements, PHPDoc fixes
2024-03-29 16:18:20 +01:00
Michael Voříšek
d18406a8bd
Fix binary operator spaces CS ( #9330 )
...
* align_single_space_minimal for assign
* assign operators grouping is not supported by PHP CS Fixer
* binary_operator_spaces = single_space
* fix anonymous function on single line
* align comments manually
2024-02-02 07:53:34 +01:00
Michael Voříšek
4ee79b9e84
fix "explicit_string_variable" ( #9315 )
2024-01-22 08:05:59 +01:00
Michael Voříšek
b1a0067e5d
Fix more CS ( #9303 )
...
* fix "class_attributes_separation"
* fix "ternary_to_null_coalescing"
* fix "no_extra_blank_lines"
* fix "php_unit_data_provider_name" - use snake_case
* fix remaining "function data_" manually
* move "php_unit_test_case_static_method_calls" to a better place in cnf
* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
* fix single quotes in JS
* fix some minor JS CS
* fix CS v3.45.0
2023-12-31 16:36:55 +01:00
Michael Voříšek
3e458fa5fd
Refer native constants unambiguously ( #9275 )
...
* Fix "native_constant_invocation" CS
* "self_accessor" was fixed in 9269 PR
* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
28c778b7a0
Modernize more CS III ( #9270 )
...
* fix "single_trait_insert_per_statement"
* fix "empty_loop_condition"
* fix "backtick_to_shell_exec"
* fix "phpdoc_to_comment"
* fix "no_empty_statement"
* fix "heredoc_to_nowdoc"
* fix "class_reference_name_casing"
* fix "align_multiline_comment"
* fix "heredoc_indentation"
* fix "constant_case"
* fix "single_line_comment_style"
* fix "no_null_property_initialization"
* fix "standardize_increment"
* fix "no_unneeded_control_parentheses"
* fix missing NL after "<?php"
* fix php in *.sh files too
* fix trailing spaces from all text files
* fix "explicit_indirect_variable"
* Revert "fix "align_multiline_comment""
This reverts commit 42e584f8e3 .
* fix "align_multiline_comment" properly
* Revert "fix trailing spaces from all text files" - diff files only
* Revert "Revert "fix trailing spaces from all text files" - diff files only"
This reverts commit 2101c2a3a3 .
* rm useless "setup-php" config
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Aleksander Machniak
fd39eecb48
Fix browser tests regression
2021-12-07 15:22:20 +01:00
Aleksander Machniak
893216cb29
Unified and simplified services connection options ( #8310 )
2021-12-07 15:07:54 +01:00
Aleksander Machniak
50a3a6fd81
Fix database initialization for the browser tests
2021-10-03 17:01:32 +02:00
Aleksander Machniak
9c91580ab5
Browser tests: Force imap reconnection often
2021-08-04 13:02:03 +02:00
Aleksander Machniak
5aa0d09def
Add array_first() helper, fix some code issues
2020-12-20 09:44:17 +01:00
Aleksander Machniak
f4ed1024dc
PHP8 fixes, CS fixes, short array syntax, tests
2020-12-02 20:15:00 +01:00
Aleksander Machniak
545a1569f1
Steps -> Actions refactoring ( #7688 )
...
* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes
2020-11-01 11:25:38 +01:00
Aleksander Machniak
b2391417b3
Tests: Add browser test for #7231
2020-02-26 20:18:48 +01:00
Aleksander Machniak
80a244756d
Tests: Add couple of HTML editor tests (including bug #7230 )
2020-02-23 19:05:21 +01:00
Aleksander Machniak
8080eb2c71
Tests: Fix database locking bug
2020-01-24 21:28:07 +01:00
Aleksander Machniak
84aa5d93f1
Tests: Added browser tests for Archive plugin
2020-01-24 12:07:58 +01:00
Aleksander Machniak
d1b61410fc
Tests: Add Dialog component
2020-01-19 14:02:37 +01:00
Aleksander Machniak
c2c85b0a76
Tests: Fix Print test on mobile, make GreenMail quiet on folder deletion
2020-01-17 19:58:57 +01:00
Aleksander Machniak
c138567ab5
Support 'greenmail' as an imap vendor label, don't call ID when not supported
2020-01-17 15:42:12 +01:00
Aleksander Machniak
4258acf57f
Tests: Return proper exit code on error from bootstrap
2020-01-17 10:33:27 +01:00
Aleksander Machniak
5a6606a245
Tests: Add folder creation test
2020-01-16 20:57:33 +01:00
Aleksander Machniak
31b0275573
Add basic browser tests for message menu and open in new window feature
2020-01-09 20:25:26 +01:00
Aleksander Machniak
f72054e761
Tests: Create Browser and Components for better code structure
2020-01-04 14:01:16 +01:00
Aleksander Machniak
59e1efb595
Add more in-browser tests
2020-01-01 18:20:13 +01:00
Aleksander Machniak
31b33c0f39
Don't require config.inc.php when only config-<env>.inc.php exists
2019-12-30 13:45:38 +01:00
Aleksander Machniak
15885055ca
Travis: Try to debug why in-browser tests do not work
2019-12-30 13:24:15 +01:00
Aleksander Machniak
0b9ff6426e
Rewrite Selenium tests with use of laravel/dusk
2019-12-29 12:00:15 +01:00