Commit Graph

33 Commits

Author SHA1 Message Date
Michael Voříšek
f4272804d6 Rename test files for PHPUnit 10+ (#9477) 2024-06-05 07:46:51 +02:00
Michael Voříšek
6a5f9ee7ce Add override method attributes (#9272) 2024-06-02 15:57:56 +02:00
Aleksander Machniak
3b159a1c25 Code improvements in the spellchecker classes 2024-03-17 10:19:25 +01:00
Michael Voříšek
d18406a8bd Fix binary operator spaces CS (#9330)
* align_single_space_minimal for assign

* assign operators grouping is not supported by PHP CS Fixer

* binary_operator_spaces = single_space

* fix anonymous function on single line

* align comments manually
2024-02-02 07:53:34 +01:00
Aleksander Machniak
343561b597 Fix regression in the browser tests 2024-01-27 16:12:14 +01:00
Aleksander Machniak
c63ec982b2 Fix PHPStan errors in tests/Browser/ 2024-01-27 15:34:36 +01:00
Michael Voříšek
4ee79b9e84 fix "explicit_string_variable" (#9315) 2024-01-22 08:05:59 +01:00
Michael Voříšek
54f4aa33f9 Fix CS - imports (#9316)
* fix Tests\Browser\TestCase imports

* fix remaining imports

* fix PHPUnit\Framework\TestCase imports

* import GuzzleHttp\Client

* fix remaining

* "php_unit_method_casing" is not todo

* fix "single_line_comment_spacing"

* fix 2nd commit done using older fixer
2024-01-21 19:13:31 +01:00
Michael Voříšek
a797873ef5 Fix "phpdoc_no_empty_return" CS (#9302)
* replace void with never return type

* replace "return void" phpdoc with native type in tests

* replace "return void" phpdoc with native type in rcube_addressbook

* replace "return void" phpdoc with native type in rcmail_oauth

* fix remaining
2024-01-05 19:03:58 +01:00
Michael Voříšek
6a53a1d853 Fix CS (whitespace, visibility) (#9297)
* Fix "method_argument_space"

* Fix "control_structure_continuation_position"

* Fix "new_with_parentheses"

* Fix "blank_line_before_statement"

* Fix "visibility_required"

* Fix some "array_indentation"

* Fix some "array_indentation" - unify all "rcube::raise_error" calls

* rm useless eslint ignores and add rules counts

* sort eslint ignores

* fix eslint ignores grammar

* Revert "Fix "blank_line_before_statement""

* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa Fix single quotes CS (#9283)
* Fix "single_quote"

* fix "escape_implicit_backslashes"

* fix typo from f363481c

* fix single quotes in JS

* fix some minor JS CS

* fix CS v3.45.0
2023-12-31 16:36:55 +01:00
Michael Voříšek
a9167a0d2f Fix "static_lambda" CS (#9276) 2023-12-20 20:01:00 +01:00
Michael Voříšek
a8707ae220 Fix and assert basic CS using CI (#9246)
* Assert CS using CI

* fix "single_blank_line_at_eof"

* fix "statement_indentation"

* fix "switch_case_semicolon_to_colon"

* fix "control_structure_braces"

* fix "statement_indentation"

* fix "no_whitespace_in_blank_line"

* fix "no_trailing_whitespace_in_comment"

* fix "no_trailing_whitespace"

* fix "single_space_around_construct"

* fix "spaces_inside_parentheses"

* fix "ternary_operator_spaces"

* fix "trim_array_spaces"

* fix "whitespace_after_comma_in_array"

* fix "cast_spaces"

* fix "unary_operator_spaces"

* fix "no_trailing_comma_in_singleline"

* fix "ordered_imports"

* fix "no_unused_imports"

* Check composer.json format

* fix CI job name

* file header comments are not phpdoc

* fix "phpdoc_indent"

* fix "braces_position"

* fix "phpdoc_types"

* fix "no_blank_lines_after_class_opening"

* fix "no_multiple_statements_per_line"

* fix "multiline_comment_opening_closing"

* fix "single_line_empty_body"

* fix "non_printable_character"

* fix "phpdoc_trim_consecutive_blank_line_separation"

* fix "include"

* fix "no_mixed_echo_print"

---------

Co-authored-by: Aleksander Machniak <alec@alec.pl>
2023-12-16 15:37:43 +01:00
Aleksander Machniak
965fd90284 Browser Tests: The last attempt on mobile menu issues
If this does not work I give up. Tests work on my computer, but not on GA,
and I don't know really why.
2023-11-26 18:29:26 +01:00
Aleksander Machniak
1266e4782b Browser Tests: Another attempt on flaky mobile menus 2023-11-26 17:16:34 +01:00
Aleksander Machniak
53374f61d2 Browser Tests: Flaky mobile menus, another attempt 2023-11-26 16:06:47 +01:00
Aleksander Machniak
afdfdf6a83 Browser Tests: Another attempt on fixing flaky menus on mobile 2023-11-26 15:59:37 +01:00
Aleksander Machniak
da6300dcc7 Browser Tests: Less flaky menus handling on mobile 2023-11-26 15:46:43 +01:00
Aleksander Machniak
d29236e175 Browser tests: Fix "stale element reference" errors 2023-10-21 21:30:00 +02:00
Aleksander Machniak
acc6b72f12 Use smaller interval 2022-07-10 09:25:31 +02:00
Aleksander Machniak
8bf7f64c4f Browser tests: Increase pause in mobile toolbar menu testing 2022-07-09 19:00:21 +02:00
Aleksander Machniak
8fdb7e8c55 Try to fix browser tests 2022-07-09 18:54:35 +02:00
Aleksander Machniak
545a1569f1 Steps -> Actions refactoring (#7688)
* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes
2020-11-01 11:25:38 +01:00
Aleksander Machniak
cd3cad6aae TinyMCE 5 (#7403) 2020-07-11 18:46:17 +02:00
Aleksander Machniak
b2391417b3 Tests: Add browser test for #7231 2020-02-26 20:18:48 +01:00
Aleksander Machniak
80a244756d Tests: Add couple of HTML editor tests (including bug #7230) 2020-02-23 19:05:21 +01:00
Aleksander Machniak
6c1e8e1efe Tests: Add Identities tests 2020-01-22 11:56:31 +01:00
Aleksander Machniak
d1b61410fc Tests: Add Dialog component 2020-01-19 14:02:37 +01:00
Aleksander Machniak
d979aa0584 Tests: Add more browser tests for Responses 2020-01-19 11:58:20 +01:00
Aleksander Machniak
31b0275573 Add basic browser tests for message menu and open in new window feature 2020-01-09 20:25:26 +01:00
Aleksander Machniak
e2bd4548ed Tests: Move logon helpers to the App component 2020-01-04 19:12:12 +01:00
Aleksander Machniak
cf8277ea3e Tests: Try to fix test that fails on Travis, but not on my setup 2020-01-04 14:30:57 +01:00
Aleksander Machniak
f72054e761 Tests: Create Browser and Components for better code structure 2020-01-04 14:01:16 +01:00