Commit Graph

8255 Commits

Author SHA1 Message Date
Bostjan Skufca
a15b2d5998 Autocomplete refactoring: replace variable name '$id' with '$abook_id'
Reason:
Having genericly named variable $id in nested loops makes code unreadable.
Replacing generic name '$id' with '$ENTITIY_id' format removes all ambiguity.
2016-04-14 02:39:54 +02:00
Bostjan Skufca
ed55af4aa9 Autocomplete: trigger "contacts_autocomplete_after" hook processing
Provide existing list of contact suggestions as an argument - it might be unclear
now what logic plugin developers decide to implement, but data for that logic
should be provided upfront, and that includes list of suggestions that RC
itself comes up with.

Plugin logic might then replace the list entirely, or just rearrange its entries, or use
part of the list when it runs out of own ideas, or do something entirely different.
2016-04-14 02:28:19 +02:00
Bostjan Skufca
865230e420 Autocomplete: fix undefined variable notice if no addressbook is configured for autocomplete 2016-04-14 02:28:09 +02:00
Aleksander Machniak
e2e56261b9 Fix handling of long script/style tags when converting to text 2016-04-13 13:08:43 +02:00
Aleksander Machniak
a0f38f5fd8 Small code style improvements 2016-04-12 13:46:30 +02:00
Aleksander Machniak
e8ab3d96bd Fix converting mail addresses with @www. into mailto links (#5197) 2016-04-12 11:53:04 +02:00
Aleksander Machniak
d01c06eded CS fixes 2016-04-10 10:47:35 +02:00
Bostjan Skufca
70a8236cd5 mailbox/listing: Make server response for large mailbox listing faster when using threaded view
Symptom
=======
When using roundcube with mailboxes with over 60k messages, list
view was way faster than viewing in threaded view.

Mailbox index view timing:    ~360 ms
Mailbox threaded view timing: ~800 ms

Resolution
==========
Use native PHP array manipulation functions instead of rolling custom
string data reversal implementation using strpos() and substr() in a
'while' loop.

This optimization is already present in index view handler, but was missing
from threaded view.

Results after optimization
==========================
Both average out around ~360 ms response time.
2016-04-09 15:20:28 +02:00
Aleksander Machniak
4fdcd8c9d1 Remove redundant code 2016-04-08 13:34:00 +02:00
Bernardo Silva
c72446a8fc Allow pattern attribute in input
"pattern" included in the list of allowed attributes in the input tag
2016-04-05 11:30:22 -03:00
Aleksander Machniak
6f2c007d1b CS fixes: Replace use of "bool ? true : false" with just "bool" 2016-04-02 13:02:55 +02:00
Aleksander Machniak
5c253dd59e Fix so SPECIAL-USE assignments are forced only until user sets special folders (#4782)
The old behaviour where SPECIAL-USE has always a prio can be bringed back
by setting lock_special_folders=false and adding it to dont_override.
2016-04-02 09:09:43 +02:00
Aleksander Machniak
aba88576ef Update localizations 2016-03-28 18:36:56 +02:00
Aleksander Machniak
7462095f60 Small code improvements 2016-03-28 14:29:35 +02:00
Aleksander Machniak
46f7b70964 Enable reply/reply-all/forward buttons also in preview frame of message/rfc822 2016-03-28 12:51:43 +02:00
Aleksander Machniak
e8b6e726f6 Add message menu with viewsource and edit actions in message/rfc822 preview 2016-03-26 14:02:57 +01:00
Aleksander Machniak
d125f864ea Message/rfc822 previewer compatibility with Enigma 2016-03-25 13:41:11 +01:00
Aleksander Machniak
640e5e265d Enigma: Handle encrypted/signed content inside message/rfc822 attachments 2016-03-25 13:26:29 +01:00
Aleksander Machniak
4e6f3019f5 Enigma: Handle encrypted/signed content inside message/rfc822 attachments 2016-03-25 13:25:44 +01:00
Aleksander Machniak
ce3105c58f Reply/Reply-All/Forward/Change-format buttons for message/rfc822 preview 2016-03-24 17:07:31 +01:00
Aleksander Machniak
323fa20bc8 Message/rfc822 attachment preview (#5054) 2016-03-23 16:54:31 +01:00
Danilo
1db4c05078 Fix: Set long email addresses
The changes permit to set long email address up to the maximum permissible length.
2016-03-22 10:56:09 +01:00
Aleksander Machniak
05972d7b33 Refer to Github issues instead of Trac 2016-03-21 08:14:11 +01:00
Aleksander Machniak
791ee65d2e Fix so contactlist_fields option can be set via config file 2016-03-18 12:29:29 +01:00
Aleksander Machniak
348ec70f12 Export vCard PHOTO with "ENCODING=b" (instead of "ENCODING=B") as specified in RFC2426 2016-03-15 15:18:09 +01:00
Aleksander Machniak
3a13b5dab8 CS fixes 2016-03-14 09:18:53 +01:00
Aleksander Machniak
0c9e55b0c9 Fix PHP warning when defaults.inc.php is not readable 2016-03-14 08:41:28 +01:00
Aleksander Machniak
bf91666621 Revert "Update to jQuery 2.2.1"
This reverts commit 940b966fac.

There are issues with jQuery-UI 1.10 we use and it's actually
too late for such a change now when we want 1.2 release soon.
2016-03-09 09:07:52 +01:00
Thomas Bruederli
4a408843b0 Protect download urls against CSRF using unique request tokens (#1490642)
Send X-Frame-Options headers with every HTTP response
2016-03-06 14:31:07 +01:00
Aleksander Machniak
d4df3748cf Require Net_Socket >= 1.0.12 (because of timeout=0 bugfix) 2016-03-04 15:34:51 +01:00
Aleksander Machniak
ca34ba139e CS fixes 2016-03-03 12:51:34 +01:00
Aleksander Machniak
940b966fac Update to jQuery 2.2.1 2016-02-29 12:27:25 +01:00
Aleksander Machniak
b0a8e36930 Fix handling of body parameter in mail compose request 2016-02-24 11:18:09 +01:00
Aleksander Machniak
faeeebdc55 Hide DSN option in Preferences when smtp_server is not used (#1490666) 2016-02-23 09:02:58 +01:00
Aleksander Machniak
9ae41d906e Fix unicode-awareness of Base64 encoding implementation in javascript 2016-02-22 18:35:14 +01:00
Aleksander Machniak
8bbb454524 Fix list row selection when provided uid is number not a string 2016-02-14 12:47:30 +01:00
Aleksander Machniak
a62ff159f0 Performance: Make sure that after contact update we call get_record() only once 2016-02-13 11:50:59 +01:00
Aleksander Machniak
d686b57c72 Fix bug where contacts widget in compose could be incorrectly initialized with treelist widget (T998)
Fix typo in command name (list-adresses -> list-addresses)
2016-02-12 09:34:59 +01:00
Aleksander Machniak
4c0cb96a48 Enigma: Fix missing html/plain switch on multipart/signed messages (#1490649) 2016-02-07 13:30:48 +01:00
Aleksander Machniak
e91c35c534 Fix background color on selected and focused addressbook 2016-02-03 13:59:31 +01:00
Aleksander Machniak
332ffef199 Plugin API: Added addressbook_export hook 2016-02-02 11:41:45 +01:00
Aleksander Machniak
8dc756f319 Fix bug in long recipients list parsing for cases where recipient name contained @-char (#1490653) 2016-02-01 14:25:00 +01:00
Aleksander Machniak
c10eae0884 Fix bug where Archive/Junk buttons were not active after page jump with select=all mode (#1490647) 2016-01-27 08:47:12 +01:00
Aleksander Machniak
53fa08d8ae Enigma: Code refactoring with better handling of encrypted-inside-encrypted (e.g. forwarded) and signed+ncrypted messages 2016-01-25 09:53:33 +01:00
Aleksander Machniak
c9e2ab488e Enigma: Fix handling of encrypted + signed messages (#1490632) 2016-01-21 11:05:01 +01:00
Aleksander Machniak
0e77b6f1b3 Fix regression where xml mode could be used to parse xhtml messages causing empty result 2016-01-20 08:44:31 +01:00
Aleksander Machniak
bffca14d96 Exit when imagecreatetruecolor() fails 2016-01-19 09:37:29 +01:00
Aleksander Machniak
22a018d082 Merge branch 'dev-svg' 2016-01-18 09:47:52 +01:00
Aleksander Machniak
ed1d212ae2 Improved SVG cleanup code 2016-01-16 09:03:51 +01:00
Aleksander Machniak
023d3eb031 Refactor wash_attribs() - fix regressions 2016-01-12 13:57:30 +01:00