Commit Graph

56 Commits

Author SHA1 Message Date
Aleksander Machniak
ca51b317b9 Add annotate_message() to the storage interface 2024-12-11 15:08:44 +01:00
Aleksander Machniak
15659d7815 PHPCS: phpdoc_annotation_without_dot=true (default) 2024-04-14 10:32:35 +02:00
Aleksander Machniak
20d9edce04 Code improvements 2024-03-31 19:22:56 +02:00
Aleksander Machniak
58d28297a3 Code improvements, PHPDoc fixes 2024-03-29 16:18:20 +01:00
Aleksander Machniak
1c706cc987 Fix CS/phpstan error 2024-02-10 20:51:38 +01:00
Aleksander Machniak
a1f39f47b7 Fix phpstan errors 2024-02-10 19:20:04 +01:00
Aleksander Machniak
966274d835 Fix phpstan errors 2024-02-09 21:11:50 +01:00
Michael Voříšek
d18406a8bd Fix binary operator spaces CS (#9330)
* align_single_space_minimal for assign

* assign operators grouping is not supported by PHP CS Fixer

* binary_operator_spaces = single_space

* fix anonymous function on single line

* align comments manually
2024-02-02 07:53:34 +01:00
Aleksander Machniak
9e5c019936 Fix some phpstan errors 2024-01-28 14:44:28 +01:00
Aleksander Machniak
6dac0e1b65 Fix various PHPDoc issues 2024-01-25 14:51:09 +01:00
Aleksander Machniak
70faac5d2b Add abstract method rcube_storage::fetch_headers() 2024-01-24 14:38:46 +01:00
Michael Voříšek
b1a0067e5d Fix more CS (#9303)
* fix "class_attributes_separation"

* fix "ternary_to_null_coalescing"

* fix "no_extra_blank_lines"

* fix "php_unit_data_provider_name" - use snake_case

* fix remaining "function data_" manually

* move "php_unit_test_case_static_method_calls" to a better place in cnf

* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Michael Voříšek
6a53a1d853 Fix CS (whitespace, visibility) (#9297)
* Fix "method_argument_space"

* Fix "control_structure_continuation_position"

* Fix "new_with_parentheses"

* Fix "blank_line_before_statement"

* Fix "visibility_required"

* Fix some "array_indentation"

* Fix some "array_indentation" - unify all "rcube::raise_error" calls

* rm useless eslint ignores and add rules counts

* sort eslint ignores

* fix eslint ignores grammar

* Revert "Fix "blank_line_before_statement""

* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Edouard Vanbelle
0e4c35797d core: correct coding style warning (#9284)
Signed-off-by: Edouard Vanbelle <edouard@vanbelle.fr>
2023-12-26 09:04:54 +01:00
Aleksander Machniak
90555d228e Define missing functions in rcube_storage 2023-12-23 20:29:44 +01:00
Michael Voříšek
e7d7e62146 Modernize more basic CS II (#9254)
* fix "integer_literal_case"

* fix "phpdoc_separation"

* fix "phpdoc_var_without_name"

* fix "operator_linebreak"

* fix "no_alias_language_construct_call"

* fix "list_syntax"

* fix "concat_space"

* fix "array_syntax"

* fix "binary_operator_spaces"

* fix "binary_operator_spaces" relaxed

* fix "phpdoc_types_order"

* fix "phpdoc_trim"

* fix "native_type_declaration_casing"

* fix "method_chaining_indentation"

* fix "phpdoc_no_package"

* fix "elseif"

* fix PHP CS Fixer config itself too

* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191 Modernize more basic CS (#9258)
* fix "yoda_style"

* fix "is_null"

* rm useless rule ignores

* add full "PhpCsFixer:risky" ruleset

* fix "implode_call"

* fix "no_alias_functions"

* fix "array_push"

* fix "long_to_shorthand_operator"

* fix "ternary_to_elvis_operator"

* fix "logical_operators"

* fix "fopen_flags"

* rename "returns" phpdoc tags to "return"

* fix "php_unit_construct"

* fix "function_to_constant"

* fix "php_unit_data_provider_return_type"

* fix "php_unit_set_up_tear_down_visibility"

* some safe "string_length_to_empty"

* fix "phpdoc_align"

* fix "phpdoc_no_alias_tag"

* fix "trailing_comma_in_multiline"

---------

Co-authored-by: Aleksander Machniak <alec@alec.pl>
2023-12-17 09:51:11 +01:00
Michael Voříšek
a8707ae220 Fix and assert basic CS using CI (#9246)
* Assert CS using CI

* fix "single_blank_line_at_eof"

* fix "statement_indentation"

* fix "switch_case_semicolon_to_colon"

* fix "control_structure_braces"

* fix "statement_indentation"

* fix "no_whitespace_in_blank_line"

* fix "no_trailing_whitespace_in_comment"

* fix "no_trailing_whitespace"

* fix "single_space_around_construct"

* fix "spaces_inside_parentheses"

* fix "ternary_operator_spaces"

* fix "trim_array_spaces"

* fix "whitespace_after_comma_in_array"

* fix "cast_spaces"

* fix "unary_operator_spaces"

* fix "no_trailing_comma_in_singleline"

* fix "ordered_imports"

* fix "no_unused_imports"

* Check composer.json format

* fix CI job name

* file header comments are not phpdoc

* fix "phpdoc_indent"

* fix "braces_position"

* fix "phpdoc_types"

* fix "no_blank_lines_after_class_opening"

* fix "no_multiple_statements_per_line"

* fix "multiline_comment_opening_closing"

* fix "single_line_empty_body"

* fix "non_printable_character"

* fix "phpdoc_trim_consecutive_blank_line_separation"

* fix "include"

* fix "no_mixed_echo_print"

---------

Co-authored-by: Aleksander Machniak <alec@alec.pl>
2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a Fix invalid phpdocs (#9252)
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Aleksander Machniak
81cc8ac0e0 Purge also subfolders of Trash (and/or messages in them) on logout (#1037) 2021-10-09 16:55:28 +02:00
Aleksander Machniak
d7338a4203 Add option to purge deleted mails older than 30, 60 or 90 days (#5493) 2021-08-29 11:06:04 +02:00
Aleksander Machniak
8b10f9d6ea Warn the user about a potential data leak on mail bounce or forward (#7993) 2021-05-01 12:45:31 +02:00
Josh Soref
203f456620 Spelling (#8001) 2021-04-18 08:43:18 +02:00
Aleksander Machniak
5aa0d09def Add array_first() helper, fix some code issues 2020-12-20 09:44:17 +01:00
Aleksander Machniak
f4ed1024dc PHP8 fixes, CS fixes, short array syntax, tests 2020-12-02 20:15:00 +01:00
Aleksander Machniak
7e5301f636 CS fixes, short array syntax, PHP8 fixes, tests 2020-11-28 18:52:36 +01:00
Aleksander Machniak
a5c2b4360c Fixes in context of undefined variables, and code style 2020-08-15 12:13:31 +02:00
Aleksander Machniak
e7ebff56df PHPDoc fixes 2019-09-30 20:43:07 +02:00
Aleksander Machniak
1afa46d28d PHPDoc and CS fixes 2019-08-25 14:15:09 +02:00
Aleksander Machniak
57c67db029 Remove year(s) from copyright headers + some cleanup 2019-04-16 10:42:45 +02:00
Aleksander Machniak
1247a8dd7d Fix bug where some forbidden characters on Cyrus-IMAP were not prevented from use in folder names 2018-05-08 12:20:11 +02:00
Aleksander Machniak
76adb49454 Support for IMAP folders that cannot contain both folders and messages (#5057) 2017-07-14 13:39:49 +02:00
Aleksander Machniak
5804ef8aa2 Fix folders list sorting on Windows - if php-intl is available (#5732) 2017-05-08 10:37:06 +02:00
ka7
9a35768c26 spelling fixes (#5690) 2017-03-12 12:14:19 +01:00
Aleksander Machniak
7e3298753a Use ternary operator where aplicable 2015-11-14 10:08:07 +01:00
Aleksander Machniak
427ab2f393 Optimize folder_size() on Cyrus IMAP by using special folder annotation (#1490514) 2015-09-02 15:17:44 +02:00
Aleksander Machniak
0868c2e841 Make sure list page is never set to 0 (#1490458)
This should fix the issue where after message move wrong message was
added to the list and the list counter was invalid.
2015-08-06 09:25:15 +02:00
Aleksander Machniak
f7427f151e Get rid of Mail_mimeDecode package dependency (#1490416) 2015-06-27 15:05:17 +02:00
Aleksander Machniak
a958748947 CS fixes 2015-06-07 15:26:33 +02:00
Aleksander Machniak
9af8e22b8e Plugin API: added message_part_body hook, fixes around message structure handling by plugins 2015-03-08 10:51:19 +01:00
Aleksander Machniak
6fa1a0da1f Extend get_quota() so it's possible to specify GETQUOTAROOT folder and return full quota info (including all roots and types, e.g. MESSAGE) - for future use 2014-06-24 19:16:18 +02:00
Aleksander Machniak
47a7833aca CS fixes 2014-05-15 13:57:18 +02:00
Aleksander Machniak
dc0b500e78 Removed redundant default_folders config option (#1489737)
Implemented IMAP SPECIAL-USE extension support [RFC6154] (#1487830)
2014-04-01 19:27:07 +02:00
Aleksander Machniak
03de1329ef Fix invalid X-Draft-Info on forwarded message draft (#1489587) 2014-02-11 09:06:53 +01:00
Aleksander Machniak
ac0fc383fd Fix so message flags modified by another client are applied on the list on refresh (#1485186) 2013-12-23 11:33:41 +01:00
Aleksander Machniak
05da1577aa Fix setting of Junk and NonJunk flags by markasjunk plugin (#1489285)
Added possibility to register flag mappings by a plugin.
2013-08-29 09:20:33 +02:00
Aleksander Machniak
b825f86108 Move identity selection based on non-standard headers into (new) identity_select plugin (#1488553) 2013-08-04 10:41:02 +02:00
Aleksander Machniak
d764723142 Improve IMAP APPEND handling so it can read message (parts) from file pointer(s)
and make it less memory consuming
2013-06-20 14:17:33 +02:00
Aleksander Machniak
60b6d7c389 Fix database cache expunge issues (#1489149) - added 'expires' column 2013-06-09 11:07:46 +02:00
Aleksander Machniak
6e8f2a7448 Notify about a new mail only if it's UNSEEN (#1388965) 2013-03-16 19:01:10 +01:00