Philip Weir
ccede1f272
Update links in comments and config to https where available ( #9759 )
2025-01-26 13:34:57 +01:00
Michael Voříšek
a30e0ad438
Infer file/line location in rcube::raise_error() from backtrace ( #9422 )
...
* \n\s+'file' => __FILE__,
* \n\s+'line' => __LINE__,
* 'line' => __LINE__, 'file' => __FILE__,
* 'file' => __FILE__, 'line' => __LINE__,
* rest
* more
* improve cs
* more cs
* revert rcube_utils::preg_error changes
* impl file/line from backtrace
* Revert "revert rcube_utils::preg_error changes"
2024-04-21 11:48:35 +02:00
Aleksander Machniak
15659d7815
PHPCS: phpdoc_annotation_without_dot=true (default)
2024-04-14 10:32:35 +02:00
Aleksander Machniak
2f5f3bd0de
Code improvements
2024-03-24 10:29:31 +01:00
Michael Voříšek
d18406a8bd
Fix binary operator spaces CS ( #9330 )
...
* align_single_space_minimal for assign
* assign operators grouping is not supported by PHP CS Fixer
* binary_operator_spaces = single_space
* fix anonymous function on single line
* align comments manually
2024-02-02 07:53:34 +01:00
Michael Voříšek
ff2d721680
Fix more CS whitespace ( #9318 )
...
* fix "no_useless_else" manually
* fix some "blank_line_before_statement"
* two manual changes
* Revert "fix some "blank_line_before_statement""
This reverts commit 2cc857c00e
2024-01-25 19:17:29 +01:00
Michael Voříšek
4ee79b9e84
fix "explicit_string_variable" ( #9315 )
2024-01-22 08:05:59 +01:00
Michael Voříšek
b1a0067e5d
Fix more CS ( #9303 )
...
* fix "class_attributes_separation"
* fix "ternary_to_null_coalescing"
* fix "no_extra_blank_lines"
* fix "php_unit_data_provider_name" - use snake_case
* fix remaining "function data_" manually
* move "php_unit_test_case_static_method_calls" to a better place in cnf
* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a
Fix invalid phpdocs ( #9252 )
...
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Aleksander Machniak
80404a8674
Store uploads metadata in a separate sql database table instead of a session ( #8415 )
2022-10-09 11:35:14 +02:00
Aleksander Machniak
fa65a68389
Use ... oprator instead of func_get_args() for variadic functions
2022-04-27 19:21:00 +02:00
Josh Soref
203f456620
Spelling ( #8001 )
2021-04-18 08:43:18 +02:00
johndoh
dec10e51da
Support providing skins for plugins inside the main skin folder ( #7445 )
2020-12-21 09:45:34 +01:00
Aleksander Machniak
8110ed9a9d
PHP8 fixes, CS fixes, short array syntax, tests
2020-11-30 20:37:50 +01:00
Michael Stilkerich
bad1dedbf6
Phpdoc type annotations ( #7733 )
2020-11-21 09:34:24 +01:00
Aleksander Machniak
f95212d626
PHP8: More warnings fixed
2020-10-11 15:24:30 +02:00
Aleksander Machniak
a5c2b4360c
Fixes in context of undefined variables, and code style
2020-08-15 12:13:31 +02:00
Michael Stilkerich
25e42439d2
Fix inconsistencies in phpdoc type annotations ( #7474 )
2020-07-25 09:59:01 +02:00
Aleksander Machniak
e7ebff56df
PHPDoc fixes
2019-09-30 20:43:07 +02:00
Aleksander Machniak
b10a0dbb7e
Reset internal $skins property is set_skin()
2019-09-08 11:37:16 +02:00
Jack Cherng
20bf625733
Remove a unused variable in rcube_plugin::include_stylesheet() ( #6832 )
...
Signed-off-by: Jack Cherng <jfcherng@gmail.com >
2019-07-02 09:03:32 +02:00
Aleksander Machniak
57c67db029
Remove year(s) from copyright headers + some cleanup
2019-04-16 10:42:45 +02:00
Aleksander Machniak
430c000e32
Support skin localization ( #5853 )
2018-05-11 09:59:27 +02:00
Aleksander Machniak
9ce8948294
Get rid of the 2nd argument of include_stylesheet()
...
.. make the optional behavior default now.
2017-11-20 14:03:07 +01:00
Aleksander Machniak
69f50b122d
Add a way to include plugin stylesheets optionally only if the file exists
2017-08-06 19:46:22 +02:00
Aleksander Machniak
a958748947
CS fixes
2015-06-07 15:26:33 +02:00
Aleksander Machniak
db357b4187
Remove redundant default
2014-10-30 12:48:11 +01:00
Aleksander Machniak
1ffab0ad4a
Fix possible issues in skin/skin_path config handling ( #1490125 )
2014-10-30 12:34:16 +01:00
Aleksander Machniak
5d8f8b59f3
Correct load_config() return value with improvement in last commit
2014-10-30 09:00:47 +01:00
Aleksander Machniak
ab5b89b854
Improve load_config() so when called many times it will read config file only once
2014-10-30 08:59:52 +01:00
JohnDoh
4eee212883
add include_plugin function for optoinal plugins
2014-08-16 07:05:30 +01:00
Thomas Bruederli
65baa033e0
List all plugins which have been attempted to load ( #1488871 )
2014-08-03 19:17:23 +02:00
Thomas Bruederli
b0ce5c62af
Make skin meta/hierarchy information accessible for plugins ( #1488831 )
2014-05-01 09:05:29 +02:00
Thomas Bruederli
c5f6352710
Don't log error if no plugin config is found in global directories
2014-01-16 08:50:07 +01:00
Thomas Bruederli
aa581c2912
Fall back to load plugin config from global config directories only if no local config file exists
2014-01-14 17:04:24 +01:00
Takika
d073a66db3
Load plugin config file from any configured path
...
Try to load plugin_name.inc.php config file from any pre-configured config path (rcube_config::path array) so webmail admins can move plugin configurations out of www root.
2014-01-07 14:32:33 +01:00
Thomas Bruederli
cf31954661
Make require_plugin() force loading of the required plugin
2013-11-14 18:58:23 +01:00
Aleksander Machniak
52f2a69855
Added rcube_plugin::add_label() method
2013-05-16 12:59:03 +02:00
Thomas Bruederli
378d6cf97f
Build plugin info from both package.xml and composer.json files; allow plugins to override the meta info method
2013-04-28 13:45:32 +02:00
Aleksander Machniak
648fcf5709
Whitelist configuration options (user preferences) that can be changed using save-pref command
2013-03-27 16:32:51 +01:00
Aleksander Machniak
8b771646fa
Fix so task name can really contain all from a-z0-9_- characters ( #1488941 )
2013-03-10 11:49:20 +01:00
Aleksander Machniak
c4781306a5
CS fixes
2012-12-21 09:13:11 +01:00
Aleksander Machniak
d2534c63f2
Cleanup, remove file paths from doc
2012-12-18 09:07:00 +01:00
Aleksander Machniak
996af3bfd9
Some more rcmail -> rcube cleanup
2012-12-07 11:13:11 +01:00
Aleksander Machniak
ba6f21caeb
Framework files moved to lib/Roundcube
2012-11-21 19:52:03 +01:00
