Commit Graph

230 Commits

Author SHA1 Message Date
Adrien Beau
d8146b6150 Fix sort_folder_comparator (#9057)
In case $path2 is longer than $path1, and all folders in $path1 are
equal to the corresponding folder in $path2 (in other words: $path2 is a
subfolder of $path1), sort_folder_comparator currently considers them
equal because it stops comparing when it reaches the end of $path1.

This breaks the ordering done by uasort() above, and breaks code that
relies on the folder list being sorted, notably the folders settings
page.
2023-07-09 19:51:10 +02:00
Aleksander Machniak
813dacec71 Fix potential PHP fatal error when opening a message with message/rfc822 part (#8953) 2023-07-09 13:18:11 +02:00
Aleksander Machniak
b9de4841d3 Don't log an imap authentication error when log_logins=true 2023-06-15 10:54:38 +02:00
Aleksander Machniak
9d9912c12f Fix bug where subfolders could loose subscription on parent folder rename (#8892) 2023-05-10 21:07:48 +02:00
Aleksander Machniak
33fac1927e Fix PHP 8.1 warnings, make BODYSTRUCTURE parser less fragile (#8803) 2022-11-28 20:34:02 +01:00
Aleksander Machniak
e7f57c6dd5 Fix PHP warning (#8794) 2022-11-26 10:17:29 +01:00
Aleksander Machniak
e111f22d50 Fix a PHP warning (#8743) 2022-11-11 13:26:08 +01:00
Aleksander Machniak
aac9b696b8 Fix various PHP 8.2 warnings 2022-08-06 09:22:12 +02:00
Michael Steininger
38bf246b0d Fix usage of "break" (#8624) 2022-07-21 18:38:08 +02:00
Aleksander Machniak
f23aaed10e Remove use of unreliable charset detection (#8344) 2022-04-09 14:13:50 +02:00
Aleksander Machniak
bfef4691cf Fix PHP8 warning (#8466) 2022-03-12 09:38:54 +01:00
Aleksander Machniak
78b3049ce5 Fix PHPDoc 2022-02-18 19:19:07 +01:00
Aleksander Machniak
06b6089767 Fix handling of RFC2231-encoded attachment names inside of a message/rfc822 part (#8418) 2022-01-29 10:16:48 +01:00
Aleksander Machniak
f429b26810 Fix various PHP8 warnings (#8392) 2022-01-11 19:04:24 +01:00
Aleksander Machniak
81cc8ac0e0 Purge also subfolders of Trash (and/or messages in them) on logout (#1037) 2021-10-09 16:55:28 +02:00
Aleksander Machniak
f2688ba492 Use ?? operator where applicable 2021-09-21 19:12:06 +02:00
Aleksander Machniak
63056eb803 Fix PHP8 warnings (#8175) 2021-09-11 08:59:15 +02:00
Aleksander Machniak
4d233b5c65 Fix strpos(): empty needle warning (#8184) 2021-08-29 18:27:06 +02:00
Aleksander Machniak
e2187b8f2d Fix various PHP 8.1 warnings 2021-08-27 16:52:54 +02:00
Aleksander Machniak
6ff862d7d8 Fix a couple of PHP8 warnings (#8175) 2021-08-25 18:57:50 +02:00
Aleksander Machniak
9caab5f701 Fix PHP8 warnings 2021-07-16 12:57:46 +02:00
Thomas Bruederli
861be4606b Fix phpdoc error 2021-06-21 20:56:12 +02:00
Aleksander Machniak
094ef387e9 Fix bug where plus characters in attachment filename could have been ignored (#8074) 2021-05-28 11:34:20 +02:00
Josh Soref
203f456620 Spelling (#8001) 2021-04-18 08:43:18 +02:00
Aleksander Machniak
dd6aefe1fd Fix bug where imap_conn_options settings were ignored (#7912) 2021-03-04 19:14:28 +01:00
hefee
8ef57a4173 Add 'reconnect' plugin to retry IMAP connection (#7844)
* Make storage_connect hook ready to be usable for reconnect plugins.
* Add reconnect plugin to retry to login into IMAP server.

Co-authored-by: Sandro Knauß <hefee@debian.org>
2021-02-06 16:46:21 +01:00
Aleksander Machniak
17ae3693c3 PHP8 fixes + fix fatal error when refreshing compose page in forward-as-attachment state 2020-12-18 19:27:25 +01:00
Aleksander Machniak
3bbb01fe13 PHP8 fixes, regression fixes 2020-12-13 12:14:15 +01:00
Aleksander Machniak
61a5ade872 PHP8 fixes, short array syntax 2020-12-12 16:20:14 +01:00
Aleksander Machniak
8eb382b4ca PHP8 fixes 2020-12-11 20:29:41 +01:00
Aleksander Machniak
f4ed1024dc PHP8 fixes, CS fixes, short array syntax, tests 2020-12-02 20:15:00 +01:00
Aleksander Machniak
7e5301f636 CS fixes, short array syntax, PHP8 fixes, tests 2020-11-28 18:52:36 +01:00
Aleksander Machniak
596004beb3 More actions tests, code improvements 2020-11-07 12:54:12 +01:00
Aleksander Machniak
545a1569f1 Steps -> Actions refactoring (#7688)
* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes
2020-11-01 11:25:38 +01:00
Aleksander Machniak
f95212d626 PHP8: More warnings fixed 2020-10-11 15:24:30 +02:00
Aleksander Machniak
bde383d051 PHP8: Fix various issues
for now only these I found by running our unit tests, there will be much more
2020-10-11 10:32:41 +02:00
Aleksander Machniak
a5c2b4360c Fixes in context of undefined variables, and code style 2020-08-15 12:13:31 +02:00
Aleksander Machniak
60ccb25bd5 Fix detecting special folders on servers with both SPECIAL-USE and LIST-STATUS (#7525) 2020-07-31 14:36:57 +02:00
Aleksander Machniak
ef9b375ef6 Fix paging of search results on IMAP servers with no SORT capability (#7462)
And simplify some code around.
2020-07-30 13:23:37 +02:00
Aleksander Machniak
d7d7ca046f Cache refactoring (#6312) (#6781) 2020-07-18 13:51:47 +02:00
Aleksander Machniak
e9c592a6e8 Fix bug where subfolders of special folders could have been duplicated on folder list 2020-06-08 20:35:19 +02:00
Aleksander Machniak
4a5efe09f9 Fix bug where a special folder couldn't be created if a special-use flag is not supported (#7147) 2020-04-05 11:04:23 +02:00
Aleksander Machniak
7df358d64e Fix internal cache use in rcube_imap::get_message()
Two folders, personal and shared, can contain the same UIDs, so
we should check UID and folder name when dealing with internally
cached message.
2020-03-19 11:59:05 +01:00
Aleksander Machniak
d194b238c7 Support RFC8438: IMAP STATUS=SIZE - for faster folder size calculation (#7269) 2020-03-08 10:27:28 +01:00
Aleksander Machniak
fe796d4040 Remove useless pass-by-reference 2020-01-31 09:58:03 +01:00
Aleksander Machniak
97e6065897 Extract RFC2231 attachment name from message headers (#6729) (#6783)
* Extract RFC2231 attachment name from message headers (#6729)
* Workaround for attachments with invalid content type (e.g. PDF) (#6816)
2020-01-19 18:46:02 +01:00
Aleksander Machniak
c138567ab5 Support 'greenmail' as an imap vendor label, don't call ID when not supported 2020-01-17 15:42:12 +01:00
Aleksander Machniak
9311c49cf4 Fix unexpected error message when mail refresh involves folder auto-unsubscribe (#6923) 2020-01-12 10:29:53 +01:00
Aleksander Machniak
e8e8c31eb3 Improve namespace roots presentation (#5012) (#6789)
- Display a special icon for other users and shared namespace roots (Elastic)
- Change folders sorting so shared/other users namespaces are listed last

Fixes #5012.
2020-01-05 15:46:38 +01:00
Aleksander Machniak
4cc20eef72 Fix bug where cache keys could exceed length limit specified in db schema (#7004) 2019-11-10 08:56:11 +01:00