PhilW
b5047f71a5
remove pointless variable
2024-11-20 19:16:19 +00:00
PhilW
85bcfe644a
small improvement to invalid vcard logging
2024-11-20 19:16:19 +00:00
PhilW
178c4c13e1
add invalid and error details to vcard import report
2024-11-20 19:16:19 +00:00
Michael Voříšek
efcdce84ba
Keep phpstan strict rules testing ( #9424 )
...
* Revert "Get rid of phpstan/phpstan-strict-rules"
This reverts commit ff59ade31a
2024-11-20 08:13:16 +01:00
PhilW
9e5a18e390
compare both email and name before skipping vcard import
2024-08-25 11:23:29 +01:00
Michael Voříšek
6a5f9ee7ce
Add override method attributes ( #9272 )
2024-06-02 15:57:56 +02:00
Philip Weir
31a19aa0a7
Contacts: add more gender options ( #9430 )
...
* contacts: add more gender options
* add label for other gender
2024-06-01 09:27:30 +02:00
Aleksander Machniak
ff59ade31a
Get rid of phpstan/phpstan-strict-rules
2024-04-21 11:33:51 +02:00
Aleksander Machniak
e086c2c97c
Code improvements
2024-04-07 09:20:52 +02:00
Aleksander Machniak
ec4e4a0028
Fix tests
2024-03-30 15:14:38 +01:00
Aleksander Machniak
8adb052d35
Code improvements, PHPDoc fixes
2024-03-30 14:17:34 +01:00
Aleksander Machniak
8133acba68
Code improvements (and fixes to recent commits)
2024-03-24 12:06:39 +01:00
Aleksander Machniak
a1f39f47b7
Fix phpstan errors
2024-02-10 19:20:04 +01:00
Michael Voříšek
d18406a8bd
Fix binary operator spaces CS ( #9330 )
...
* align_single_space_minimal for assign
* assign operators grouping is not supported by PHP CS Fixer
* binary_operator_spaces = single_space
* fix anonymous function on single line
* align comments manually
2024-02-02 07:53:34 +01:00
Aleksander Machniak
34500a4fa4
Fix "missing return statement" phpstan errors
2024-01-27 19:07:52 +01:00
Michael Voříšek
ff2d721680
Fix more CS whitespace ( #9318 )
...
* fix "no_useless_else" manually
* fix some "blank_line_before_statement"
* two manual changes
* Revert "fix some "blank_line_before_statement""
This reverts commit 2cc857c00e
2024-01-25 19:17:29 +01:00
Michael Voříšek
4ee79b9e84
fix "explicit_string_variable" ( #9315 )
2024-01-22 08:05:59 +01:00
Michael Voříšek
54f4aa33f9
Fix CS - imports ( #9316 )
...
* fix Tests\Browser\TestCase imports
* fix remaining imports
* fix PHPUnit\Framework\TestCase imports
* import GuzzleHttp\Client
* fix remaining
* "php_unit_method_casing" is not todo
* fix "single_line_comment_spacing"
* fix 2nd commit done using older fixer
2024-01-21 19:13:31 +01:00
Michael Voříšek
b1a0067e5d
Fix more CS ( #9303 )
...
* fix "class_attributes_separation"
* fix "ternary_to_null_coalescing"
* fix "no_extra_blank_lines"
* fix "php_unit_data_provider_name" - use snake_case
* fix remaining "function data_" manually
* move "php_unit_test_case_static_method_calls" to a better place in cnf
* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Aleksander Machniak
5761336253
Cleanup some uses of rcube_result_set, avoid calling ->next()
2024-01-17 19:27:09 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2023-12-31 16:36:55 +01:00
Michael Voříšek
3e458fa5fd
Refer native constants unambiguously ( #9275 )
...
* Fix "native_constant_invocation" CS
* "self_accessor" was fixed in 9269 PR
* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
a9167a0d2f
Fix "static_lambda" CS ( #9276 )
2023-12-20 20:01:00 +01:00
Michael Voříšek
28c778b7a0
Modernize more CS III ( #9270 )
...
* fix "single_trait_insert_per_statement"
* fix "empty_loop_condition"
* fix "backtick_to_shell_exec"
* fix "phpdoc_to_comment"
* fix "no_empty_statement"
* fix "heredoc_to_nowdoc"
* fix "class_reference_name_casing"
* fix "align_multiline_comment"
* fix "heredoc_indentation"
* fix "constant_case"
* fix "single_line_comment_style"
* fix "no_null_property_initialization"
* fix "standardize_increment"
* fix "no_unneeded_control_parentheses"
* fix missing NL after "<?php"
* fix php in *.sh files too
* fix trailing spaces from all text files
* fix "explicit_indirect_variable"
* Revert "fix "align_multiline_comment""
This reverts commit 42e584f8e32101c2a3a3
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Aleksander Machniak
901fa1163b
Remove redundant if() condition
2023-06-06 13:00:59 +02:00
Aleksander Machniak
5723849978
Remove 'alt' attribute for contact photo images
...
Loading a contact photo may take a while, displaying the alt text looks ugly
and is redundant.
2023-06-04 10:29:14 +02:00
Aleksander Machniak
fc3cd4484a
Fix QR code images for contacts with non-ASCII characters ( #9001 )
2023-05-04 07:34:55 +02:00
Aleksander Machniak
80c246de8b
Fix contact photo uploading
2023-05-02 14:57:32 +02:00
Aleksander Machniak
158e236b41
Fix PHP warnings
2023-04-10 12:47:16 +02:00
Camilo Sperberg
02cdea4e4b
Fix most common warnings RoundCube 1.6.1 ( #8901 )
2023-03-04 11:41:51 +01:00
Aleksander Machniak
80404a8674
Store uploads metadata in a separate sql database table instead of a session ( #8415 )
2022-10-09 11:35:14 +02:00
Aleksander Machniak
aac9b696b8
Fix various PHP 8.2 warnings
2022-08-06 09:22:12 +02:00
Aleksander Machniak
f429b26810
Fix various PHP8 warnings ( #8392 )
2022-01-11 19:04:24 +01:00
Aleksander Machniak
149a0d4317
Fix PHP fatal error on an undefined constant in contacts import action ( #8277 )
2021-11-02 10:32:21 +01:00
Aleksander Machniak
313a33e0a7
Display telephone numbers as tel: links ( #8240 )
2021-10-29 15:50:56 +02:00
Aleksander Machniak
7337e7608e
Identicon: Make background color of the image to match the current skin colors ( #8256 )
2021-10-25 12:34:22 +02:00
Aleksander Machniak
cca73cc285
Fix missing inputs on contact creation form if the selected source is readonly ( #8255 )
2021-10-24 20:04:14 +02:00
Aleksander Machniak
263003d006
Fix importing contacts with no email address ( #8227 )
2021-10-19 15:25:49 +02:00
Aleksander Machniak
f2688ba492
Use ?? operator where applicable
2021-09-21 19:12:06 +02:00
Aleksander Machniak
7a269a2b84
Replace get_input_value() with get_input_string() where appropriate
2021-09-13 19:31:49 +02:00
Aleksander Machniak
b9d0dc1cf9
Rename session items 'search' and 'search_params' to 'contact_search' and 'contact_search_params'
...
... to fix potential conflict with the session items for mail search.
2021-09-11 09:11:42 +02:00
Aleksander Machniak
bdb336f3ac
Don't generate QR-code when it's not possible
2021-09-09 10:14:28 +02:00
Aleksander Machniak
2c0db244bc
Generate QR-code in svg format if there's xmlwriter extension installed
...
I think xmlwriter is more likely to be installed than imagick.
The size of the png and svg output is almost identical.
2021-08-28 09:29:03 +02:00
johndoh
0c863206f1
Replace Endroid QrCode with BaconQrCode ( #8173 )
2021-08-28 09:09:19 +02:00
Aleksander Machniak
e2187b8f2d
Fix various PHP 8.1 warnings
2021-08-27 16:52:54 +02:00
Aleksander Machniak
0d4a395464
Fix PHP 8.1 deprecation warnings
2021-07-31 07:53:14 +02:00
