Michael Voříšek
6a5f9ee7ce
Add override method attributes ( #9272 )
2024-06-02 15:57:56 +02:00
Michael Voříšek
a30e0ad438
Infer file/line location in rcube::raise_error() from backtrace ( #9422 )
...
* \n\s+'file' => __FILE__,
* \n\s+'line' => __LINE__,
* 'line' => __LINE__, 'file' => __FILE__,
* 'file' => __FILE__, 'line' => __LINE__,
* rest
* more
* improve cs
* more cs
* revert rcube_utils::preg_error changes
* impl file/line from backtrace
* Revert "revert rcube_utils::preg_error changes"
2024-04-21 11:48:35 +02:00
Aleksander Machniak
4959abe07b
Fix regression, cleanup
2024-04-01 13:41:31 +02:00
Aleksander Machniak
02e49ed236
Fix phpstan errors
2024-03-10 18:37:52 +01:00
Michael Voříšek
332c165d28
Fix some basic JS CS ( #9328 )
...
* fix "nonblock-statement-body-position" (fixed already)
* fix "comma-dangle"
* fix "no-regex-spaces"
* fix "new-parens"
* fix "object-curly-newline"
* fix "object-property-newline"
* fix "spaced-comment" semimanually
* fix "no-constant-condition" manually
* fix "unicorn/no-hex-escape"
* fix "unicorn/escape-case"
* fix "quote-props"
* fix "no-whitespace-before-property" - fix bug/typo
* fix "unicorn/empty-brace-spaces"
* fix "keyword-spacing"
* fix "dot-notation"
* fix "no-return-assign" manually
* fix "padding-line-between-statements"
* fix "key-spacing"
* fix "no-else-return" semimanually
* fix some "no-undef"
* fix case cs
* Revert "fix "padding-line-between-statements""
* improve switch/case format I.
* improve switch/case format II.
regex: (^ *(break|return).*)\n *(\n)
* fix safe "eqeqeq"
* fix "radix"
* fix v3.49.0 CS (static providers)
* fix "string_implicit_backslashes" in php files
* fix comments align
* fix test static providers
* fix stan
* disable "final_internal_class" rule
2024-02-06 08:28:19 +01:00
Michael Voříšek
d18406a8bd
Fix binary operator spaces CS ( #9330 )
...
* align_single_space_minimal for assign
* assign operators grouping is not supported by PHP CS Fixer
* binary_operator_spaces = single_space
* fix anonymous function on single line
* align comments manually
2024-02-02 07:53:34 +01:00
Aleksander Machniak
a73a53c8ef
Replace deprecated methods use
2024-01-27 09:58:01 +01:00
Michael Voříšek
4ee79b9e84
fix "explicit_string_variable" ( #9315 )
2024-01-22 08:05:59 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
86eda9f7ed
Fix "increment_style" CS ( #9296 )
...
* Fix "increment_style" CS
* use "post" increment style
2024-01-01 12:23:21 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2023-12-31 16:36:55 +01:00
Michael Voříšek
3e458fa5fd
Refer native constants unambiguously ( #9275 )
...
* Fix "native_constant_invocation" CS
* "self_accessor" was fixed in 9269 PR
* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
28c778b7a0
Modernize more CS III ( #9270 )
...
* fix "single_trait_insert_per_statement"
* fix "empty_loop_condition"
* fix "backtick_to_shell_exec"
* fix "phpdoc_to_comment"
* fix "no_empty_statement"
* fix "heredoc_to_nowdoc"
* fix "class_reference_name_casing"
* fix "align_multiline_comment"
* fix "heredoc_indentation"
* fix "constant_case"
* fix "single_line_comment_style"
* fix "no_null_property_initialization"
* fix "standardize_increment"
* fix "no_unneeded_control_parentheses"
* fix missing NL after "<?php"
* fix php in *.sh files too
* fix trailing spaces from all text files
* fix "explicit_indirect_variable"
* Revert "fix "align_multiline_comment""
This reverts commit 42e584f8e32101c2a3a3
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
5425d1a84a
Fix invalid phpdocs ( #9252 )
...
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Aleksander Machniak
0843196a8b
Remove redundant code specific to the Classic skin
2021-11-14 11:09:07 +01:00
Aleksander Machniak
7a269a2b84
Replace get_input_value() with get_input_string() where appropriate
2021-09-13 19:31:49 +02:00
Aleksander Machniak
766189f524
Fix PHP 8.1 deprecation warnings
2021-07-31 08:38:47 +02:00
Aleksander Machniak
0d4a395464
Fix PHP 8.1 deprecation warnings
2021-07-31 07:53:14 +02:00
Aleksander Machniak
e62c0a8f9b
Small code improvement, use array_first()
2021-05-31 12:42:57 +02:00
Aleksander Machniak
d88cadf1f2
Fix a few E_NOTICE issues
2020-12-20 10:36:41 +01:00
Aleksander Machniak
3bbb01fe13
PHP8 fixes, regression fixes
2020-12-13 12:14:15 +01:00
Aleksander Machniak
ed146b68db
PHP8 fixes, CS fixes, short array syntax, tests
2020-12-10 20:27:32 +01:00
Aleksander Machniak
545a1569f1
Steps -> Actions refactoring ( #7688 )
...
* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes
2020-11-01 11:25:38 +01:00
Aleksander Machniak
66fab8cdb2
CS fixes, Avoid usused variables, fixed minor bugs
2019-10-05 19:44:39 +02:00
Aleksander Machniak
f1e911ec03
Elastic: Toolbar/menus/layout refactoring
...
Refactoring for better consistency and simplicity.
5KB less in size of (minified) styles.css file.
Layout changes:
- body > #layout > .menu -> #layout-menu
- body > #layout > .list -> #layout-list
- body > #layout > .sidebar -> #layout-sidebar
- body > #layout > .content -> #layout-content
Toolbar/menu changes:
- .toolbar -> .toolbar.menu
- .toolbarmenu -> .menu.listing
- .menu-button -> .task-menu-button
- .pagenav.toolbar -> .pagenav.menu
- #taskmenu -> #taskmenu.menu.toolbar
- .image-tools .menu -> .image-tools .menu.toolbar
- required .disabled class to de-activate menu items
- .button class is not required on .menu children
- merge toolbar.less and taskmenu.less into menu.less
- @color-toolbarmenu-hover -> @color-menu-hover
- @color-toolbarmenu-hover-background -> @color-menu-hover-background
Also cleaned/removed some code in spellchecker.js. Made .googie_list a list not table.
2019-03-24 19:25:56 +01:00
PhilW
e024f133fa
give all temp files a constant prefix
2018-11-06 07:11:04 +00:00
Caio Nardi
43fcf5bce7
Fix checking duplicated names in the zip file ( #6302 )
2018-05-22 15:37:15 +02:00
Aleksander Machniak
130b70e464
Use array() instead of []
2018-05-22 15:36:23 +02:00
Aleksander Machniak
8e543f843e
Fix check_request() bypass in places using get_uids() [CVE-2018-9846] ( #6238 )
2018-04-09 09:07:27 +02:00
Aleksander Machniak
a02fafa542
zipdownload: Added option to define size limit for multiple messages download ( #5696 )
...
Default limit set to 50MB.
2018-03-18 15:50:40 +01:00
Aleksander Machniak
9ce8948294
Get rid of the 2nd argument of include_stylesheet()
...
.. make the optional behavior default now.
2017-11-20 14:03:07 +01:00
Aleksander Machniak
830a50f1ce
Add (elastic-compatible) classes for zipdownload menu items
2017-08-06 19:47:26 +02:00
Aleksander Machniak
69f50b122d
Add a way to include plugin stylesheets optionally only if the file exists
2017-08-06 19:46:22 +02:00
Aleksander Machniak
86a4d78369
Merge branch 'dev-elastic'
2017-07-02 16:47:54 +02:00
Aleksander Machniak
bcc6405552
Fix various issues when downloading files with names containing non-ascii chars, use RFC 2231 ( #5772 )
2017-06-26 16:27:10 +02:00
Aleksander Machniak
f8537d0221
Code optimization, update changelog
2017-06-02 20:06:47 +02:00
Lucas Stevanelli Marin
c5da225179
Fix bug where zipdownload ignored files with the same name ( #5777 )
...
Adding a counter before .(extension) to files with same name on zip.
Before only the last file on message with equals names was added on zip
2017-06-02 20:00:44 +02:00
Aleksander Machniak
11f5560d35
Fix mail download menu
2017-03-09 14:57:22 +01:00
Aleksander Machniak
dfd19206a4
sizeof() -> count()
2017-02-06 13:49:29 +01:00
Aleksander Machniak
d45692131b
Zipdownload: Fix date format in mbox "From line"
2016-12-13 08:28:07 +01:00
Aleksander Machniak
689996896a
Fix bug where names of downloaded files could be mailformed when derived from the message subject ( #5404 )
2016-08-20 08:47:28 +02:00
Aleksander Machniak
9d4e5f5e49
Bump zipdownload plugin version number
2016-03-06 16:24:35 +01:00
Thomas Bruederli
4a408843b0
Protect download urls against CSRF using unique request tokens ( #1490642 )
...
Send X-Frame-Options headers with every HTTP response
2016-03-06 14:31:07 +01:00
Aleksander Machniak
9f1f754daf
CS fixes
2015-11-22 09:41:53 +01:00
Aleksander Machniak
bb2113ccdc
Fix zipped messages downloads after selecting all messages in a folder ( #1490339 )
2015-03-31 13:51:59 +02:00
Aleksander Machniak
48ba4414b3
Fix download of attachments that are part of TNEF message ( #1490091 )
...
Rcube_message_part::body content should never be modified by code out of the rcube_message.
Added convenient rcube_message::get_part_body() method, making rcube_message::get_part_content() deprecated.
2014-10-22 14:29:44 +02:00
Thomas Bruederli
b2992dd228
Further accessibility improvements regarding keyboard navigation and document structure
2014-05-07 17:34:28 +02:00
Aleksander Machniak
ed1ceea878
Add possibility to download messages in mbox format ( #1486069 )
...
Removed "download folder" option, the same can be done by selecting all messages in a folder
Code refactoring
2014-04-18 10:13:51 +02:00
