Commit Graph

41 Commits

Author SHA1 Message Date
Michael Voříšek
6a5f9ee7ce Add override method attributes (#9272) 2024-06-02 15:57:56 +02:00
Aleksander Machniak
49a40ea126 Code improvements 2024-03-23 13:48:51 +01:00
Michael Voříšek
d18406a8bd Fix binary operator spaces CS (#9330)
* align_single_space_minimal for assign

* assign operators grouping is not supported by PHP CS Fixer

* binary_operator_spaces = single_space

* fix anonymous function on single line

* align comments manually
2024-02-02 07:53:34 +01:00
Aleksander Machniak
a73a53c8ef Replace deprecated methods use 2024-01-27 09:58:01 +01:00
Michael Voříšek
4ee79b9e84 fix "explicit_string_variable" (#9315) 2024-01-22 08:05:59 +01:00
Michael Voříšek
6a53a1d853 Fix CS (whitespace, visibility) (#9297)
* Fix "method_argument_space"

* Fix "control_structure_continuation_position"

* Fix "new_with_parentheses"

* Fix "blank_line_before_statement"

* Fix "visibility_required"

* Fix some "array_indentation"

* Fix some "array_indentation" - unify all "rcube::raise_error" calls

* rm useless eslint ignores and add rules counts

* sort eslint ignores

* fix eslint ignores grammar

* Revert "Fix "blank_line_before_statement""

* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa Fix single quotes CS (#9283)
* Fix "single_quote"

* fix "escape_implicit_backslashes"

* fix typo from f363481c

* fix single quotes in JS

* fix some minor JS CS

* fix CS v3.45.0
2023-12-31 16:36:55 +01:00
Michael Voříšek
28c778b7a0 Modernize more CS III (#9270)
* fix "single_trait_insert_per_statement"

* fix "empty_loop_condition"

* fix "backtick_to_shell_exec"

* fix "phpdoc_to_comment"

* fix "no_empty_statement"

* fix "heredoc_to_nowdoc"

* fix "class_reference_name_casing"

* fix "align_multiline_comment"

* fix "heredoc_indentation"

* fix "constant_case"

* fix "single_line_comment_style"

* fix "no_null_property_initialization"

* fix "standardize_increment"

* fix "no_unneeded_control_parentheses"

* fix missing NL after "<?php"

* fix php in *.sh files too

* fix trailing spaces from all text files

* fix "explicit_indirect_variable"

* Revert "fix "align_multiline_comment""

This reverts commit 42e584f8e3.

* fix "align_multiline_comment" properly

* Revert "fix trailing spaces from all text files" - diff files only

* Revert "Revert "fix trailing spaces from all text files" - diff files only"

This reverts commit 2101c2a3a3.

* rm useless "setup-php" config
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146 Modernize more basic CS II (#9254)
* fix "integer_literal_case"

* fix "phpdoc_separation"

* fix "phpdoc_var_without_name"

* fix "operator_linebreak"

* fix "no_alias_language_construct_call"

* fix "list_syntax"

* fix "concat_space"

* fix "array_syntax"

* fix "binary_operator_spaces"

* fix "binary_operator_spaces" relaxed

* fix "phpdoc_types_order"

* fix "phpdoc_trim"

* fix "native_type_declaration_casing"

* fix "method_chaining_indentation"

* fix "phpdoc_no_package"

* fix "elseif"

* fix PHP CS Fixer config itself too

* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
a8707ae220 Fix and assert basic CS using CI (#9246)
* Assert CS using CI

* fix "single_blank_line_at_eof"

* fix "statement_indentation"

* fix "switch_case_semicolon_to_colon"

* fix "control_structure_braces"

* fix "statement_indentation"

* fix "no_whitespace_in_blank_line"

* fix "no_trailing_whitespace_in_comment"

* fix "no_trailing_whitespace"

* fix "single_space_around_construct"

* fix "spaces_inside_parentheses"

* fix "ternary_operator_spaces"

* fix "trim_array_spaces"

* fix "whitespace_after_comma_in_array"

* fix "cast_spaces"

* fix "unary_operator_spaces"

* fix "no_trailing_comma_in_singleline"

* fix "ordered_imports"

* fix "no_unused_imports"

* Check composer.json format

* fix CI job name

* file header comments are not phpdoc

* fix "phpdoc_indent"

* fix "braces_position"

* fix "phpdoc_types"

* fix "no_blank_lines_after_class_opening"

* fix "no_multiple_statements_per_line"

* fix "multiline_comment_opening_closing"

* fix "single_line_empty_body"

* fix "non_printable_character"

* fix "phpdoc_trim_consecutive_blank_line_separation"

* fix "include"

* fix "no_mixed_echo_print"

---------

Co-authored-by: Aleksander Machniak <alec@alec.pl>
2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a Fix invalid phpdocs (#9252)
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Aleksander Machniak
80404a8674 Store uploads metadata in a separate sql database table instead of a session (#8415) 2022-10-09 11:35:14 +02:00
Aleksander Machniak
ba1a93ec5b Fix PHP8 warnings 2022-07-09 18:29:07 +02:00
Aleksander Machniak
aa772c6270 Remove redundant Classic-specific code 2021-11-14 11:36:29 +01:00
Aleksander Machniak
7a269a2b84 Replace get_input_value() with get_input_string() where appropriate 2021-09-13 19:31:49 +02:00
Aleksander Machniak
9e735cb544 Vcard_attachments: Improve handling of multiple contacts (#7027) 2021-05-16 11:04:35 +02:00
Aleksander Machniak
3bbb01fe13 PHP8 fixes, regression fixes 2020-12-13 12:14:15 +01:00
Aleksander Machniak
ed146b68db PHP8 fixes, CS fixes, short array syntax, tests 2020-12-10 20:27:32 +01:00
Aleksander Machniak
545a1569f1 Steps -> Actions refactoring (#7688)
* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes
2020-11-01 11:25:38 +01:00
Aleksander Machniak
9713ce364c Automatically collected recipients and trusted senders (#6904)
Added configurable Collected Recipients addressbook source (#4971)
Added configurable Trusted Senders addressbook source (#5046)
Added 'contact_exists' hook
2020-09-20 10:00:08 +02:00
Aleksander Machniak
eb7636d491 Fixes in context of undefined variables, and code style 2020-08-16 10:29:42 +02:00
Aleksander Machniak
cf7e4f12b2 Stop adding some localization to ajax responses 2018-10-18 10:40:09 +00:00
PhilW
d5071fedba vcard_attachments: add link to contact actions menu
*) add 'forward vcard' link to contact actions manu
*) fix bug when a contact with a secondary email address is selected
*) improve support for multiple address books in contact list widget on compose screen
2018-01-11 11:59:43 +00:00
Aleksander Machniak
12a2e47b9b Improve vcardattachments addon in Elastic 2018-01-03 16:50:40 +01:00
Aleksander Machniak
9ce8948294 Get rid of the 2nd argument of include_stylesheet()
.. make the optional behavior default now.
2017-11-20 14:03:07 +01:00
Aleksander Machniak
4ade7acdac Elastic skin support for vcard_attachments plugin (with some refactorings) 2017-09-19 14:08:57 +02:00
Aleksander Machniak
a487055c5a Add possibility to attach contact vCard to composed message (#4997) 2016-12-16 16:02:20 +01:00
Aleksander Machniak
391d0d2039 Remove "@version @package_version@" 2016-11-01 18:26:47 +01:00
Aleksander Machniak
aa2486beb3 vcard_attachments: Fix bug where national characters in vCard would be broken on import/display 2016-03-25 11:41:08 +01:00
Aleksander Machniak
48ba4414b3 Fix download of attachments that are part of TNEF message (#1490091)
Rcube_message_part::body content should never be modified by code out of the rcube_message.
Added convenient rcube_message::get_part_body() method, making rcube_message::get_part_content() deprecated.
2014-10-22 14:29:44 +02:00
Aleksander Machniak
2193f6a130 Avoid unused local variables 2013-05-07 13:51:23 +02:00
Aleksander Machniak
61be822d62 Remove deprecated functions (from bc.php file) usage in plugins 2013-01-18 15:24:49 +01:00
Aleksander Machniak
e27a61a50d Skip invalid vCards (#1488788) 2012-11-18 12:58:49 +01:00
Sylvestre Ledru
654ac1e090 Fix some typos 2012-08-08 08:37:55 +02:00
alecpl
0d5240e15d - Import contacts to default addressbook 2012-04-13 10:46:51 +00:00
alecpl
3c32f32025 - Fixed doble urlencoding of vcard identifier
- Fixed encoding when default charset is different than vcard charset
- Improved vcards import to work as addressbook::import procedure (with validation and autofix)
2012-04-13 10:08:51 +00:00
thomascube
48e9c14ebd Move plugins repository into roundcubemail root folder; svn:externals are not defined anymore 2012-03-31 12:25:48 +00:00
till
63a3dc5fde moved plugins 2010-03-20 14:20:01 +00:00
thomascube
dba307ffd9 Localize vcard_attachments plugin + add Russian translation for archive plugin 2009-10-28 16:16:09 +00:00
thomascube
c7a2e84a24 Fix vcard_attachments plugin (#1486035) 2009-08-07 16:11:29 +00:00
thomascube
cc97ea0559 Merged branch devel-api (from r2208 to r2387) back into trunk (omitting some sample plugins) 2009-04-19 17:44:29 +00:00