Commit Graph

30 Commits

Author SHA1 Message Date
Michael Voříšek
6a5f9ee7ce Add override method attributes (#9272) 2024-06-02 15:57:56 +02:00
Aleksander Machniak
49a40ea126 Code improvements 2024-03-23 13:48:51 +01:00
Michael Voříšek
d18406a8bd Fix binary operator spaces CS (#9330)
* align_single_space_minimal for assign

* assign operators grouping is not supported by PHP CS Fixer

* binary_operator_spaces = single_space

* fix anonymous function on single line

* align comments manually
2024-02-02 07:53:34 +01:00
Michael Voříšek
6a53a1d853 Fix CS (whitespace, visibility) (#9297)
* Fix "method_argument_space"

* Fix "control_structure_continuation_position"

* Fix "new_with_parentheses"

* Fix "blank_line_before_statement"

* Fix "visibility_required"

* Fix some "array_indentation"

* Fix some "array_indentation" - unify all "rcube::raise_error" calls

* rm useless eslint ignores and add rules counts

* sort eslint ignores

* fix eslint ignores grammar

* Revert "Fix "blank_line_before_statement""

* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa Fix single quotes CS (#9283)
* Fix "single_quote"

* fix "escape_implicit_backslashes"

* fix typo from f363481c

* fix single quotes in JS

* fix some minor JS CS

* fix CS v3.45.0
2023-12-31 16:36:55 +01:00
Michael Voříšek
3e458fa5fd Refer native constants unambiguously (#9275)
* Fix "native_constant_invocation" CS

* "self_accessor" was fixed in 9269 PR

* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
28c778b7a0 Modernize more CS III (#9270)
* fix "single_trait_insert_per_statement"

* fix "empty_loop_condition"

* fix "backtick_to_shell_exec"

* fix "phpdoc_to_comment"

* fix "no_empty_statement"

* fix "heredoc_to_nowdoc"

* fix "class_reference_name_casing"

* fix "align_multiline_comment"

* fix "heredoc_indentation"

* fix "constant_case"

* fix "single_line_comment_style"

* fix "no_null_property_initialization"

* fix "standardize_increment"

* fix "no_unneeded_control_parentheses"

* fix missing NL after "<?php"

* fix php in *.sh files too

* fix trailing spaces from all text files

* fix "explicit_indirect_variable"

* Revert "fix "align_multiline_comment""

This reverts commit 42e584f8e3.

* fix "align_multiline_comment" properly

* Revert "fix trailing spaces from all text files" - diff files only

* Revert "Revert "fix trailing spaces from all text files" - diff files only"

This reverts commit 2101c2a3a3.

* rm useless "setup-php" config
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146 Modernize more basic CS II (#9254)
* fix "integer_literal_case"

* fix "phpdoc_separation"

* fix "phpdoc_var_without_name"

* fix "operator_linebreak"

* fix "no_alias_language_construct_call"

* fix "list_syntax"

* fix "concat_space"

* fix "array_syntax"

* fix "binary_operator_spaces"

* fix "binary_operator_spaces" relaxed

* fix "phpdoc_types_order"

* fix "phpdoc_trim"

* fix "native_type_declaration_casing"

* fix "method_chaining_indentation"

* fix "phpdoc_no_package"

* fix "elseif"

* fix PHP CS Fixer config itself too

* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
a8707ae220 Fix and assert basic CS using CI (#9246)
* Assert CS using CI

* fix "single_blank_line_at_eof"

* fix "statement_indentation"

* fix "switch_case_semicolon_to_colon"

* fix "control_structure_braces"

* fix "statement_indentation"

* fix "no_whitespace_in_blank_line"

* fix "no_trailing_whitespace_in_comment"

* fix "no_trailing_whitespace"

* fix "single_space_around_construct"

* fix "spaces_inside_parentheses"

* fix "ternary_operator_spaces"

* fix "trim_array_spaces"

* fix "whitespace_after_comma_in_array"

* fix "cast_spaces"

* fix "unary_operator_spaces"

* fix "no_trailing_comma_in_singleline"

* fix "ordered_imports"

* fix "no_unused_imports"

* Check composer.json format

* fix CI job name

* file header comments are not phpdoc

* fix "phpdoc_indent"

* fix "braces_position"

* fix "phpdoc_types"

* fix "no_blank_lines_after_class_opening"

* fix "no_multiple_statements_per_line"

* fix "multiline_comment_opening_closing"

* fix "single_line_empty_body"

* fix "non_printable_character"

* fix "phpdoc_trim_consecutive_blank_line_separation"

* fix "include"

* fix "no_mixed_echo_print"

---------

Co-authored-by: Aleksander Machniak <alec@alec.pl>
2023-12-16 15:37:43 +01:00
Aleksander Machniak
1389e573d3 Remove use of utf8_encode() and utf8_decode() functions deprecated in PHP 8.2 2022-08-06 18:58:23 +02:00
Aleksander Machniak
ed146b68db PHP8 fixes, CS fixes, short array syntax, tests 2020-12-10 20:27:32 +01:00
dchisolm
b0f7e4207c Parse abook entries more reliably (#6646)
* Update the squirrelmail_user_copy plugin to use the same method of parsing abook entries
as squirrelmail uses. If a user has entered something that has been quoted such as double quotes or pipes, this will parse the address book entry better than exploding on the pipe alone
* Noticed undefined variable $sig in convert charset
2019-03-04 12:08:33 +01:00
Aleksander Machniak
d51fdaa2ee Replace last occurrence of RCMAIL_CHARSET with RCUBE_CHARSET 2018-04-09 18:18:24 +02:00
ka7
9a35768c26 spelling fixes (#5690) 2017-03-12 12:14:19 +01:00
Aleksander Machniak
81f67a4de2 Don't use each() deprecated in PHP 7.2 2017-02-06 15:46:18 +01:00
Aleksander Machniak
18842dd14e Fix code style after PR merge 2016-08-12 13:24:24 +02:00
Hideki Sakamoto
8bc134c284 Convert charset wieh file based backend. 2016-08-10 14:37:30 +09:00
Aleksander Machniak
86e97e8d50 Create groups for multi-address contacts (#1487858) 2015-05-23 17:36:19 +02:00
Aleksander Machniak
09c2520e20 CS fixes 2015-05-23 17:00:30 +02:00
Aleksander Machniak
34a0902089 Use consistent column/table quoting in sql queries 2014-09-12 14:37:51 +02:00
Aleksander Machniak
2193f6a130 Avoid unused local variables 2013-05-07 13:51:23 +02:00
Aleksander Machniak
61be822d62 Remove deprecated functions (from bc.php file) usage in plugins 2013-01-18 15:24:49 +01:00
Alex_Go
2884303903 fixed sq_usercopy to correctly copy SQ-label to RC-notes. 2012-12-09 13:15:40 +01:00
Aleksander Machniak
91f2271fac Replace rcube_mdb2 with rcube_db 2012-06-19 12:00:07 +02:00
thomascube
48e9c14ebd Move plugins repository into roundcubemail root folder; svn:externals are not defined anymore 2012-03-31 12:25:48 +00:00
till
63a3dc5fde moved plugins 2010-03-20 14:20:01 +00:00
alecpl
333c48caf7 - Squirrelmail_usercopy: support reply-to field (#1486506)
- Use rcube_user::insert_identity() instead of custom SQL query in rcube_user::create()
2010-02-23 18:31:23 +00:00
alecpl
9b94eb6415 - Fix setting task name according to auth state. So, any action before user
is authenticated is assigned to 'login' task instead of 'mail'. Now binding
  plugins to 'login' task is possible and realy usefull. It's also possible 
  to bind to all tasks excluding 'login'.
2010-02-06 18:12:49 +00:00
thomascube
5edb5b6634 Create plugin to present identities settings dialog to new users 2009-07-09 08:18:35 +00:00
thomascube
2a4abc1286 Plugin to copy user prefs from a Qquirrelmail installation (when a new user is registered) 2009-07-02 08:40:56 +00:00