Mirrors/roundcubemail
2
0
Fork 0
mirror of https://github.com/roundcube/roundcubemail.git synced 2026-02-28 21:34:02 +01:00
Code Issues Packages Projects Releases Wiki Activity
13,344 Commits 72 Branches 205 Tags
editorconfig-javascript
Commit Graph

36 Commits

Author SHA1 Message Date
Philip Weir
ccede1f272 Update links in comments and config to https where available (#9759) 2025-01-26 13:34:57 +01:00
Aleksander Machniak
99629db49b ldap_modify() is an alias of ldap_mod_replace() 2024-09-07 09:12:44 +02:00
Aleksander Machniak
8b11a9843e Cleanup raise_error() use in password drivers 2024-05-16 19:29:08 +02:00
Michael Voříšek
a30e0ad438 Infer file/line location in rcube::raise_error() from backtrace (#9422) 
* \n\s+'file' => __FILE__,

* \n\s+'line' => __LINE__,

* 'line' => __LINE__, 'file' => __FILE__,

* 'file' => __FILE__, 'line' => __LINE__,

* rest

* more

* improve cs

* more cs

* revert rcube_utils::preg_error changes

* impl file/line from backtrace

* Revert "revert rcube_utils::preg_error changes"
 2024-04-21 11:48:35 +02:00
Aleksander Machniak
e1925c47a4 Code improvements 2024-04-07 11:27:01 +02:00
Aleksander Machniak
a1f39f47b7 Fix phpstan errors 2024-02-10 19:20:04 +01:00
Michael Voříšek
d18406a8bd Fix binary operator spaces CS (#9330) 
* align_single_space_minimal for assign

* assign operators grouping is not supported by PHP CS Fixer

* binary_operator_spaces = single_space

* fix anonymous function on single line

* align comments manually
 2024-02-02 07:53:34 +01:00
Michael Voříšek
4ee79b9e84 fix "explicit_string_variable" (#9315) 2024-01-22 08:05:59 +01:00
Michael Voříšek
b1a0067e5d Fix more CS (#9303) 
* fix "class_attributes_separation"

* fix "ternary_to_null_coalescing"

* fix "no_extra_blank_lines"

* fix "php_unit_data_provider_name" - use snake_case

* fix remaining "function data_" manually

* move "php_unit_test_case_static_method_calls" to a better place in cnf

* fix 3.47.1 CS
 2024-01-20 08:22:32 +01:00
Michael Voříšek
6a53a1d853 Fix CS (whitespace, visibility) (#9297) 
* Fix "method_argument_space"

* Fix "control_structure_continuation_position"

* Fix "new_with_parentheses"

* Fix "blank_line_before_statement"

* Fix "visibility_required"

* Fix some "array_indentation"

* Fix some "array_indentation" - unify all "rcube::raise_error" calls

* rm useless eslint ignores and add rules counts

* sort eslint ignores

* fix eslint ignores grammar

* Revert "Fix "blank_line_before_statement""

* fix CS 3.46.0
 2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa Fix single quotes CS (#9283) 
* Fix "single_quote"

* fix "escape_implicit_backslashes"

* fix typo from f363481c

* fix single quotes in JS

* fix some minor JS CS

* fix CS v3.45.0
 2023-12-31 16:36:55 +01:00
Michael Voříšek
3e458fa5fd Refer native constants unambiguously (#9275) 
* Fix "native_constant_invocation" CS

* "self_accessor" was fixed in 9269 PR

* "php_unit_strict" was fixed in 9268 PR
 2023-12-23 17:02:19 +01:00
Michael Voříšek
e7d7e62146 Modernize more basic CS II (#9254) 
* fix "integer_literal_case"

* fix "phpdoc_separation"

* fix "phpdoc_var_without_name"

* fix "operator_linebreak"

* fix "no_alias_language_construct_call"

* fix "list_syntax"

* fix "concat_space"

* fix "array_syntax"

* fix "binary_operator_spaces"

* fix "binary_operator_spaces" relaxed

* fix "phpdoc_types_order"

* fix "phpdoc_trim"

* fix "native_type_declaration_casing"

* fix "method_chaining_indentation"

* fix "phpdoc_no_package"

* fix "elseif"

* fix PHP CS Fixer config itself too

* fix "native_type_declaration_casing"
 2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191 Modernize more basic CS (#9258) 
* fix "yoda_style"

* fix "is_null"

* rm useless rule ignores

* add full "PhpCsFixer:risky" ruleset

* fix "implode_call"

* fix "no_alias_functions"

* fix "array_push"

* fix "long_to_shorthand_operator"

* fix "ternary_to_elvis_operator"

* fix "logical_operators"

* fix "fopen_flags"

* rename "returns" phpdoc tags to "return"

* fix "php_unit_construct"

* fix "function_to_constant"

* fix "php_unit_data_provider_return_type"

* fix "php_unit_set_up_tear_down_visibility"

* some safe "string_length_to_empty"

* fix "phpdoc_align"

* fix "phpdoc_no_alias_tag"

* fix "trailing_comma_in_multiline"

---------

Co-authored-by: Aleksander Machniak <alec@alec.pl>
 2023-12-17 09:51:11 +01:00
Michael Voříšek
a8707ae220 Fix and assert basic CS using CI (#9246) 
* Assert CS using CI

* fix "single_blank_line_at_eof"

* fix "statement_indentation"

* fix "switch_case_semicolon_to_colon"

* fix "control_structure_braces"

* fix "statement_indentation"

* fix "no_whitespace_in_blank_line"

* fix "no_trailing_whitespace_in_comment"

* fix "no_trailing_whitespace"

* fix "single_space_around_construct"

* fix "spaces_inside_parentheses"

* fix "ternary_operator_spaces"

* fix "trim_array_spaces"

* fix "whitespace_after_comma_in_array"

* fix "cast_spaces"

* fix "unary_operator_spaces"

* fix "no_trailing_comma_in_singleline"

* fix "ordered_imports"

* fix "no_unused_imports"

* Check composer.json format

* fix CI job name

* file header comments are not phpdoc

* fix "phpdoc_indent"

* fix "braces_position"

* fix "phpdoc_types"

* fix "no_blank_lines_after_class_opening"

* fix "no_multiple_statements_per_line"

* fix "multiline_comment_opening_closing"

* fix "single_line_empty_body"

* fix "non_printable_character"

* fix "phpdoc_trim_consecutive_blank_line_separation"

* fix "include"

* fix "no_mixed_echo_print"

---------

Co-authored-by: Aleksander Machniak <alec@alec.pl>
 2023-12-16 15:37:43 +01:00
Aleksander Machniak
a815867bca Fix deprecated use of ldap_connect() in password's ldap_simple driver (#9060) 2023-08-20 08:56:30 +02:00
Matwey V. Kornilov
7d13b337db Some minor improvements for password plugin (#8402) 
* plugins/password/ldap_simple: Allow LDAP access using LDAP URI

Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>

* plugins/password/ldap_simple: Allow LDAP SASL binding when search user DN

This may be particularly useful when UNIX socket connection is used,
or TLS certificate-based authentication is performed.

Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>

* plugins/password/ldap_simple: Allow LDAP SASL bind for admin

Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>

---------

Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
 2023-05-28 10:38:02 +02:00
Aleksander Machniak
53801e5fdc Password: Remove some deprecated algorithms and replacement variables 2021-09-25 15:33:20 +02:00
Aleksander Machniak
14a94cf0d7 PHP8 fixes, CS fixes, short array syntax, tests 2020-12-09 21:11:46 +01:00
Aleksander Machniak
66fab8cdb2 CS fixes, Avoid usused variables, fixed minor bugs 2019-10-05 19:44:39 +02:00
Aleksander Machniak
57c67db029 Remove year(s) from copyright headers + some cleanup 2019-04-16 10:42:45 +02:00
Peter Kubica
b2ffe58f9d Fix for: Password: De-duplicate ldap drivers code (#6669) 2019-03-11 10:00:04 +01:00
Aleksander Machniak
0751c1c8eb Password: De-duplicate ldap drivers code 2019-03-09 18:24:01 +01:00
Torkel Bjørnson-Langen
278b46a99d password plugin: better error message on constraint violation (#5727) 
If the password policy on the ldap server is violated when changing
password, report error as "constraint violation" instead of the
misleading "connection error".

Only tested with OpenLDAP (v2.4).
 2017-04-21 10:39:49 +02:00
Torkel Bjørnson-Langen
3bbe218b83 Password plugin: Added missing default values (#5726) 
* Added correct default values for password plugin (ldap backends only)
* Sync default values in config.inc.php.dist with code.
 2017-04-18 10:17:18 +02:00
Aleksander Machniak
3cc6ec573d Make password encryption algorithms available for all drivers (#1490134) 
...via password::hash_password() method and password_algorithm option.
Add %P and %O macros for password_query in favor of %c, %d, %n and %q.
 2015-05-27 13:37:10 +02:00
Aleksander Machniak
4baf96a4ca Added license headers to driver files, CS fixes 2014-09-08 09:50:59 +02:00
Aleksander Machniak
7706df99f0 Allow anonymous LDAP searches 2014-06-24 12:03:17 +02:00
Thomas Bruederli
774deaded1 Don't EVER log passwords 2014-02-03 15:34:55 +01:00
Aleksander Machniak
393c868e8e Substitute variables in 'password_ldap_search_base' value 2013-11-08 08:19:11 +01:00
Aleksander Machniak
99de1fdd26 In password ldap_simple driver: added LDAP debug, added password_ldap_bind 
hook, so other plugins can provide user DN for password change
 2013-09-27 13:12:17 +02:00
Aleksander Machniak
19884ec5d2 Code improvements, remove code duplication 2013-09-23 12:53:58 +02:00
Aleksander Machniak
6776d31cee Add new password encodage ('ad') in ldap password drivers (#1489349) 2013-09-23 12:40:25 +02:00
Aleksander Machniak
61be822d62 Remove deprecated functions (from bc.php file) usage in plugins 2013-01-18 15:24:49 +01:00
Aleksander Machniak
d6938bd1ea CS fixes, mostly tabs to spaces conversion 2012-12-17 14:38:59 +01:00
thomascube
48e9c14ebd Move plugins repository into roundcubemail root folder; svn:externals are not defined anymore 2012-03-31 12:25:48 +00:00