Commit Graph

18 Commits

Author SHA1 Message Date
Philip Weir
ccede1f272 Update links in comments and config to https where available (#9759) 2025-01-26 13:34:57 +01:00
Aleksander Machniak
8b11a9843e Cleanup raise_error() use in password drivers 2024-05-16 19:29:08 +02:00
Michael Voříšek
a30e0ad438 Infer file/line location in rcube::raise_error() from backtrace (#9422)
* \n\s+'file' => __FILE__,

* \n\s+'line' => __LINE__,

* 'line' => __LINE__, 'file' => __FILE__,

* 'file' => __FILE__, 'line' => __LINE__,

* rest

* more

* improve cs

* more cs

* revert rcube_utils::preg_error changes

* impl file/line from backtrace

* Revert "revert rcube_utils::preg_error changes"
2024-04-21 11:48:35 +02:00
Aleksander Machniak
e1925c47a4 Code improvements 2024-04-07 11:27:01 +02:00
Michael Voříšek
d18406a8bd Fix binary operator spaces CS (#9330)
* align_single_space_minimal for assign

* assign operators grouping is not supported by PHP CS Fixer

* binary_operator_spaces = single_space

* fix anonymous function on single line

* align comments manually
2024-02-02 07:53:34 +01:00
Michael Voříšek
4ee79b9e84 fix "explicit_string_variable" (#9315) 2024-01-22 08:05:59 +01:00
Michael Voříšek
6a53a1d853 Fix CS (whitespace, visibility) (#9297)
* Fix "method_argument_space"

* Fix "control_structure_continuation_position"

* Fix "new_with_parentheses"

* Fix "blank_line_before_statement"

* Fix "visibility_required"

* Fix some "array_indentation"

* Fix some "array_indentation" - unify all "rcube::raise_error" calls

* rm useless eslint ignores and add rules counts

* sort eslint ignores

* fix eslint ignores grammar

* Revert "Fix "blank_line_before_statement""

* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
3e458fa5fd Refer native constants unambiguously (#9275)
* Fix "native_constant_invocation" CS

* "self_accessor" was fixed in 9269 PR

* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
ca8b17d191 Modernize more basic CS (#9258)
* fix "yoda_style"

* fix "is_null"

* rm useless rule ignores

* add full "PhpCsFixer:risky" ruleset

* fix "implode_call"

* fix "no_alias_functions"

* fix "array_push"

* fix "long_to_shorthand_operator"

* fix "ternary_to_elvis_operator"

* fix "logical_operators"

* fix "fopen_flags"

* rename "returns" phpdoc tags to "return"

* fix "php_unit_construct"

* fix "function_to_constant"

* fix "php_unit_data_provider_return_type"

* fix "php_unit_set_up_tear_down_visibility"

* some safe "string_length_to_empty"

* fix "phpdoc_align"

* fix "phpdoc_no_alias_tag"

* fix "trailing_comma_in_multiline"

---------

Co-authored-by: Aleksander Machniak <alec@alec.pl>
2023-12-17 09:51:11 +01:00
Aleksander Machniak
44a4496302 Cleaner code 2023-05-29 08:00:31 +02:00
Aleksander Machniak
3188679bdd Return early if hashing of password fails 2023-05-28 15:14:42 +02:00
Aleksander Machniak
d69613c4e4 Always throw an error when password hashing fails (#8145) 2021-08-01 10:39:56 +02:00
Robin Friberg
e4d7b9baff Fix dovecot passwdfile change (#8145)
* Fix dovecot passwd-file handler
* Set new password hash correctly
* If password hashing failes during password change request, abort trying to change the password.
* Escaping hashed password is not needed and actually breaks if 'password_dovecotpw_with_method' is set to true (escaping the {METHOD} in the passwd file)
2021-08-01 10:35:30 +02:00
Josh Soref
203f456620 Spelling (#8001) 2021-04-18 08:43:18 +02:00
Aleksander Machniak
a47cdb4b80 dovecot_passwdfile: Simplify and add file locking 2021-01-16 16:14:20 +01:00
Aleksander Machniak
ca523bd7fa Remove hostnet.de specific code 2021-01-16 15:42:58 +01:00
Jimmy Koerting
2409b568b3 changed line in description 2021-01-16 15:22:19 +01:00
Jimmy Koerting
b0560bffd1 renamed hostnet.php into dovecot_passwdfile.php
renamed the driver, removed hostnet specific config option and changed the code to be easily adopted for vanilla dovecot 2 passwd-file environments.
2021-01-16 15:22:19 +01:00