Aleksander Machniak
5fed86f57e
Cleanup
2025-02-23 11:22:35 +01:00
Philip Weir
ccede1f272
Update links in comments and config to https where available ( #9759 )
2025-01-26 13:34:57 +01:00
Aleksander Machniak
99629db49b
ldap_modify() is an alias of ldap_mod_replace()
2024-09-07 09:12:44 +02:00
Aleksander Machniak
93cb57b021
Fix driver description again
...
[skip ci]
2024-09-07 09:11:39 +02:00
Aleksander Machniak
f26ed17307
Fix driver description
2024-09-07 09:04:44 +02:00
Aleksander Machniak
89d429dbee
Fix two new phpstan issues
2024-08-02 09:12:48 +02:00
Michael Voříšek
6a5f9ee7ce
Add override method attributes ( #9272 )
2024-06-02 15:57:56 +02:00
Aleksander Machniak
8b11a9843e
Cleanup raise_error() use in password drivers
2024-05-16 19:29:08 +02:00
Aleksander Machniak
3d31036aad
Password: Use Guzzle HTTP Client in the cpanel driver
2024-04-21 20:19:09 +02:00
Aleksander Machniak
ad25c6f7ce
Password: Use Guzzle HTTP Client in the domainfactory driver
2024-04-21 16:58:53 +02:00
Aleksander Machniak
543dde3c04
Password: Use Guzzle HTTP Client in the modoboa driver
2024-04-21 15:26:37 +02:00
Aleksander Machniak
8b024bffd3
Password: Use Guzzle HTTP Client in the plesk driver
2024-04-21 15:06:39 +02:00
Aleksander Machniak
24435fed26
Password: Use Guzzle HTTP Client in 'directadmin' driver
2024-04-21 12:56:55 +02:00
Michael Voříšek
a30e0ad438
Infer file/line location in rcube::raise_error() from backtrace ( #9422 )
...
* \n\s+'file' => __FILE__,
* \n\s+'line' => __LINE__,
* 'line' => __LINE__, 'file' => __FILE__,
* 'file' => __FILE__, 'line' => __LINE__,
* rest
* more
* improve cs
* more cs
* revert rcube_utils::preg_error changes
* impl file/line from backtrace
* Revert "revert rcube_utils::preg_error changes"
2024-04-21 11:48:35 +02:00
Aleksander Machniak
7839820d25
Password: Check that a user email is part of password in zxcvbn checker ( #9404 )
2024-04-14 11:07:08 +02:00
Aleksander Machniak
15659d7815
PHPCS: phpdoc_annotation_without_dot=true (default)
2024-04-14 10:32:35 +02:00
Michael Voříšek
1e360999b2
Use composer autoloader for bundled plugins testing ( #9412 )
...
* use fixed "roundcube/plugin-installer"
* Use composer autoloader for plugins testing
* cherrypick remaining from 9241 related with testing
* minor legacy autoload improvements
2024-04-11 18:28:46 +02:00
Aleksander Machniak
2334876063
Password: Use Guzzle HTTP Client in 'pwned' driver
2024-04-07 11:59:13 +02:00
Aleksander Machniak
e1925c47a4
Code improvements
2024-04-07 11:27:01 +02:00
Aleksander Machniak
a1f39f47b7
Fix phpstan errors
2024-02-10 19:20:04 +01:00
Aleksander Machniak
966274d835
Fix phpstan errors
2024-02-09 21:11:50 +01:00
Michael Voříšek
d18406a8bd
Fix binary operator spaces CS ( #9330 )
...
* align_single_space_minimal for assign
* assign operators grouping is not supported by PHP CS Fixer
* binary_operator_spaces = single_space
* fix anonymous function on single line
* align comments manually
2024-02-02 07:53:34 +01:00
Michael Voříšek
ff2d721680
Fix more CS whitespace ( #9318 )
...
* fix "no_useless_else" manually
* fix some "blank_line_before_statement"
* two manual changes
* Revert "fix some "blank_line_before_statement""
This reverts commit 2cc857c00e
2024-01-25 19:17:29 +01:00
Michael Voříšek
4ee79b9e84
fix "explicit_string_variable" ( #9315 )
2024-01-22 08:05:59 +01:00
Michael Voříšek
54f4aa33f9
Fix CS - imports ( #9316 )
...
* fix Tests\Browser\TestCase imports
* fix remaining imports
* fix PHPUnit\Framework\TestCase imports
* import GuzzleHttp\Client
* fix remaining
* "php_unit_method_casing" is not todo
* fix "single_line_comment_spacing"
* fix 2nd commit done using older fixer
2024-01-21 19:13:31 +01:00
Michael Voříšek
b1a0067e5d
Fix more CS ( #9303 )
...
* fix "class_attributes_separation"
* fix "ternary_to_null_coalescing"
* fix "no_extra_blank_lines"
* fix "php_unit_data_provider_name" - use snake_case
* fix remaining "function data_" manually
* move "php_unit_test_case_static_method_calls" to a better place in cnf
* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Michael Voříšek
a797873ef5
Fix "phpdoc_no_empty_return" CS ( #9302 )
...
* replace void with never return type
* replace "return void" phpdoc with native type in tests
* replace "return void" phpdoc with native type in rcube_addressbook
* replace "return void" phpdoc with native type in rcmail_oauth
* fix remaining
2024-01-05 19:03:58 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
b5637067eb
Bound upper PHP version in composer.json ( #9298 )
...
* bound upper PHP version
* improve/replace all relative includes
2024-01-02 13:33:50 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2023-12-31 16:36:55 +01:00
Michael Voříšek
3e458fa5fd
Refer native constants unambiguously ( #9275 )
...
* Fix "native_constant_invocation" CS
* "self_accessor" was fixed in 9269 PR
* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
28c778b7a0
Modernize more CS III ( #9270 )
...
* fix "single_trait_insert_per_statement"
* fix "empty_loop_condition"
* fix "backtick_to_shell_exec"
* fix "phpdoc_to_comment"
* fix "no_empty_statement"
* fix "heredoc_to_nowdoc"
* fix "class_reference_name_casing"
* fix "align_multiline_comment"
* fix "heredoc_indentation"
* fix "constant_case"
* fix "single_line_comment_style"
* fix "no_null_property_initialization"
* fix "standardize_increment"
* fix "no_unneeded_control_parentheses"
* fix missing NL after "<?php"
* fix php in *.sh files too
* fix trailing spaces from all text files
* fix "explicit_indirect_variable"
* Revert "fix "align_multiline_comment""
This reverts commit 42e584f8e32101c2a3a3
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a
Fix invalid phpdocs ( #9252 )
...
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Aleksander Machniak
a815867bca
Fix deprecated use of ldap_connect() in password's ldap_simple driver ( #9060 )
2023-08-20 08:56:30 +02:00
Aleksander Machniak
44a4496302
Cleaner code
2023-05-29 08:00:31 +02:00
Aleksander Machniak
3188679bdd
Return early if hashing of password fails
2023-05-28 15:14:42 +02:00
Matwey V. Kornilov
7d13b337db
Some minor improvements for password plugin ( #8402 )
...
* plugins/password/ldap_simple: Allow LDAP access using LDAP URI
Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru >
* plugins/password/ldap_simple: Allow LDAP SASL binding when search user DN
This may be particularly useful when UNIX socket connection is used,
or TLS certificate-based authentication is performed.
Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru >
* plugins/password/ldap_simple: Allow LDAP SASL bind for admin
Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru >
---------
Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru >
2023-05-28 10:38:02 +02:00
Aleksander Machniak
66f6169774
Update changelog for ( #8525 ), CS fixes
2022-08-15 10:22:16 +02:00
jbweb
f8817bf8cf
Samba AD password driver ( #8525 )
...
* SAMBA Active Directory password driver
Co-authored-by: Jonas Holm Bundgaard <root@mail1.jbweb.dk >
2022-08-15 10:14:13 +02:00
Aleksander Machniak
1389e573d3
Remove use of utf8_encode() and utf8_decode() functions deprecated in PHP 8.2
2022-08-06 18:58:23 +02:00
Aleksander Machniak
3cfbae2d2a
Password: Remove references to %c variable that has been removed before ( #8633 )
2022-07-30 08:37:35 +02:00
Aleksander Machniak
f8301a44b4
Support schema prefix in password_mailcow_api_host ( #8291 )
2022-06-19 10:59:18 +02:00
Aleksander Machniak
a2560eb7ff
Use "{$var}" instead of "${var}" syntax
2022-03-12 12:42:36 +01:00
Przemek
59928e3341
Fix password change for Directadmin driver ( #8329 )
...
Co-authored-by: Przemysław Kucaj <p.kucaj@serveradmin.pl >
2021-12-04 09:06:34 +01:00
Aleksander Machniak
e294b93d36
Update changelog and CS fixes
2021-11-06 09:18:57 +01:00
Lukáš Matula
4c347f0e24
Mailcow driver for password plugin ( #8291 )
2021-11-06 09:15:37 +01:00
Aleksander Machniak
87c706c146
Password: Improve handling errors on executed commands ( #8200 )
2021-09-29 19:21:26 +02:00
