Commit Graph

39 Commits

Author SHA1 Message Date
Michael Voříšek
6a5f9ee7ce Add override method attributes (#9272) 2024-06-02 15:57:56 +02:00
Michael Voříšek
a30e0ad438 Infer file/line location in rcube::raise_error() from backtrace (#9422)
* \n\s+'file' => __FILE__,

* \n\s+'line' => __LINE__,

* 'line' => __LINE__, 'file' => __FILE__,

* 'file' => __FILE__, 'line' => __LINE__,

* rest

* more

* improve cs

* more cs

* revert rcube_utils::preg_error changes

* impl file/line from backtrace

* Revert "revert rcube_utils::preg_error changes"
2024-04-21 11:48:35 +02:00
Aleksander Machniak
a1f39f47b7 Fix phpstan errors 2024-02-10 19:20:04 +01:00
Michael Voříšek
d18406a8bd Fix binary operator spaces CS (#9330)
* align_single_space_minimal for assign

* assign operators grouping is not supported by PHP CS Fixer

* binary_operator_spaces = single_space

* fix anonymous function on single line

* align comments manually
2024-02-02 07:53:34 +01:00
Aleksander Machniak
a73a53c8ef Replace deprecated methods use 2024-01-27 09:58:01 +01:00
Michael Voříšek
4ee79b9e84 fix "explicit_string_variable" (#9315) 2024-01-22 08:05:59 +01:00
Michael Voříšek
b1a0067e5d Fix more CS (#9303)
* fix "class_attributes_separation"

* fix "ternary_to_null_coalescing"

* fix "no_extra_blank_lines"

* fix "php_unit_data_provider_name" - use snake_case

* fix remaining "function data_" manually

* move "php_unit_test_case_static_method_calls" to a better place in cnf

* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Michael Voříšek
6a53a1d853 Fix CS (whitespace, visibility) (#9297)
* Fix "method_argument_space"

* Fix "control_structure_continuation_position"

* Fix "new_with_parentheses"

* Fix "blank_line_before_statement"

* Fix "visibility_required"

* Fix some "array_indentation"

* Fix some "array_indentation" - unify all "rcube::raise_error" calls

* rm useless eslint ignores and add rules counts

* sort eslint ignores

* fix eslint ignores grammar

* Revert "Fix "blank_line_before_statement""

* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
ca8b17d191 Modernize more basic CS (#9258)
* fix "yoda_style"

* fix "is_null"

* rm useless rule ignores

* add full "PhpCsFixer:risky" ruleset

* fix "implode_call"

* fix "no_alias_functions"

* fix "array_push"

* fix "long_to_shorthand_operator"

* fix "ternary_to_elvis_operator"

* fix "logical_operators"

* fix "fopen_flags"

* rename "returns" phpdoc tags to "return"

* fix "php_unit_construct"

* fix "function_to_constant"

* fix "php_unit_data_provider_return_type"

* fix "php_unit_set_up_tear_down_visibility"

* some safe "string_length_to_empty"

* fix "phpdoc_align"

* fix "phpdoc_no_alias_tag"

* fix "trailing_comma_in_multiline"

---------

Co-authored-by: Aleksander Machniak <alec@alec.pl>
2023-12-17 09:51:11 +01:00
Aleksander Machniak
7a269a2b84 Replace get_input_value() with get_input_string() where appropriate 2021-09-13 19:31:49 +02:00
Aleksander Machniak
8eb382b4ca PHP8 fixes 2020-12-11 20:29:41 +01:00
Aleksander Machniak
14a94cf0d7 PHP8 fixes, CS fixes, short array syntax, tests 2020-12-09 21:11:46 +01:00
Aleksander Machniak
f95212d626 PHP8: More warnings fixed 2020-10-11 15:24:30 +02:00
Aleksander Machniak
e0b56aeb4d Fix PHP warning for real (#7206) 2020-03-29 10:55:53 +02:00
PhilW
65a6a511a6 markasjunk: handle select all case (#7206) 2020-02-09 11:10:56 +00:00
Aleksander Machniak
b3b0c5efe2 Remove redundant rcmail_ prefix 2019-07-31 13:17:52 +02:00
Aleksander Machniak
ce9c52e65a Merge branch 'master' into dev/elastic 2019-04-27 10:53:46 +02:00
Aleksander Machniak
57c67db029 Remove year(s) from copyright headers + some cleanup 2019-04-16 10:42:45 +02:00
Aleksander Machniak
f1e911ec03 Elastic: Toolbar/menus/layout refactoring
Refactoring for better consistency and simplicity.

5KB less in size of (minified) styles.css file.

Layout changes:
- body > #layout > .menu       -> #layout-menu
- body > #layout > .list       -> #layout-list
- body > #layout > .sidebar    -> #layout-sidebar
- body > #layout > .content    -> #layout-content

Toolbar/menu changes:
- .toolbar           -> .toolbar.menu
- .toolbarmenu       -> .menu.listing
- .menu-button       -> .task-menu-button
- .pagenav.toolbar   -> .pagenav.menu
- #taskmenu          -> #taskmenu.menu.toolbar
- .image-tools .menu -> .image-tools .menu.toolbar
- required .disabled class to de-activate menu items
- .button class is not required on .menu children
- merge toolbar.less and taskmenu.less into menu.less
- @color-toolbarmenu-hover            -> @color-menu-hover
- @color-toolbarmenu-hover-background -> @color-menu-hover-background

Also cleaned/removed some code in spellchecker.js. Made .googie_list a list not table.
2019-03-24 19:25:56 +01:00
Aleksander Machniak
cb6c79e2dd Integrate markasjunk2 features into markasjunk - marking as non-junk + learning engine (#6504) 2018-11-10 08:37:15 +01:00
Aleksander Machniak
8e543f843e Fix check_request() bypass in places using get_uids() [CVE-2018-9846] (#6238) 2018-04-09 09:07:27 +02:00
Aleksander Machniak
9ce8948294 Get rid of the 2nd argument of include_stylesheet()
.. make the optional behavior default now.
2017-11-20 14:03:07 +01:00
Aleksander Machniak
625c3c3942 Elastic: Set innerClass for Junk button 2017-09-06 08:58:04 +02:00
Aleksander Machniak
69f50b122d Add a way to include plugin stylesheets optionally only if the file exists 2017-08-06 19:46:22 +02:00
Aleksander Machniak
391d0d2039 Remove "@version @package_version@" 2016-11-01 18:26:47 +01:00
Aleksander Machniak
9f1f754daf CS fixes 2015-11-22 09:41:53 +01:00
Thomas Bruederli
7fce8fbbde Adapt archive and markasjunk plugins to work with multi-folder search results 2014-04-07 18:00:09 +02:00
Aleksander Machniak
05da1577aa Fix setting of Junk and NonJunk flags by markasjunk plugin (#1489285)
Added possibility to register flag mappings by a plugin.
2013-08-29 09:20:33 +02:00
Aleksander Machniak
61be822d62 Remove deprecated functions (from bc.php file) usage in plugins 2013-01-18 15:24:49 +01:00
thomascube
48e9c14ebd Move plugins repository into roundcubemail root folder; svn:externals are not defined anymore 2012-03-31 12:25:48 +00:00
till
63a3dc5fde moved plugins 2010-03-20 14:20:01 +00:00
alecpl
9b94eb6415 - Fix setting task name according to auth state. So, any action before user
is authenticated is assigned to 'login' task instead of 'mail'. Now binding
  plugins to 'login' task is possible and realy usefull. It's also possible 
  to bind to all tasks excluding 'login'.
2010-02-06 18:12:49 +00:00
alecpl
6a7d063e61 - don't load some stuff before login (#1486475) 2010-02-05 14:06:53 +00:00
thomascube
531e8862d2 Typo 2009-10-28 22:54:04 +00:00
thomascube
01accaff5b Add fallback to default skin if the selected one is not available in plugin directory 2009-10-28 22:53:40 +00:00
alecpl
2cb5b5a9e5 - markasjunk: added NonJunk flag unsetting, added ru_RU localization 2009-10-27 12:02:24 +00:00
alecpl
34aec72131 - Support skins in 'archive' and 'markasjunk' plugins 2009-09-15 13:47:12 +00:00
alecpl
e077870aff - markasjunk: add button title (#1486092) 2009-09-06 18:19:08 +00:00
thomascube
cc97ea0559 Merged branch devel-api (from r2208 to r2387) back into trunk (omitting some sample plugins) 2009-04-19 17:44:29 +00:00