Aleksander Machniak
a9b1ca34f3
Update min PHP version check, cleanup outdated checks/comments
2025-02-23 11:18:50 +01:00
Philip Weir
ccede1f272
Update links in comments and config to https where available ( #9759 )
2025-01-26 13:34:57 +01:00
Bennet Becker
353de7c9a9
Managesieve: Parse all time and timezone formatters in sieve_formattime() that PHP understands
2024-11-21 14:35:44 +01:00
Michael Voříšek
efcdce84ba
Keep phpstan strict rules testing ( #9424 )
...
* Revert "Get rid of phpstan/phpstan-strict-rules"
This reverts commit ff59ade31a
2024-11-20 08:13:16 +01:00
Michael Voříšek
6a5f9ee7ce
Add override method attributes ( #9272 )
2024-06-02 15:57:56 +02:00
Aleksander Machniak
ff59ade31a
Get rid of phpstan/phpstan-strict-rules
2024-04-21 11:33:51 +02:00
Aleksander Machniak
49a40ea126
Code improvements
2024-03-23 13:48:51 +01:00
Aleksander Machniak
a1f39f47b7
Fix phpstan errors
2024-02-10 19:20:04 +01:00
Michael Voříšek
d18406a8bd
Fix binary operator spaces CS ( #9330 )
...
* align_single_space_minimal for assign
* assign operators grouping is not supported by PHP CS Fixer
* binary_operator_spaces = single_space
* fix anonymous function on single line
* align comments manually
2024-02-02 07:53:34 +01:00
Aleksander Machniak
a73a53c8ef
Replace deprecated methods use
2024-01-27 09:58:01 +01:00
Michael Voříšek
4ee79b9e84
fix "explicit_string_variable" ( #9315 )
2024-01-22 08:05:59 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
3e458fa5fd
Refer native constants unambiguously ( #9275 )
...
* Fix "native_constant_invocation" CS
* "self_accessor" was fixed in 9269 PR
* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
28c778b7a0
Modernize more CS III ( #9270 )
...
* fix "single_trait_insert_per_statement"
* fix "empty_loop_condition"
* fix "backtick_to_shell_exec"
* fix "phpdoc_to_comment"
* fix "no_empty_statement"
* fix "heredoc_to_nowdoc"
* fix "class_reference_name_casing"
* fix "align_multiline_comment"
* fix "heredoc_indentation"
* fix "constant_case"
* fix "single_line_comment_style"
* fix "no_null_property_initialization"
* fix "standardize_increment"
* fix "no_unneeded_control_parentheses"
* fix missing NL after "<?php"
* fix php in *.sh files too
* fix trailing spaces from all text files
* fix "explicit_indirect_variable"
* Revert "fix "align_multiline_comment""
This reverts commit 42e584f8e32101c2a3a3
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Aleksander Machniak
5526aa99ab
Add List-ID to the list of headers for creating new sieve-filters ( #8307 )
2023-03-26 18:49:09 +02:00
Aleksander Machniak
7c53300990
PHP8 fixes, CS fixes, short array syntax, tests
2020-12-08 21:56:41 +01:00
Aleksander Machniak
545a1569f1
Steps -> Actions refactoring ( #7688 )
...
* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes
2020-11-01 11:25:38 +01:00
Aleksander Machniak
eb7636d491
Fixes in context of undefined variables, and code style
2020-08-16 10:29:42 +02:00
Aleksander Machniak
ce9c52e65a
Merge branch 'master' into dev/elastic
2019-04-27 10:53:46 +02:00
Aleksander Machniak
3562d7ffa6
Fix so "Create filter" option does not show up when Filters menu is disabled ( #6723 )
2019-04-21 08:35:40 +02:00
Aleksander Machniak
57c67db029
Remove year(s) from copyright headers + some cleanup
2019-04-16 10:42:45 +02:00
Aleksander Machniak
fd167152e1
jqueryui plugin is already required by core
2019-04-08 11:45:25 +02:00
Aleksander Machniak
e8ff189627
Use simpler code
2019-03-25 12:36:50 +01:00
Aleksander Machniak
77439f9772
Add missing role=menuitem
2019-03-25 12:30:35 +01:00
Aleksander Machniak
f1e911ec03
Elastic: Toolbar/menus/layout refactoring
...
Refactoring for better consistency and simplicity.
5KB less in size of (minified) styles.css file.
Layout changes:
- body > #layout > .menu -> #layout-menu
- body > #layout > .list -> #layout-list
- body > #layout > .sidebar -> #layout-sidebar
- body > #layout > .content -> #layout-content
Toolbar/menu changes:
- .toolbar -> .toolbar.menu
- .toolbarmenu -> .menu.listing
- .menu-button -> .task-menu-button
- .pagenav.toolbar -> .pagenav.menu
- #taskmenu -> #taskmenu.menu.toolbar
- .image-tools .menu -> .image-tools .menu.toolbar
- required .disabled class to de-activate menu items
- .button class is not required on .menu children
- merge toolbar.less and taskmenu.less into menu.less
- @color-toolbarmenu-hover -> @color-menu-hover
- @color-toolbarmenu-hover-background -> @color-menu-hover-background
Also cleaned/removed some code in spellchecker.js. Made .googie_list a list not table.
2019-03-24 19:25:56 +01:00
Aleksander Machniak
339121b121
Fix bug where managesieve_allowed_hosts config wasn't respected on mail screen ( #6295 )
2018-05-20 11:55:46 +02:00
Aleksander Machniak
53fe9d7048
Bump managesieve version number, cs improvements
2018-05-19 09:01:46 +02:00
Athanasios Douitsis
b497908040
Managesieve allowed hosts ( #6292 )
...
* Introduce managesieve_allowed_hosts setting
If managesieve_allowed_hosts has been set, then check that the array contains the current mail_host for the user session. If not, just return. This will cause the managesieve plugin to not appear under the settings menu.
* Include managesieve_allowed_hosts example
An example of the managesieve_allowed_hosts setting is included. By default, it is left commented to preserve existing behaviour.
2018-05-19 08:51:05 +02:00
Aleksander Machniak
8e543f843e
Fix check_request() bypass in places using get_uids() [CVE-2018-9846] ( #6238 )
2018-04-09 09:07:27 +02:00
Timotheus Pokorra
e853b1798a
managesieve: new settings dialog for simple forwarding of emails
...
this hides the complexity of the filters from the user, similar to the vacation settings dialog.
related to #6021
2017-11-02 17:10:18 +01:00
Aleksander Machniak
4452a16f7f
Cleanup and improve CodeMirror integration
...
Fixed some issues, improved css/layout, added autoscroll to invalid line on error
2016-11-27 05:11:00 -05:00
Aleksander Machniak
39cceb2f89
Managesieve: Various improvement to raw script editor
2016-11-10 12:05:28 +01:00
Martin Fischer
7215013b53
implemented raw editor for sieve filter sets ( #5473 )
...
* implemented raw editor for sieve filter sets
Signed-off-by: Martin Fischer <martin.fischer@fau.de >
* updated according to comments
2016-11-10 12:05:04 +01:00
Aleksander Machniak
391d0d2039
Remove "@version @package_version@"
2016-11-01 18:26:47 +01:00
Aleksander Machniak
9f1f754daf
CS fixes
2015-11-22 09:41:53 +01:00
Aleksander Machniak
570f43c874
Don't load enigma and managesieve css where it's not needed
2015-10-13 09:13:44 +02:00
Aleksander Machniak
e979511083
Remove redundant is_file() checks
2014-10-29 11:15:01 +01:00
Aleksander Machniak
6e6f9ce6a7
Fix compatybility with contextmenu plugin
2014-09-08 11:27:59 +02:00
Aleksander Machniak
613f96839c
Added simple API to manage vacation rule
2014-08-26 01:24:21 -04:00
Aleksander Machniak
4d52ee03a1
Fix missing css/js scripts in filter form in mail task
2014-07-28 11:13:46 +02:00
Aleksander Machniak
ebc9877def
Add title attribute for settings menu
2014-06-16 11:18:30 +02:00
Aleksander Machniak
056d458ed6
Fix disabled create filter action
2014-04-13 12:14:06 +02:00
Aleksander Machniak
50a57e9b75
Added optional separate interface for out-of-office management ( #1488266 )
2014-03-14 13:36:43 +01:00
Aleksander Machniak
fb5255e2f0
Fix filter creation from an email when preview frame is disabled ( #1489647 )
2014-02-26 20:23:46 +01:00
Aleksander Machniak
4e040e304f
Add Filters tab using plugin API hook
2014-01-04 11:18:52 +01:00
Aleksander Machniak
27f0c2723b
Nicely handle server-side modification of script names ( #1489412 )
2013-12-09 11:40:03 +01:00
Thomas Bruederli
07c6c69eca
Make all bundled plugins the same license as Roundcube itself, which is GPLv3+
2013-06-20 22:06:28 +02:00
Aleksander Machniak
8ea08a8264
Split managesieve.php file into two
2013-06-15 16:34:25 +02:00
