Commit Graph

108 Commits

Author SHA1 Message Date
Michael Voříšek
f4272804d6 Rename test files for PHPUnit 10+ (#9477) 2024-06-05 07:46:51 +02:00
Michael Voříšek
6a5f9ee7ce Add override method attributes (#9272) 2024-06-02 15:57:56 +02:00
Michael Voříšek
1e360999b2 Use composer autoloader for bundled plugins testing (#9412)
* use fixed "roundcube/plugin-installer"

* Use composer autoloader for plugins testing

* cherrypick remaining from 9241 related with testing

* minor legacy autoload improvements
2024-04-11 18:28:46 +02:00
Michael Voříšek
52d8172b0f Allow composer autoloading (to coexist) (#9407)
* Replace custom loader in favor of composer native

* Load plugins using composer

* finish debug_logger plugin

* finish markasjunk plugin

* finish password plugin

* finish enigma plugin

* finish managesieve plugin

* fix ExtensionInstaller run on first install

* fix phpstan "Implicit array creation" in plugin config files

* simplify composer.json

* keep non-composer autoloading relying on include_path set in plugins

* update minimal "roundcube/plugin-installer" version

* "plugins.roundcube.net" root-only package repo is not needed

* REVERT ALL

* fix phpstan "Implicit array creation" in plugin config files

* update minimal "roundcube/plugin-installer" version

* reland composer.json changes

* fix ExtensionInstaller run on first install

* Roundcube (non plugin) tests are fine to rely on composer autoload

* fix CS of master

* not needed until strict composer autoloading

* improve comment

* revert rcmail_oauth change - fixed in plugin installer

* require fixed plugin installer
2024-04-10 12:27:43 +02:00
Michael Voříšek
b5a3fd646b Fix "Implicit array creation" in plugin config files (#9406)
* fix phpstan "Implicit array creation" in plugin config files
* update minimal "roundcube/plugin-installer" version
2024-04-07 12:00:03 +02:00
Michael Voříšek
736795326c Fix plugins composer.json format (#9405)
* Check plugins composer.json using CI

* Add "require-dev" and "config.allow-plugins" to plugins

* fix composer.json format - rm invalid email

* fix composer.json format - fix ext require

* fix composer.json format - fix plugin name

* tmp

* Revert "tmp"

* fix ext in ext install

* disable plugin in plugin install until Roundcube is fully autoloadable

* fix composer.json format - fix non-canonical license name

* Revert "Add "require-dev" and "config.allow-plugins" to plugins"

* no composer install for plugins needed

* Revert "fix ext in ext install"

* add standard "Test" suffix to phpunit files

* rm unneeded "suffix" in phpunit config

* simplify phpunit config

* fix default "xhtml" doctype in unit testing

* fix test_format_date test to not rely on other tests

* even more phpunit config simplify

* stricter/unify phpunit params for E2E tests

* run E2E tests on maximal php version too with lowest deps

* "repositories" in bundled plugins are useless as for root package only

* add/unify missing plugin test
2024-04-05 17:55:46 +02:00
Aleksander Machniak
49a40ea126 Code improvements 2024-03-23 13:48:51 +01:00
Michael Voříšek
d18406a8bd Fix binary operator spaces CS (#9330)
* align_single_space_minimal for assign

* assign operators grouping is not supported by PHP CS Fixer

* binary_operator_spaces = single_space

* fix anonymous function on single line

* align comments manually
2024-02-02 07:53:34 +01:00
Aleksander Machniak
6f8fc03fe8 Solve some phpstan errors 2024-01-24 14:20:21 +01:00
Michael Voříšek
4ee79b9e84 fix "explicit_string_variable" (#9315) 2024-01-22 08:05:59 +01:00
Michael Voříšek
54f4aa33f9 Fix CS - imports (#9316)
* fix Tests\Browser\TestCase imports

* fix remaining imports

* fix PHPUnit\Framework\TestCase imports

* import GuzzleHttp\Client

* fix remaining

* "php_unit_method_casing" is not todo

* fix "single_line_comment_spacing"

* fix 2nd commit done using older fixer
2024-01-21 19:13:31 +01:00
Michael Voříšek
6a53a1d853 Fix CS (whitespace, visibility) (#9297)
* Fix "method_argument_space"

* Fix "control_structure_continuation_position"

* Fix "new_with_parentheses"

* Fix "blank_line_before_statement"

* Fix "visibility_required"

* Fix some "array_indentation"

* Fix some "array_indentation" - unify all "rcube::raise_error" calls

* rm useless eslint ignores and add rules counts

* sort eslint ignores

* fix eslint ignores grammar

* Revert "Fix "blank_line_before_statement""

* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa Fix single quotes CS (#9283)
* Fix "single_quote"

* fix "escape_implicit_backslashes"

* fix typo from f363481c

* fix single quotes in JS

* fix some minor JS CS

* fix CS v3.45.0
2023-12-31 16:36:55 +01:00
Michael Voříšek
28c778b7a0 Modernize more CS III (#9270)
* fix "single_trait_insert_per_statement"

* fix "empty_loop_condition"

* fix "backtick_to_shell_exec"

* fix "phpdoc_to_comment"

* fix "no_empty_statement"

* fix "heredoc_to_nowdoc"

* fix "class_reference_name_casing"

* fix "align_multiline_comment"

* fix "heredoc_indentation"

* fix "constant_case"

* fix "single_line_comment_style"

* fix "no_null_property_initialization"

* fix "standardize_increment"

* fix "no_unneeded_control_parentheses"

* fix missing NL after "<?php"

* fix php in *.sh files too

* fix trailing spaces from all text files

* fix "explicit_indirect_variable"

* Revert "fix "align_multiline_comment""

This reverts commit 42e584f8e3.

* fix "align_multiline_comment" properly

* Revert "fix trailing spaces from all text files" - diff files only

* Revert "Revert "fix trailing spaces from all text files" - diff files only"

This reverts commit 2101c2a3a3.

* rm useless "setup-php" config
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146 Modernize more basic CS II (#9254)
* fix "integer_literal_case"

* fix "phpdoc_separation"

* fix "phpdoc_var_without_name"

* fix "operator_linebreak"

* fix "no_alias_language_construct_call"

* fix "list_syntax"

* fix "concat_space"

* fix "array_syntax"

* fix "binary_operator_spaces"

* fix "binary_operator_spaces" relaxed

* fix "phpdoc_types_order"

* fix "phpdoc_trim"

* fix "native_type_declaration_casing"

* fix "method_chaining_indentation"

* fix "phpdoc_no_package"

* fix "elseif"

* fix PHP CS Fixer config itself too

* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Aleksander Machniak
77ae91f213 CS fixes in .php.dist files 2023-12-17 12:02:14 +01:00
Aleksander Machniak
c5022b9e52 Update jQuery-UI to version 1.13.2 (#9041) 2023-07-08 10:10:38 +02:00
Дилян Палаузов
e240dc7060 Optimize PNG files (#8827)
by calling

optipng -o7 -zm9 -strip all `find -name '*.png'`

This will lead to less data transferred to the browsers.
2022-12-30 10:12:42 +01:00
Aleksander Machniak
f9af15c8d1 Update to jQuery-UI 1.13.1 (#8455) 2022-03-12 09:26:28 +01:00
Aleksander Machniak
0dc2679cb2 Don't fallback to Larry 2021-11-27 14:26:26 +01:00
Aleksander Machniak
b6e0d6263c Moved the Larry skin to its own repository (#8271) 2021-11-27 14:08:47 +01:00
Aleksander Machniak
27f5fccaa7 Moved the Classic skin to its own repository (#8271)
https://github.com/roundcube/classic
2021-11-14 10:17:23 +01:00
Aleksander Machniak
89e54718ca Migration to PHPUnit v9 2021-07-25 11:07:56 +02:00
Aleksander Machniak
9e2bc40213 Dropped support for PHP < 7.3 (#7976) 2021-07-25 09:16:33 +02:00
Aleksander Machniak
ac8e067ae6 Use official GPL-3.0-or-later license identifier (#7901) 2021-02-24 15:39:36 +01:00
Aleksander Machniak
13e1455cd2 Bump PHP version requirement also for plugins
[skip ci]
2021-02-07 10:02:11 +01:00
Aleksander Machniak
996ae95f38 Fix regression in including minicolors and tagedit styles 2021-01-03 18:41:55 +01:00
johndoh
dec10e51da Support providing skins for plugins inside the main skin folder (#7445) 2020-12-21 09:45:34 +01:00
Aleksander Machniak
7c53300990 PHP8 fixes, CS fixes, short array syntax, tests 2020-12-08 21:56:41 +01:00
Aleksander Machniak
f95212d626 PHP8: More warnings fixed 2020-10-11 15:24:30 +02:00
Aleksander Machniak
d6aca6b6b7 Elastic: Drak mode (#6709) 2020-07-07 18:58:28 +02:00
Aleksander Machniak
47d9ed6d0c Add support for PHPUnit 6 and 7 (#6870)
Fixes composer dependencies: Package phpunit/phpunit-mock-objects is abandoned

We cannot support v8 yet because of errors like:
Declaration of MailFunc::setUp() must be compatible with PHPUnit\Framework\TestCase::setUp(): void
It would require dropping PHP < 7.1 support.
2019-12-28 09:37:45 +01:00
Aleksander Machniak
4b607e2ed3 Fix so Elastic is also a default in jqueryui plugin (#7039) 2019-11-18 15:30:23 +01:00
PhilW
32775f0e43 remove redundant type attrib in script tag 2019-10-19 13:54:52 +01:00
Aleksander Machniak
cc1a1d95fe Correct property name 2019-10-16 12:40:41 +02:00
Aleksander Machniak
4096739322 Fix including assets that exist only in minified version 2019-08-30 12:08:48 +02:00
Aleksander Machniak
1a68fe25c0 Elastic: Fix padding in jQuery-UI dialogs 2019-03-25 12:51:08 +01:00
Aleksander Machniak
1473522928 Keep .diff instead of .orig files 2019-01-30 12:02:49 +01:00
Aleksander Machniak
b6a3df2824 Update to jQuery-MiniColors 2.3.4
Fixes color picker issue when using Roundcube in an iframe.
2019-01-30 11:59:29 +01:00
Rotzbua
f8b6493ecf Change http to https for plugins.roundcube.net (#6405) 2018-11-08 12:30:45 +01:00
Aleksander Machniak
d49eb1889b Fix selecting jQuery-UI styles for skins that extend Elastic 2018-04-28 11:11:00 +00:00
Aleksander Machniak
50312af17e Fix fatal error on asset_exists() use 2018-04-12 06:45:00 +00:00
Aleksander Machniak
ff55fa622f Fix jqueryui plugin compatibility with assets_dir setting 2018-04-10 17:27:41 +02:00
Aleksander Machniak
df30d71e5a Elastic: Improvements to .ui-menu and z-index fix in the slider 2018-03-21 15:55:24 +00:00
Aleksander Machniak
0a01ccc00d Remove redundant datepicker localization 2018-01-15 13:45:23 +01:00
Aleksander Machniak
20a0ca6b16 Elastic: Remove tagedit.css, these styles are handled by the skin now 2018-01-10 13:41:11 +01:00
Aleksander Machniak
de544cc905 Add possibility to use localized date format as datepicker input placeholder
Need to be supported by skin. Elastic support is comming.
2017-12-07 12:05:10 +01:00
Aleksander Machniak
13dab18652 Add minicolors config to the client env 2017-11-23 11:42:12 +01:00
Aleksander Machniak
375d648917 Improve minicolors widget style for Elastic 2017-11-14 13:51:47 +01:00
Aleksander Machniak
dbecd3c8b5 Elastic: Fix padding for dialog buttons 2017-10-17 13:32:49 +02:00