Aleksander Machniak
94fd5a0f80
CS fixes (for the new fixer version rules)
2025-02-23 11:51:27 +01:00
Aleksander Machniak
fc9b253e84
Fix new phpstan error
2024-09-29 11:48:58 +02:00
Aleksander Machniak
d59cfdff46
Ignore phpstan error
2024-06-07 16:07:50 +02:00
Aleksander Machniak
7713b7c1bd
Enigma: Code improvements
2024-03-21 14:52:51 +01:00
Michael Voříšek
d18406a8bd
Fix binary operator spaces CS ( #9330 )
...
* align_single_space_minimal for assign
* assign operators grouping is not supported by PHP CS Fixer
* binary_operator_spaces = single_space
* fix anonymous function on single line
* align comments manually
2024-02-02 07:53:34 +01:00
Aleksander Machniak
845db4cc34
Fix various phpstan issues
2024-01-28 19:08:01 +01:00
Michael Voříšek
4ee79b9e84
fix "explicit_string_variable" ( #9315 )
2024-01-22 08:05:59 +01:00
Michael Voříšek
b1a0067e5d
Fix more CS ( #9303 )
...
* fix "class_attributes_separation"
* fix "ternary_to_null_coalescing"
* fix "no_extra_blank_lines"
* fix "php_unit_data_provider_name" - use snake_case
* fix remaining "function data_" manually
* move "php_unit_test_case_static_method_calls" to a better place in cnf
* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2023-12-31 16:36:55 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Aleksander Machniak
a31cb3d166
Enigma: Fix finding of a private key when decrypting a message using GnuPG v2.3
...
Additional fix for a case when sender's public key is in the keyring
2023-11-22 18:44:51 +01:00
Aleksander Machniak
7b616863b2
Enigma: Fix finding of a private key when decrypting a message using GnuPG v2.3
2023-11-22 14:33:20 +01:00
Aleksander Machniak
f2688ba492
Use ?? operator where applicable
2021-09-21 19:12:06 +02:00
Aleksander Machniak
7a269a2b84
Replace get_input_value() with get_input_string() where appropriate
2021-09-13 19:31:49 +02:00
Aleksander Machniak
e2187b8f2d
Fix various PHP 8.1 warnings
2021-08-27 16:52:54 +02:00
Aleksander Machniak
0c24068b5d
Use small button inside boxinformation
2021-06-03 10:06:59 +02:00
Josh Soref
203f456620
Spelling ( #8001 )
2021-04-18 08:43:18 +02:00
Aleksander Machniak
1cba77b48e
Enigma: Display an information that public and private keys are stored on the server ( #7941 )
2021-04-11 12:14:18 +02:00
Aleksander Machniak
8a0edf9c94
Enigma: Fix expiration dates of PGP keys capped at 2038-01-19 on a 32bit system ( #7531 )
...
Requires: https://github.com/pear/Crypt_GPG/commit/9715067e3142275
2021-03-15 19:54:56 +01:00
Aleksander Machniak
3bbb01fe13
PHP8 fixes, regression fixes
2020-12-13 12:14:15 +01:00
Aleksander Machniak
ed146b68db
PHP8 fixes, CS fixes, short array syntax, tests
2020-12-10 20:27:32 +01:00
Aleksander Machniak
e3416c9fc0
PHP8 fixes, CS fixes, short array syntax, tests
2020-12-06 11:43:56 +01:00
Aleksander Machniak
545a1569f1
Steps -> Actions refactoring ( #7688 )
...
* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes
2020-11-01 11:25:38 +01:00
Aleksander Machniak
eb7636d491
Fixes in context of undefined variables, and code style
2020-08-16 10:29:42 +02:00
Aleksander Machniak
b0d69503e0
Enigma: Support ECC key generation - when using GnuPG >= 2.1.7 ( #6853 )
2020-07-26 19:26:31 +02:00
Aleksander Machniak
36bf280a97
Elastic: Minimize forms/colors blink on page load
2020-07-11 10:52:24 +02:00
Aleksander Machniak
689c761026
Enigma: Simplify and fix handling of IDN with not all parts being punny-coded
2020-01-18 09:29:30 +01:00
Aleksander Machniak
e89376709c
Enigma: Display IDN domains of key users and identities in UTF8
2020-01-17 20:35:48 +01:00
Max Bosse
3faa976fc8
Fix creation of pgp-keys for IDN emails
2020-01-16 22:46:55 +01:00
Aleksander Machniak
66fab8cdb2
CS fixes, Avoid usused variables, fixed minor bugs
2019-10-05 19:44:39 +02:00
Jack Cherng
198585d8a0
Fix implode() wrong parameter order ( #6866 )
...
It has been deprecated in PHP 7.4.
Such as PHP deprecated: implode(): Passing glue string after array is deprecated. Swap the parameters in /var/www/roundcubemail/program/lib/Roundcube/rcube_db.php on line 917
Signed-off-by: Jack Cherng <jfcherng@gmail.com >
2019-08-09 16:04:51 +02:00
Aleksander Machniak
f6807bcc4c
Added 'keyservers' option to define list of HKP servers for Enigma/Mailvelope ( #6326 )
2019-06-14 19:06:32 +02:00
Aleksander Machniak
940e500c1f
Enigma: For verified signatures, display the user id associated with the sender address ( #5958 )
2019-06-09 09:52:39 +02:00
Aleksander Machniak
1ee7253ff2
Enigma: Fix error message when trying to encrypt with a revoked private key ( #6607 )
2019-05-11 09:03:32 +02:00
Aleksander Machniak
6efa88f049
Enigma: Fix bug where revoked users/keys were not greyed out in key info
...
The 'deleted' class was assigned to the wrong (next) row in a table.
It also didn't work in Elastic skin at all because of the missing style.
2019-05-11 08:35:05 +02:00
Aleksander Machniak
57c67db029
Remove year(s) from copyright headers + some cleanup
2019-04-16 10:42:45 +02:00
Aleksander Machniak
19c0d48267
Enigma: Skip encryption if the message has been already encrypted by Mailvelope
2018-08-10 10:09:40 +02:00
Aleksander Machniak
2fa112bd83
[EFAIL] Don't decrypt PGP messages with no MDC protection ( #6289 )
2018-05-29 09:27:30 +02:00
Aleksander Machniak
e05be853da
Enigma: Add hint about max upload size in key import form
2018-05-24 13:25:27 +02:00
johndoh
647a7e91c6
Unify content frame (watermark) template objects ( #6285 )
...
* unify content frame (watermark) template objects
* several improvements, use existing env var for watermark url
* tighten up var parsing for contentframe template object
2018-05-18 17:25:02 +02:00
Aleksander Machniak
e79838aaac
Enigma: Disable autofill for new keypair password
2018-04-20 08:11:22 +02:00
Aleksander Machniak
662363c7e2
Enigma: Add positiblity to modify list of identities for key generation by other plugins
2018-04-05 11:55:25 +00:00
Aleksander Machniak
f211fcf254
Elastic: Use .boxconfirmation
2018-02-14 12:37:40 +01:00
Aleksander Machniak
0f21488ce2
Elastic: Fix enigma information boxes
2018-02-14 12:22:30 +01:00
Aleksander Machniak
674eac1c1c
Enigma: Fix key generation in Safari by upgrade to OpenPGP 2.6.2 ( #6149 )
2018-02-12 16:46:25 +01:00
Aleksander Machniak
9ce8948294
Get rid of the 2nd argument of include_stylesheet()
...
.. make the optional behavior default now.
2017-11-20 14:03:07 +01:00
Aleksander Machniak
e6fd3982f6
Elastic: set some checkbox classes
2017-10-28 10:21:59 +02:00
