Michael Voříšek
6a5f9ee7ce
Add override method attributes ( #9272 )
2024-06-02 15:57:56 +02:00
Michael Voříšek
a30e0ad438
Infer file/line location in rcube::raise_error() from backtrace ( #9422 )
...
* \n\s+'file' => __FILE__,
* \n\s+'line' => __LINE__,
* 'line' => __LINE__, 'file' => __FILE__,
* 'file' => __FILE__, 'line' => __LINE__,
* rest
* more
* improve cs
* more cs
* revert rcube_utils::preg_error changes
* impl file/line from backtrace
* Revert "revert rcube_utils::preg_error changes"
2024-04-21 11:48:35 +02:00
Aleksander Machniak
7713b7c1bd
Enigma: Code improvements
2024-03-21 14:52:51 +01:00
Michael Voříšek
d18406a8bd
Fix binary operator spaces CS ( #9330 )
...
* align_single_space_minimal for assign
* assign operators grouping is not supported by PHP CS Fixer
* binary_operator_spaces = single_space
* fix anonymous function on single line
* align comments manually
2024-02-02 07:53:34 +01:00
Aleksander Machniak
845db4cc34
Fix various phpstan issues
2024-01-28 19:08:01 +01:00
Aleksander Machniak
34500a4fa4
Fix "missing return statement" phpstan errors
2024-01-27 19:07:52 +01:00
Michael Voříšek
4ee79b9e84
fix "explicit_string_variable" ( #9315 )
2024-01-22 08:05:59 +01:00
Michael Voříšek
b1a0067e5d
Fix more CS ( #9303 )
...
* fix "class_attributes_separation"
* fix "ternary_to_null_coalescing"
* fix "no_extra_blank_lines"
* fix "php_unit_data_provider_name" - use snake_case
* fix remaining "function data_" manually
* move "php_unit_test_case_static_method_calls" to a better place in cnf
* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2023-12-31 16:36:55 +01:00
Michael Voříšek
3e458fa5fd
Refer native constants unambiguously ( #9275 )
...
* Fix "native_constant_invocation" CS
* "self_accessor" was fixed in 9269 PR
* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
28c778b7a0
Modernize more CS III ( #9270 )
...
* fix "single_trait_insert_per_statement"
* fix "empty_loop_condition"
* fix "backtick_to_shell_exec"
* fix "phpdoc_to_comment"
* fix "no_empty_statement"
* fix "heredoc_to_nowdoc"
* fix "class_reference_name_casing"
* fix "align_multiline_comment"
* fix "heredoc_indentation"
* fix "constant_case"
* fix "single_line_comment_style"
* fix "no_null_property_initialization"
* fix "standardize_increment"
* fix "no_unneeded_control_parentheses"
* fix missing NL after "<?php"
* fix php in *.sh files too
* fix trailing spaces from all text files
* fix "explicit_indirect_variable"
* Revert "fix "align_multiline_comment""
This reverts commit 42e584f8e32101c2a3a3
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a
Fix invalid phpdocs ( #9252 )
...
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Aleksander Machniak
7b616863b2
Enigma: Fix finding of a private key when decrypting a message using GnuPG v2.3
2023-11-22 14:33:20 +01:00
Aleksander Machniak
401e761c02
Enigma: Fix initial synchronization of private keys
2022-03-11 11:30:51 +01:00
Josh Soref
203f456620
Spelling ( #8001 )
2021-04-18 08:43:18 +02:00
Aleksander Machniak
8a0edf9c94
Enigma: Fix expiration dates of PGP keys capped at 2038-01-19 on a 32bit system ( #7531 )
...
Requires: https://github.com/pear/Crypt_GPG/commit/9715067e3142275
2021-03-15 19:54:56 +01:00
Aleksander Machniak
ed146b68db
PHP8 fixes, CS fixes, short array syntax, tests
2020-12-10 20:27:32 +01:00
Aleksander Machniak
e3416c9fc0
PHP8 fixes, CS fixes, short array syntax, tests
2020-12-06 11:43:56 +01:00
Aleksander Machniak
8bda4ecbcf
Fix an obvious code bugs
2020-08-15 12:44:07 +02:00
Aleksander Machniak
b0d69503e0
Enigma: Support ECC key generation - when using GnuPG >= 2.1.7 ( #6853 )
2020-07-26 19:26:31 +02:00
Aleksander Machniak
1613f3ab4c
INSERT OR REPLACE implementation ( #6771 )
...
For now with support in postgres and mysql databases.
For now used in rcube_cache, rcube_imap_cache and enigma plugin
2020-01-19 18:43:48 +01:00
Aleksander Machniak
66fab8cdb2
CS fixes, Avoid usused variables, fixed minor bugs
2019-10-05 19:44:39 +02:00
Aleksander Machniak
57c67db029
Remove year(s) from copyright headers + some cleanup
2019-04-16 10:42:45 +02:00
Aleksander Machniak
0e640e95c9
Enigma: Fixed multi-host syncronization of private and deleted keys and pubring.kbx file
...
Added context column to filestore table for easier listing of stored files.
2018-12-23 13:51:39 +01:00
Aleksander Machniak
412c5ab75b
Enigma: Fix deleting keys with authentication subkeys ( #6381 )
2018-08-09 15:50:23 +02:00
Aleksander Machniak
2fa112bd83
[EFAIL] Don't decrypt PGP messages with no MDC protection ( #6289 )
2018-05-29 09:27:30 +02:00
Aleksander Machniak
48417c5fc9
Remove default for enigma_pgp_homedir ( #6173 )
...
To make the default installation more secure force users to set the folder.
Added notes that it should be secured or not accessible from the web browser.
2018-03-04 09:14:43 +01:00
Aleksander Machniak
7b1f0f020b
Enigma: Multi-host support
2018-02-28 09:36:25 +01:00
Aleksander Machniak
5d08580b86
Enigma: Add options to set PGP cipher/digest algorithms ( #5645 )
2017-10-03 08:30:52 +02:00
Aleksander Machniak
d4478c4ff7
Enigma: Fix decrypting an encrypted+signed message when signature verification fails ( #5914 )
2017-08-27 13:38:35 +02:00
Aleksander Machniak
9028e77290
Enigma: Set micalg parameter to real hash algorithm used for signing
2017-03-06 10:57:20 +01:00
Aleksander Machniak
29d0b80449
Enigma: Fix PHP fatal error when decrypting a message with invalid signature ( #5555 )
2016-12-09 10:43:31 +01:00
Aleksander Machniak
ed44a73ca5
GnuPG 2.1: Fix secret keys export
2016-11-13 16:12:14 +01:00
Aleksander Machniak
ecefdca21d
GnuPG 2.1: Support password input on private key export
2016-10-23 15:51:28 +02:00
Aleksander Machniak
7829da358d
GnuPG 2.1: Fix importing newly generated (secret) keys using GnuPG 2.1
2016-09-25 13:05:21 +02:00
Aleksander Machniak
fba3e1ae0c
GnuPG 2.1: Add option to configure gpgconf binary location
2016-09-25 08:35:18 +02:00
Aleksander Machniak
dcf877c692
Enigma: Add possibility to configure gpg-agent binary location (enigma_pgp_agent)
2016-07-27 13:36:30 +02:00
Aleksander Machniak
88ed121f24
Enigma: Add possibility to export private keys ( #5321 )
2016-06-20 19:29:49 +02:00
Aleksander Machniak
ac1cd3719c
Enigma: Fix redundant list-secret-keys/list-public-keys calls on signing/encryption
2016-06-12 09:59:50 +02:00
Aleksander Machniak
f1c260b05f
Enigma: Implement PGP encryption and signing in one go ( #5302 )
...
Enigma: Display signature verification status for encrypted+signed messages (#5302 )
2016-06-07 12:29:17 +02:00
Aleksander Machniak
13b76d9b1e
Enigma: Add possibility to configure gpg binary location (enigma_pgp_binary)
2016-06-04 08:56:16 +02:00
Aleksander Machniak
6e4642b12c
Enigma: Add enigma_debug option
2016-04-17 09:32:59 +02:00
Aleksander Machniak
96c3d84cdd
Enigma: Varius fixes and cleanup in code for attaching pubkeys
2016-04-02 10:35:17 +02:00
Kyle Francis
a9d399155d
Implemented attaching pub PGP key to outgoing messages.
2016-03-30 09:33:53 -04:00
Aleksander Machniak
c852426bd4
Enigma: Display all usage flags of the subkey
2015-10-07 19:54:08 +02:00
Aleksander Machniak
13eb9bdc24
Enigma: Display complete key information (subkeys, user IDs)
2015-10-03 18:56:33 +02:00
