Commit Graph

41 Commits

Author SHA1 Message Date
Michael Voříšek
6a5f9ee7ce Add override method attributes (#9272) 2024-06-02 15:57:56 +02:00
Aleksander Machniak
7713b7c1bd Enigma: Code improvements 2024-03-21 14:52:51 +01:00
Michael Voříšek
d18406a8bd Fix binary operator spaces CS (#9330)
* align_single_space_minimal for assign

* assign operators grouping is not supported by PHP CS Fixer

* binary_operator_spaces = single_space

* fix anonymous function on single line

* align comments manually
2024-02-02 07:53:34 +01:00
Aleksander Machniak
845db4cc34 Fix various phpstan issues 2024-01-28 19:08:01 +01:00
Michael Voříšek
b1a0067e5d Fix more CS (#9303)
* fix "class_attributes_separation"

* fix "ternary_to_null_coalescing"

* fix "no_extra_blank_lines"

* fix "php_unit_data_provider_name" - use snake_case

* fix remaining "function data_" manually

* move "php_unit_test_case_static_method_calls" to a better place in cnf

* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Michael Voříšek
6a53a1d853 Fix CS (whitespace, visibility) (#9297)
* Fix "method_argument_space"

* Fix "control_structure_continuation_position"

* Fix "new_with_parentheses"

* Fix "blank_line_before_statement"

* Fix "visibility_required"

* Fix some "array_indentation"

* Fix some "array_indentation" - unify all "rcube::raise_error" calls

* rm useless eslint ignores and add rules counts

* sort eslint ignores

* fix eslint ignores grammar

* Revert "Fix "blank_line_before_statement""

* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
3e458fa5fd Refer native constants unambiguously (#9275)
* Fix "native_constant_invocation" CS

* "self_accessor" was fixed in 9269 PR

* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
e7d7e62146 Modernize more basic CS II (#9254)
* fix "integer_literal_case"

* fix "phpdoc_separation"

* fix "phpdoc_var_without_name"

* fix "operator_linebreak"

* fix "no_alias_language_construct_call"

* fix "list_syntax"

* fix "concat_space"

* fix "array_syntax"

* fix "binary_operator_spaces"

* fix "binary_operator_spaces" relaxed

* fix "phpdoc_types_order"

* fix "phpdoc_trim"

* fix "native_type_declaration_casing"

* fix "method_chaining_indentation"

* fix "phpdoc_no_package"

* fix "elseif"

* fix PHP CS Fixer config itself too

* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
a8707ae220 Fix and assert basic CS using CI (#9246)
* Assert CS using CI

* fix "single_blank_line_at_eof"

* fix "statement_indentation"

* fix "switch_case_semicolon_to_colon"

* fix "control_structure_braces"

* fix "statement_indentation"

* fix "no_whitespace_in_blank_line"

* fix "no_trailing_whitespace_in_comment"

* fix "no_trailing_whitespace"

* fix "single_space_around_construct"

* fix "spaces_inside_parentheses"

* fix "ternary_operator_spaces"

* fix "trim_array_spaces"

* fix "whitespace_after_comma_in_array"

* fix "cast_spaces"

* fix "unary_operator_spaces"

* fix "no_trailing_comma_in_singleline"

* fix "ordered_imports"

* fix "no_unused_imports"

* Check composer.json format

* fix CI job name

* file header comments are not phpdoc

* fix "phpdoc_indent"

* fix "braces_position"

* fix "phpdoc_types"

* fix "no_blank_lines_after_class_opening"

* fix "no_multiple_statements_per_line"

* fix "multiline_comment_opening_closing"

* fix "single_line_empty_body"

* fix "non_printable_character"

* fix "phpdoc_trim_consecutive_blank_line_separation"

* fix "include"

* fix "no_mixed_echo_print"

---------

Co-authored-by: Aleksander Machniak <alec@alec.pl>
2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a Fix invalid phpdocs (#9252)
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Pablo Zmdl
edf2a95fd8 Fix saving other encryption settings besides enigma's (#9240)
Previously, if the enigma plugin was enabled, it wasn't possible to save
the option whether Roundcube should use Mailvelope's main keyring
(`mailvelope_main_keyring`), because this code overwrote the whole array
for the "encryption"-section on saving. That is now fixed.
2023-12-05 19:33:16 +01:00
Aleksander Machniak
92262aa2a1 Fix fatal error on identity page if Enigma plugin is misconfigured (#8719) 2022-09-24 09:03:08 +02:00
Aleksander Machniak
ed146b68db PHP8 fixes, CS fixes, short array syntax, tests 2020-12-10 20:27:32 +01:00
Aleksander Machniak
e3416c9fc0 PHP8 fixes, CS fixes, short array syntax, tests 2020-12-06 11:43:56 +01:00
Aleksander Machniak
efc61f27c0 Add Preferences > Encryption > Mailvelope options (#7157) 2020-10-03 16:17:42 +02:00
Aleksander Machniak
36bf280a97 Elastic: Minimize forms/colors blink on page load 2020-07-11 10:52:24 +02:00
Aleksander Machniak
5db4b3f5ea Fix '\n' visible when identity has multiple GPG keys (#6885) 2019-08-09 16:38:12 +02:00
Aleksander Machniak
57c67db029 Remove year(s) from copyright headers + some cleanup 2019-04-16 10:42:45 +02:00
Aleksander Machniak
5643b6315e Small improvements 2018-08-24 11:10:15 +02:00
Thomas Bruederli
c4f9bd994e Hook into 'identity_form' plugin hook and add list of matching private keys 2018-01-21 12:17:59 +01:00
Aleksander Machniak
ecefdca21d GnuPG 2.1: Support password input on private key export 2016-10-23 15:51:28 +02:00
Aleksander Machniak
352c6329cc Enigma: Search missing public keys on a key-server in mail compose (#5286) 2016-07-01 09:33:26 +02:00
Aleksander Machniak
3f01232625 Enigma: Delete user keys when using deluser.sh script 2016-06-12 12:49:29 +02:00
Aleksander Machniak
dcb7db2f8c Enigma: Fix keys import from inside of an encrypted message (#5285) 2016-05-30 11:07:58 +02:00
Aleksander Machniak
96c3d84cdd Enigma: Varius fixes and cleanup in code for attaching pubkeys 2016-04-02 10:35:17 +02:00
Kyle Francis
7ce958ecd9 Added attach pubkey checkbox in compose UI, added preferences setting for attach pubkey by default 2016-04-01 12:32:57 -04:00
Aleksander Machniak
570f43c874 Don't load enigma and managesieve css where it's not needed 2015-10-13 09:13:44 +02:00
Aleksander Machniak
392ededc71 Enigma: Enable encryption features on message print page 2015-09-16 14:13:31 +02:00
Aleksander Machniak
1459f88164 Enigma: Add option to disable encryption/signing features 2015-09-13 18:40:09 +02:00
Aleksander Machniak
58c2798fae Implemented password prompt when entering compose page of encrypted message 2015-06-07 17:54:01 +02:00
Aleksander Machniak
76573685d9 Enigma: Added user preferences to disable plugin features 2015-04-11 14:31:27 +02:00
Aleksander Machniak
39f93b2700 Enigma: added composer.json file 2015-04-03 20:29:07 +02:00
Aleksander Machniak
a99c34159d Enigma: Implemented messages signing and encrypting 2015-03-31 18:56:32 +02:00
Aleksander Machniak
0878c846bc Enigma: Larry support, finished PGP decryption, other fixes and improvements 2015-03-08 10:54:28 +01:00
Aleksander Machniak
3e98f8be71 Add some code for S/MIME signatures verification, update Crypt_GPG package 2013-12-27 13:14:40 +01:00
Aleksander Machniak
2193f6a130 Avoid unused local variables 2013-05-07 13:51:23 +02:00
Aleksander Machniak
ce89ecd542 Fix various PHP code bugs found using static analysis (#1489086) 2013-05-06 12:23:27 +02:00
Aleksander Machniak
61be822d62 Remove deprecated functions (from bc.php file) usage in plugins 2013-01-18 15:24:49 +01:00
Sylvestre Ledru
654ac1e090 Fix some typos 2012-08-08 08:37:55 +02:00
Aleksander Machniak
bc92ca56ef Fixes after default->classic switch 2012-07-30 13:20:56 +02:00
thomascube
48e9c14ebd Move plugins repository into roundcubemail root folder; svn:externals are not defined anymore 2012-03-31 12:25:48 +00:00