Michael Voříšek
6a5f9ee7ce
Add override method attributes ( #9272 )
2024-06-02 15:57:56 +02:00
Aleksander Machniak
7b127faec5
Code improvements
2024-03-17 12:05:14 +01:00
Michael Voříšek
332c165d28
Fix some basic JS CS ( #9328 )
...
* fix "nonblock-statement-body-position" (fixed already)
* fix "comma-dangle"
* fix "no-regex-spaces"
* fix "new-parens"
* fix "object-curly-newline"
* fix "object-property-newline"
* fix "spaced-comment" semimanually
* fix "no-constant-condition" manually
* fix "unicorn/no-hex-escape"
* fix "unicorn/escape-case"
* fix "quote-props"
* fix "no-whitespace-before-property" - fix bug/typo
* fix "unicorn/empty-brace-spaces"
* fix "keyword-spacing"
* fix "dot-notation"
* fix "no-return-assign" manually
* fix "padding-line-between-statements"
* fix "key-spacing"
* fix "no-else-return" semimanually
* fix some "no-undef"
* fix case cs
* Revert "fix "padding-line-between-statements""
* improve switch/case format I.
* improve switch/case format II.
regex: (^ *(break|return).*)\n *(\n)
* fix safe "eqeqeq"
* fix "radix"
* fix v3.49.0 CS (static providers)
* fix "string_implicit_backslashes" in php files
* fix comments align
* fix test static providers
* fix stan
* disable "final_internal_class" rule
2024-02-06 08:28:19 +01:00
Michael Voříšek
d18406a8bd
Fix binary operator spaces CS ( #9330 )
...
* align_single_space_minimal for assign
* assign operators grouping is not supported by PHP CS Fixer
* binary_operator_spaces = single_space
* fix anonymous function on single line
* align comments manually
2024-02-02 07:53:34 +01:00
Aleksander Machniak
a73a53c8ef
Replace deprecated methods use
2024-01-27 09:58:01 +01:00
Michael Voříšek
4ee79b9e84
fix "explicit_string_variable" ( #9315 )
2024-01-22 08:05:59 +01:00
Michael Voříšek
b1a0067e5d
Fix more CS ( #9303 )
...
* fix "class_attributes_separation"
* fix "ternary_to_null_coalescing"
* fix "no_extra_blank_lines"
* fix "php_unit_data_provider_name" - use snake_case
* fix remaining "function data_" manually
* move "php_unit_test_case_static_method_calls" to a better place in cnf
* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
86eda9f7ed
Fix "increment_style" CS ( #9296 )
...
* Fix "increment_style" CS
* use "post" increment style
2024-01-01 12:23:21 +01:00
Michael Voříšek
28c778b7a0
Modernize more CS III ( #9270 )
...
* fix "single_trait_insert_per_statement"
* fix "empty_loop_condition"
* fix "backtick_to_shell_exec"
* fix "phpdoc_to_comment"
* fix "no_empty_statement"
* fix "heredoc_to_nowdoc"
* fix "class_reference_name_casing"
* fix "align_multiline_comment"
* fix "heredoc_indentation"
* fix "constant_case"
* fix "single_line_comment_style"
* fix "no_null_property_initialization"
* fix "standardize_increment"
* fix "no_unneeded_control_parentheses"
* fix missing NL after "<?php"
* fix php in *.sh files too
* fix trailing spaces from all text files
* fix "explicit_indirect_variable"
* Revert "fix "align_multiline_comment""
This reverts commit 42e584f8e32101c2a3a3
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Aleksander Machniak
7a269a2b84
Replace get_input_value() with get_input_string() where appropriate
2021-09-13 19:31:49 +02:00
Aleksander Machniak
e3416c9fc0
PHP8 fixes, CS fixes, short array syntax, tests
2020-12-06 11:43:56 +01:00
Aleksander Machniak
545a1569f1
Steps -> Actions refactoring ( #7688 )
...
* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes
2020-11-01 11:25:38 +01:00
Aleksander Machniak
eb7636d491
Fixes in context of undefined variables, and code style
2020-08-16 10:29:42 +02:00
Aleksander Machniak
36bf280a97
Elastic: Minimize forms/colors blink on page load
2020-07-11 10:52:24 +02:00
Mildred Ki'Lya
88577119d7
Add new archival types to keep the folder structure
...
Add archival type folderyear and foldermonth to keep the original folder
structure after a YYYY or a YYYY/MM prefix.
2020-03-04 13:05:26 +01:00
Aleksander Machniak
66fab8cdb2
CS fixes, Avoid usused variables, fixed minor bugs
2019-10-05 19:44:39 +02:00
Aleksander Machniak
0e4bf6fda8
Fix bug where unread count wasn't updated after moving multi-folder result ( #6846 )
2019-07-14 13:23:37 +02:00
Aleksander Machniak
1247a8dd7d
Fix bug where some forbidden characters on Cyrus-IMAP were not prevented from use in folder names
2018-05-08 12:20:11 +02:00
Aleksander Machniak
2faf7185db
Archive: Create archive folder automatically if it's configured, but does not exist ( #6076 )
2018-04-16 16:29:03 +02:00
Aleksander Machniak
db5802b134
Archive: Skip early the request to move to archive folder from archive folder
...
... which may happen in multi-folder search results.
2018-04-09 09:11:04 +02:00
Aleksander Machniak
8e543f843e
Fix check_request() bypass in places using get_uids() [CVE-2018-9846] ( #6238 )
2018-04-09 09:07:27 +02:00
Aleksander Machniak
08f27316ee
Fix bug where Archive folder wasn't auto-created on login with create_default_folders=true
2017-12-11 08:54:27 +01:00
Aleksander Machniak
9ce8948294
Get rid of the 2nd argument of include_stylesheet()
...
.. make the optional behavior default now.
2017-11-20 14:03:07 +01:00
Aleksander Machniak
238ec1ecdf
Archive: Style folder icon also in Settings > Folders
2017-10-30 11:48:56 +01:00
Aleksander Machniak
69f50b122d
Add a way to include plugin stylesheets optionally only if the file exists
2017-08-06 19:46:22 +02:00
Aleksander Machniak
8e126e8648
Fix duplicate messages on the list after deleting messages on the next to the last page ( #5862 )
...
... also when deleting via 'mark' and 'archive' actions
2017-07-17 09:51:36 +02:00
Aleksander Machniak
76adb49454
Support for IMAP folders that cannot contain both folders and messages ( #5057 )
2017-07-14 13:39:49 +02:00
Aleksander Machniak
86a4d78369
Merge branch 'dev-elastic'
2017-07-02 16:47:54 +02:00
Aleksander Machniak
bf4326c834
Bump archive version number, update changelog
2017-06-30 09:24:38 +02:00
Aleksander Machniak
19133769e5
Fix archiving by sender address on cyrus-imap
...
Cyrus-IMAP does not allow @-character in folder names
2017-06-30 09:23:17 +02:00
Aleksander Machniak
05d7fcc698
Cleanup
2017-06-27 19:43:58 +02:00
Aleksander Machniak
0d8b3675f3
Add missing <label>s in Preferences > Special Folders
2017-04-18 18:01:29 +02:00
Harry Smallbones
5665c7455b
Archive: Add Thunderbird compatible Month option
2017-01-27 15:51:36 +00:00
Aleksander Machniak
2803a58152
Use innerclass for Archive button in taskbar
2017-01-13 11:42:59 +01:00
Aleksander Machniak
d85f30bec4
Archive: Don't reload messages list when it's not needed ( #5225 )
...
Archive: Add option to automatically mark archived messages as \Seen (#5142 )
2016-10-02 19:43:04 +02:00
Aleksander Machniak
4f0abbf5fe
CS and indent fixes, added $task property definition
2016-05-28 20:32:14 +02:00
Aleksander Machniak
4cfe230e56
Fix so subfolders of INBOX can be set as Archive ( #5274 )
2016-05-27 18:13:59 +02:00
Aleksander Machniak
74ce01efc7
Q() -> rcube::Q()
2015-10-23 08:02:57 +02:00
Aleksander Machniak
08bb20f261
Don't use deprecated functions/constants (from bc.inc)
2015-08-02 20:16:46 +02:00
Thomas Bruederli
7fce8fbbde
Adapt archive and markasjunk plugins to work with multi-folder search results
2014-04-07 18:00:09 +02:00
Aleksander Machniak
dc0b500e78
Removed redundant default_folders config option ( #1489737 )
...
Implemented IMAP SPECIAL-USE extension support [RFC6154] (#1487830 )
2014-04-01 19:27:07 +02:00
Aleksander Machniak
6b2b2eca5f
Remove deprecated functions (these listed in bc.php file) usage
2013-12-22 14:12:15 +01:00
Aleksander Machniak
442f37c313
Fix list update after archive action on search result
2013-10-30 11:02:34 +01:00
Aleksander Machniak
11075979a6
Update authors and version numbers
2013-10-30 10:37:05 +01:00
Aleksander Machniak
691cbc276d
Fix archive action for all messages in a folder ( #1489405 )
2013-10-30 10:32:48 +01:00
Aleksander Machniak
a6cc96a55d
Fix archive button on messages page when using archive_type != '' ( #1489404 )
2013-10-30 10:02:48 +01:00
