Philip Weir
ccede1f272
Update links in comments and config to https where available ( #9759 )
2025-01-26 13:34:57 +01:00
Michael Voříšek
6a5f9ee7ce
Add override method attributes ( #9272 )
2024-06-02 15:57:56 +02:00
Aleksander Machniak
7b127faec5
Code improvements
2024-03-17 12:05:14 +01:00
Michael Voříšek
d18406a8bd
Fix binary operator spaces CS ( #9330 )
...
* align_single_space_minimal for assign
* assign operators grouping is not supported by PHP CS Fixer
* binary_operator_spaces = single_space
* fix anonymous function on single line
* align comments manually
2024-02-02 07:53:34 +01:00
Michael Voříšek
4ee79b9e84
fix "explicit_string_variable" ( #9315 )
2024-01-22 08:05:59 +01:00
Michael Voříšek
54f4aa33f9
Fix CS - imports ( #9316 )
...
* fix Tests\Browser\TestCase imports
* fix remaining imports
* fix PHPUnit\Framework\TestCase imports
* import GuzzleHttp\Client
* fix remaining
* "php_unit_method_casing" is not todo
* fix "single_line_comment_spacing"
* fix 2nd commit done using older fixer
2024-01-21 19:13:31 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
3e458fa5fd
Refer native constants unambiguously ( #9275 )
...
* Fix "native_constant_invocation" CS
* "self_accessor" was fixed in 9269 PR
* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
28c778b7a0
Modernize more CS III ( #9270 )
...
* fix "single_trait_insert_per_statement"
* fix "empty_loop_condition"
* fix "backtick_to_shell_exec"
* fix "phpdoc_to_comment"
* fix "no_empty_statement"
* fix "heredoc_to_nowdoc"
* fix "class_reference_name_casing"
* fix "align_multiline_comment"
* fix "heredoc_indentation"
* fix "constant_case"
* fix "single_line_comment_style"
* fix "no_null_property_initialization"
* fix "standardize_increment"
* fix "no_unneeded_control_parentheses"
* fix missing NL after "<?php"
* fix php in *.sh files too
* fix trailing spaces from all text files
* fix "explicit_indirect_variable"
* Revert "fix "align_multiline_comment""
This reverts commit 42e584f8e32101c2a3a3
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a
Fix invalid phpdocs ( #9252 )
...
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Aleksander Machniak
0266f7a3bf
ACL: Set default of 'acl_specials' option to ['anyone'] ( #8911 )
2023-04-10 09:39:12 +02:00
Aleksander Machniak
9c6979f17a
Fix PHP8 warnings
2021-10-09 17:23:02 +02:00
Aleksander Machniak
7a269a2b84
Replace get_input_value() with get_input_string() where appropriate
2021-09-13 19:31:49 +02:00
Aleksander Machniak
3bbb01fe13
PHP8 fixes, regression fixes
2020-12-13 12:14:15 +01:00
Aleksander Machniak
ed146b68db
PHP8 fixes, CS fixes, short array syntax, tests
2020-12-10 20:27:32 +01:00
Aleksander Machniak
e3416c9fc0
PHP8 fixes, CS fixes, short array syntax, tests
2020-12-06 11:43:56 +01:00
Aleksander Machniak
545a1569f1
Steps -> Actions refactoring ( #7688 )
...
* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes
2020-11-01 11:25:38 +01:00
Aleksander Machniak
86849a0ee4
Fix PHP Fatal error: Cannot access protected property rcube_imap_generic::$user ( #7589 )
2020-09-05 16:30:32 +02:00
Aleksander Machniak
eb7636d491
Fixes in context of undefined variables, and code style
2020-08-16 10:29:42 +02:00
Aleksander Machniak
36bf280a97
Elastic: Minimize forms/colors blink on page load
2020-07-11 10:52:24 +02:00
Aleksander Machniak
7fa5180fcc
ACL: Display user/group names (from ldap) instead of acl identifier
2019-06-17 11:47:49 +00:00
Aleksander Machniak
57c67db029
Remove year(s) from copyright headers + some cleanup
2019-04-16 10:42:45 +02:00
Aleksander Machniak
d6c19431be
Elastic: .proplist improvements
2018-05-21 11:54:04 +02:00
Aleksander Machniak
8c6d87542b
Acl: get rid of addressbook_form and calendar_form_kolab hooks handlers
...
- the plugin is called "manually" by Kolab plugins now
2018-03-28 15:39:25 +00:00
Aleksander Machniak
76933f1c07
Elastic: Bootstrap 4.0.0 compat.
2018-01-23 13:41:26 +01:00
Aleksander Machniak
a6ad0283d0
Validate ACL identifiers
...
... e.g. to prevent cyrus imap issues
2018-01-16 16:17:16 +01:00
Aleksander Machniak
9ce8948294
Get rid of the 2nd argument of include_stylesheet()
...
.. make the optional behavior default now.
2017-11-20 14:03:07 +01:00
Aleksander Machniak
e9571e8d0e
Fix invalid HTML output
2017-10-31 09:09:15 +01:00
Aleksander Machniak
1347e2e868
Elastic skin support in acl plugin
2017-10-07 17:47:03 +02:00
ka7
9a35768c26
spelling fixes ( #5690 )
2017-03-12 12:14:19 +01:00
Aleksander Machniak
391d0d2039
Remove "@version @package_version@"
2016-11-01 18:26:47 +01:00
Aleksander Machniak
184de7735c
CS fixes (mostly phpdoc)
2016-08-18 08:50:59 +02:00
Aleksander Machniak
6f2c007d1b
CS fixes: Replace use of "bool ? true : false" with just "bool"
2016-04-02 13:02:55 +02:00
Aleksander Machniak
9f1f754daf
CS fixes
2015-11-22 09:41:53 +01:00
Aleksander Machniak
1912d8c62b
Fix invalid LDAP query in ACL user autocompletion ( #1490591 )
2015-11-17 18:38:57 +01:00
Thomas Bruederli
0f63aa390f
Give other plugins the opportunity to adjust the list of permissions and groups to edit
2015-03-12 13:33:07 +01:00
Aleksander Machniak
3f308bf390
Display group icon on group entry in ACL autocomplete list
2015-02-20 05:33:17 -05:00
Aleksander Machniak
681ba6fc3c
Improve system security by using optional special URL with security token
...
Allows to define separate server/path for image/js/css files
Fix bugs where CSRF attacks were still possible on some requests
2014-12-16 13:28:48 +01:00
Aleksander Machniak
c7ac4bbe53
CS fixes after PR merge
2014-10-26 11:37:26 +01:00
Bartlomiej Nogas
c1e2ce76c7
Add configuration option 'acl_group_field' to use as ACL group identifier
2014-10-21 12:05:35 +02:00
Aleksander Machniak
ec2733f6c3
Add support for groups
2014-08-11 03:35:07 -04:00
Aleksander Machniak
0a96bdf74d
Don't overwrite the whole fieldmap so autocomplete names are resolved correctly
2014-07-16 11:38:01 +02:00
Aleksander Machniak
43b225d183
Support contact_search_name option in ACL plugin autocompletion
2014-07-08 10:10:16 +02:00
Aleksander Machniak
62c45161c4
ACL: Improved UI accessibility
2014-06-10 14:40:22 +02:00
Thomas Bruederli
66536974fe
Merge branch 'dev-multi-folder-search'
2014-04-07 09:53:46 +02:00
Thomas Bruederli
f147849bb0
Use standard dialog popups for the ACL permissions form; that will open it in the main window with enoough space and better UI integration
2014-02-04 22:49:23 +01:00
Thomas
017c4f19fd
Refactor multi-threaded autocomple contact searching to make it available for other purposes, too
2014-01-16 11:16:09 +01:00
