Mirrors/espurna
2
0
Fork 0
mirror of https://github.com/xoseperez/espurna.git synced 2026-03-12 19:27:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

webui: disallow empty type[number]

Browse Source 
...unless necessary, like with magnitude zero threshold
This commit is contained in:
Maxim Prokhorov
2024-07-30 01:27:33 +03:00
parent 8d8d60fb81
commit de2f96a7eb
13 changed files with 38 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
code/html/src/sensor.mjs
View File

@@ -324,13 +324,16 @@ function emonRatioInfo(id) {
return magnitudeSettingInfo(id, "Ratio");
}
/** @typedef {{required?: boolean, min?: string, max?: string}} MagnitudeNumberOptions */
/**
* @param {string} containerId
* @param {number} id
* @param {string} keySuffix
* @param {number} value
* @param {MagnitudeNumberOptions} options
*/
function initMagnitudeNumberSetting(containerId, id, keySuffix, value) {
function initMagnitudeNumberSetting(containerId, id, keySuffix, value, {required = true, min = "", max = ""} = {}) {
const container = document.getElementById(containerId);
if (!container) {
return;
@@ -345,15 +348,19 @@ function initMagnitudeNumberSetting(containerId, id, keySuffix, value) {
const template = new NumberInput();
mergeTemplate(container, template.with(
(label, input) => {
(label, input, span) => {
label.textContent = info.name;
label.htmlFor = input.id;
label.htmlFor = info.key;
input.id = info.key;
input.name = input.id;
input.name = info.key;
input.required = required;
input.min = min;
input.max = max;
input.value = value.toString();
setOriginalsFromValues([input]);
setOriginalFromValue(input);
listenEnumerableMagnitudeDescription(span, id);
}));
}
@@ -478,19 +485,19 @@ function initMagnitudesSettings(values, schema) {
if (typeof threshold === "number") {
initMagnitudeNumberSetting(
"magnitude-zero-thresholds", id,
"ZeroThreshold", threshold);
"ZeroThreshold", threshold, {required: false});
}
if (typeof settings.MinDelta === "number") {
initMagnitudeNumberSetting(
"magnitude-min-deltas", id,
"MinDelta", settings.MinDelta);
"MinDelta", settings.MinDelta, {min: "0"});
}
if (typeof settings.MaxDelta === "number") {
initMagnitudeNumberSetting(
"magnitude-max-deltas", id,
"MaxDelta", settings.MaxDelta);
"MaxDelta", settings.MaxDelta, {min: "0"});
}
});
}