diff --git a/code/espurna/api_common.cpp b/code/espurna/api_common.cpp index 56f505fb..dbdb8965 100644 --- a/code/espurna/api_common.cpp +++ b/code/espurna/api_common.cpp @@ -20,7 +20,7 @@ Copyright (C) 2020 by Maxim Prokhorov namespace { -bool _apiWebSocketOnKeyCheck(const char * key, JsonVariant& value) { +bool _apiWebSocketOnKeyCheck(const char * key, JsonVariant&) { return (strncmp(key, "api", 3) == 0); } diff --git a/code/espurna/debug.cpp b/code/espurna/debug.cpp index 925299ef..05bccdf2 100644 --- a/code/espurna/debug.cpp +++ b/code/espurna/debug.cpp @@ -512,7 +512,7 @@ void send(const char* message, size_t len, Timestamp timestamp) { namespace web { #if TERMINAL_SUPPORT -void onAction(uint32_t client_id, const char * action, JsonObject& data) { +void onAction(uint32_t, const char * action, JsonObject& data) { if (strcmp(action, "dbgcmd") != 0) { return; } diff --git a/code/espurna/led.cpp b/code/espurna/led.cpp index 2bb2e8c4..4c581bbf 100644 --- a/code/espurna/led.cpp +++ b/code/espurna/led.cpp @@ -986,7 +986,7 @@ void callback(unsigned int type, const char* topic, char* payload) { #if WEB_SUPPORT namespace web { -bool onKeyCheck(const char * key, JsonVariant& value) { +bool onKeyCheck(const char * key, JsonVariant&) { return (strncmp(key, "led", 3) == 0); } diff --git a/code/espurna/mqtt.cpp b/code/espurna/mqtt.cpp index 9c334bb3..ff1f238e 100644 --- a/code/espurna/mqtt.cpp +++ b/code/espurna/mqtt.cpp @@ -742,7 +742,7 @@ namespace { #if WEB_SUPPORT -bool _mqttWebSocketOnKeyCheck(const char * key, JsonVariant& value) { +bool _mqttWebSocketOnKeyCheck(const char * key, JsonVariant&) { return (strncmp(key, "mqtt", 3) == 0); } @@ -1007,7 +1007,7 @@ bool _mqttMaybeSkipRetained(char* topic) { // In that case, there could be MQTT_MESSAGE_RAW_EVENT and this callback only trigger on small messages. // TODO: Current callback model does not allow to pass message length. Instead, implement a topic filter and record all subscriptions. That way we don't need to filter out events and could implement per-event callbacks. -void _mqttOnMessageAsync(char* topic, char* payload, AsyncMqttClientMessageProperties properties, size_t len, size_t index, size_t total) { +void _mqttOnMessageAsync(char* topic, char* payload, AsyncMqttClientMessageProperties, size_t len, size_t index, size_t total) { if (!len || (len > MQTT_BUFFER_MAX_SIZE) || (total > MQTT_BUFFER_MAX_SIZE)) return; if (_mqttMaybeSkipRetained(topic)) return; diff --git a/code/espurna/ntp.cpp b/code/espurna/ntp.cpp index dc93a20f..096bd9f3 100644 --- a/code/espurna/ntp.cpp +++ b/code/espurna/ntp.cpp @@ -379,7 +379,7 @@ time_t now() { #if WEB_SUPPORT namespace web { -bool onKeyCheck(const char * key, JsonVariant& value) { +bool onKeyCheck(const char * key, JsonVariant&) { return (strncmp(key, "ntp", 3) == 0); } diff --git a/code/espurna/ota_asynctcp.cpp b/code/espurna/ota_asynctcp.cpp index f51ef229..cecd6735 100644 --- a/code/espurna/ota_asynctcp.cpp +++ b/code/espurna/ota_asynctcp.cpp @@ -101,7 +101,7 @@ void disconnect() { // ----------------------------------------------------------------------------- -void onDisconnect(void* arg, AsyncClient* client) { +void onDisconnect(void* arg, AsyncClient*) { DEBUG_MSG_P(PSTR("\n")); otaFinalize(reinterpret_cast(arg)->size, CustomResetReason::Ota, true); schedule_function(internal::disconnect); @@ -176,7 +176,7 @@ void onData(void* arg, AsyncClient* client, void* data, size_t len) { } } -void onConnect(void* arg, AsyncClient* client) { +void onConnect(void* arg, AsyncClient*) { auto* ota_client = reinterpret_cast(arg); #if ASYNC_TCP_SSL_ENABLED diff --git a/code/espurna/sensor.cpp b/code/espurna/sensor.cpp index 57928510..71c32d67 100644 --- a/code/espurna/sensor.cpp +++ b/code/espurna/sensor.cpp @@ -2164,6 +2164,7 @@ void _sensorMqttCallback(unsigned int type, const char* topic, char* payload) { _sensorApiResetEnergy(magnitude, static_cast(payload)); break; } + break; } case MQTT_CONNECT_EVENT: { for (auto& magnitude : _magnitudes) { @@ -2173,9 +2174,9 @@ void _sensorMqttCallback(unsigned int type, const char* topic, char* payload) { break; } } + break; } case MQTT_DISCONNECT_EVENT: - default: break; } } diff --git a/code/espurna/system.cpp b/code/espurna/system.cpp index 61349741..0e2c5fa1 100644 --- a/code/espurna/system.cpp +++ b/code/espurna/system.cpp @@ -661,7 +661,7 @@ void onConnected(JsonObject& root) { root["hbMode"] = static_cast(heartbeat::settings::mode()); } -bool onKeyCheck(const char * key, JsonVariant& value) { +bool onKeyCheck(const char * key, JsonVariant&) { if (strncmp(key, "sys", 3) == 0) return true; if (strncmp(key, "hb", 2) == 0) return true; return false; diff --git a/code/espurna/telnet.cpp b/code/espurna/telnet.cpp index cdf90b07..ef32de55 100644 --- a/code/espurna/telnet.cpp +++ b/code/espurna/telnet.cpp @@ -101,7 +101,7 @@ void _telnetWebSocketOnVisible(JsonObject& root) { wsPayloadModule(root, "telnet"); } -bool _telnetWebSocketOnKeyCheck(const char * key, JsonVariant& value) { +bool _telnetWebSocketOnKeyCheck(const char * key, JsonVariant&) { return (strncmp(key, "telnet", 6) == 0); } @@ -221,7 +221,7 @@ void AsyncBufferedClient::_s_onAck(void* client_ptr, AsyncClient*, size_t, uint3 _trySend(reinterpret_cast(client_ptr)); } -void AsyncBufferedClient::_s_onPoll(void* client_ptr, AsyncClient* client) { +void AsyncBufferedClient::_s_onPoll(void* client_ptr, AsyncClient*) { _trySend(reinterpret_cast(client_ptr)); } @@ -444,7 +444,7 @@ void _telnetLoop() { void _telnetSetupClient(unsigned char i, AsyncClient *client) { - client->onError([i](void *s, AsyncClient *client, int8_t error) { + client->onError([i](void*, AsyncClient *client, int8_t error) { DEBUG_MSG_P(PSTR("[TELNET] Error %s (%d) on client #%u\n"), client->errorToString(error), error, i); }); client->onData([i](void*, AsyncClient*, void *data, size_t len){ @@ -470,7 +470,7 @@ void _telnetNewClient(AsyncClient* client) { if (!can_connect) { DEBUG_MSG_P(PSTR("[TELNET] Rejecting - Only local connections\n")); - client->onDisconnect([](void *s, AsyncClient *c) { + client->onDisconnect([](void*, AsyncClient *c) { delete c; }); client->close(true); @@ -489,7 +489,7 @@ void _telnetNewClient(AsyncClient* client) { } DEBUG_MSG_P(PSTR("[TELNET] Rejecting - Too many connections\n")); - client->onDisconnect([](void *s, AsyncClient *c) { + client->onDisconnect([](void*, AsyncClient *c) { delete c; }); client->close(true); @@ -542,7 +542,7 @@ void telnetSetup() { _telnetServer.begin(); espurnaRegisterLoop(_telnetLoop); #else - _telnetServer.onClient([](void *s, AsyncClient* c) { + _telnetServer.onClient([](void*, AsyncClient* c) { _telnetNewClient(c); }, nullptr); _telnetServer.begin(); diff --git a/code/espurna/terminal.cpp b/code/espurna/terminal.cpp index 5f133a4e..cb2b62a1 100644 --- a/code/espurna/terminal.cpp +++ b/code/espurna/terminal.cpp @@ -386,7 +386,7 @@ void _terminalInitCommands() { case 2: start = pin; end = pin + 1; - // fallthrough into print + // fallthrough! case 1: for (auto current = start; current < end; ++current) { if (gpioValid(current)) { diff --git a/code/espurna/web.cpp b/code/espurna/web.cpp index b64e447c..c139a56f 100644 --- a/code/espurna/web.cpp +++ b/code/espurna/web.cpp @@ -100,7 +100,7 @@ bool AsyncWebPrint::_addBuffer() { void AsyncWebPrint::_prepareRequest() { _state = State::Sending; - auto *response = _request->beginChunkedResponse(_config.mimeType, [this](uint8_t *buffer, size_t maxLen, size_t index) -> size_t { + auto *response = _request->beginChunkedResponse(_config.mimeType, [this](uint8_t *buffer, size_t maxLen, size_t) -> size_t { switch (_state) { case State::None: return RESPONSE_TRY_AGAIN; @@ -350,7 +350,7 @@ void _onPostConfig(AsyncWebServerRequest *request) { request->send(_webConfigSuccess ? 200 : 400); } -void _onPostConfigFile(AsyncWebServerRequest *request, String filename, size_t index, uint8_t *data, size_t len, bool final) { +void _onPostConfigFile(AsyncWebServerRequest *request, String, size_t index, uint8_t *data, size_t len, bool final) { if (!webAuthenticate(request)) { _webRequestAuth(request); diff --git a/code/espurna/wifi.cpp b/code/espurna/wifi.cpp index a2bb6265..13257b56 100644 --- a/code/espurna/wifi.cpp +++ b/code/espurna/wifi.cpp @@ -1520,7 +1520,7 @@ bool scanning() { // (or at all, for anything), it might be nice to have some safeguards. void init() { - static auto disconnected = WiFi.onStationModeDisconnected([](const WiFiEventStationModeDisconnected& event) { + static auto disconnected = WiFi.onStationModeDisconnected([](const WiFiEventStationModeDisconnected&) { connection::internal::wait = false; connection::internal::connected = false; }); @@ -1791,7 +1791,7 @@ uint8_t channel() { return getSetting("wifiApChannel", build::channel()); } - +[[gnu::unused]] bool captive() { return getSetting("wifiApCaptive", build::captive()); } @@ -2142,7 +2142,7 @@ namespace web { #if WEB_SUPPORT -bool onKeyCheck(const char * key, JsonVariant& value) { +bool onKeyCheck(const char * key, JsonVariant&) { if (strncmp(key, "wifi", 4) == 0) return true; if (strncmp(key, "ssid", 4) == 0) return true; if (strncmp(key, "pass", 4) == 0) return true; diff --git a/code/espurna/ws.cpp b/code/espurna/ws.cpp index c3e21868..3f25293b 100644 --- a/code/espurna/ws.cpp +++ b/code/espurna/ws.cpp @@ -624,7 +624,7 @@ void _wsParse(AsyncWebSocketClient *client, uint8_t * payload, size_t length) { } } -bool _wsOnKeyCheck(const char * key, JsonVariant& value) { +bool _wsOnKeyCheck(const char * key, JsonVariant&) { if (strncmp(key, "ws", 2) == 0) return true; if (strncmp(key, "admin", 5) == 0) return true; if (strncmp(key, "hostname", 8) == 0) return true;