From 7bb04bdda291256475a2dad303d125e7ade71dfa Mon Sep 17 00:00:00 2001
From: Tester23 <85486843+openshwprojects@users.noreply.github.com>
Date: Thu, 10 Jul 2025 15:27:26 +0200
Subject: [PATCH] safer str op

---
 src/httpserver/rest_interface.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/httpserver/rest_interface.c b/src/httpserver/rest_interface.c
index 875348ed7..4e6e2ba22 100644
--- a/src/httpserver/rest_interface.c
+++ b/src/httpserver/rest_interface.c
@@ -721,7 +721,8 @@ bool HTTP_checkLFSOverride(http_request_t* request, const char *ext) {
 	char tmp[64];
 	//sprintf_s(tmp, sizeof(tmp), "override/%s", request->url);
 	//sprintf_s(tmp, sizeof(tmp), "%s%s", request->url, ext);
-	sprintf(tmp,  "%s%s", request->url, ext);
+	strcpy_safe(tmp, request->url, sizeof(tmp));
+	strcat_safe(tmp, ext, sizeof(tmp));
 	char *fix = strchr(tmp, '?');
 	if (fix) {
 		*fix = 0;
@@ -733,7 +734,9 @@ bool HTTP_checkLFSOverride(http_request_t* request, const char *ext) {
 	if (lfsres == 0) {
 		lfs_file_close(&lfs, file);
 		free(file);
-		sprintf(tmp,  "api/lfs/%s%s", request->url, ext);
+		strcpy_safe(tmp, "api/lfs/", sizeof(tmp));
+		strcat_safe(tmp, request->url, sizeof(tmp));
+		strcat_safe(tmp, ext, sizeof(tmp));
 		char *oldURL = request->url;
 		request->url = tmp;
 		http_rest_get_lfs_file(request);