From 604aa0ff76c116f5d4f9fb19398a127c2ee005b6 Mon Sep 17 00:00:00 2001
From: openshwprojects <openshwprojects@gmail.com>
Date: Fri, 5 May 2023 12:08:18 +0200
Subject: [PATCH] rest interface for pins now also shows pin states, i will
 need it for pin doctor

---
 src/httpserver/rest_interface.c | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/src/httpserver/rest_interface.c b/src/httpserver/rest_interface.c
index a19776caf..f8e42bf15 100644
--- a/src/httpserver/rest_interface.c
+++ b/src/httpserver/rest_interface.c
@@ -645,32 +645,33 @@ static int http_rest_get_pins(http_request_t* request) {
 	poststr(request, "{\"rolenames\":[");
 	for (i = 0; i < IOR_Total_Options; i++) {
 		if (i) {
-			hprintf255(request, ",\"%s\"", htmlPinRoleNames[i]);
-		}
-		else {
-			hprintf255(request, "\"%s\"", htmlPinRoleNames[i]);
+			hprintf255(request, ",");
 		}
+		hprintf255(request, "\"%s\"", htmlPinRoleNames[i]);
 	}
 	poststr(request, "],\"roles\":[");
 
 	for (i = 0; i < PLATFORM_GPIO_MAX; i++) {
 		if (i) {
-			hprintf255(request, ",%d", g_cfg.pins.roles[i]);
-		}
-		else {
-			hprintf255(request, "%d", g_cfg.pins.roles[i]);
+			hprintf255(request, ",");
 		}
+		hprintf255(request, "%d", g_cfg.pins.roles[i]);
 	}
 	// TODO: maybe we should cull futher channels that are not used?
 	// I support many channels because I plan to use 16x relays module with I2C MCP23017 driver
 	poststr(request, "],\"channels\":[");
 	for (i = 0; i < CHANNEL_MAX; i++) {
 		if (i) {
-			hprintf255(request, ",%d", g_cfg.pins.channels[i]);
+			hprintf255(request, ",");
 		}
-		else {
-			hprintf255(request, "%d", g_cfg.pins.channels[i]);
+		hprintf255(request, "%d", g_cfg.pins.channels[i]);
+	}
+	poststr(request, "],\"states\":[");
+	for (i = 0; i < CHANNEL_MAX; i++) {
+		if (i) {
+			hprintf255(request, ",");
 		}
+		hprintf255(request, "%d", CHANNEL_Get(g_cfg.pins.channels[i]));
 	}
 	poststr(request, "]}");
 	poststr(request, NULL);