From cd352c8a0cfe3c07786eae29694e42b89337d7ff Mon Sep 17 00:00:00 2001 From: mattpass Date: Sun, 23 Aug 2020 09:28:03 +0100 Subject: [PATCH] Tweaks to bug reporting --- assets/js/icecoder.js | 7 +------ lib/bug-files-check.php | 3 ++- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/assets/js/icecoder.js b/assets/js/icecoder.js index edd716b..322fce1 100644 --- a/assets/js/icecoder.js +++ b/assets/js/icecoder.js @@ -3914,12 +3914,7 @@ var ICEcoder = { this.message(t['No new errors...']); } if(this.bugReportStatus=="bugs") { - // Close bug-report without saving previousFiles and without confirming close if we made changes on the bug report - // var bugReportOpenFilePos = this.openFiles.indexOf(this.bugReportPath.replace(/\|/g,"/")); - // if (bugReportOpenFilePos > -1) { - // this.closeTab(bugReportOpenFilePos+1,'dontSetPV','dontAsk'); - // } - // this.openFile(this.bugReportPath); + // Show bug report screen and set the bugs state as seen this.bugReportScreen(); this.bugFilesSizesSeen = this.bugFilesSizesActual; } diff --git a/lib/bug-files-check.php b/lib/bug-files-check.php index 8a25ddc..e6ba9aa 100644 --- a/lib/bug-files-check.php +++ b/lib/bug-files-check.php @@ -84,7 +84,7 @@ if ("error" !== $result) { // Close file fclose($f); - // OK, now we have bug lines to output, save to our file + // OK, now we have bug lines to output, concat onto output $output = rtrim(str_replace("\r\n", "\n", $output)); $output = explode("\n", $output); $output = array_slice($output, -$maxLines); @@ -93,6 +93,7 @@ if ("error" !== $result) { } + // Save all output to the bug report file if (0 < $filesWithNewBugs) { $settingsClass->serializedFileData("set", $docRoot . $ICEcoderDir . "/data/bug-report.php", serialize($output)); }