From 15eba478ac0691f8db28c8a7b2ffe6a9a25fc91f Mon Sep 17 00:00:00 2001 From: Matt Pass Date: Sat, 18 Oct 2014 20:38:31 +0100 Subject: [PATCH] Slice 4 chars from end (for less and scss) The char position used by $fileNameExtPos is actually from the beginning, not end, so is useless here However, we know that 'less' and 'scss' are 4 chars, so we can just slice off those 4 chars always --- processes/on-file-save.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/processes/on-file-save.php b/processes/on-file-save.php index 4d3bcbc..51c7f98 100644 --- a/processes/on-file-save.php +++ b/processes/on-file-save.php @@ -9,7 +9,6 @@ // Compiling Sass and LESS files (.scss and .less to .css version, with same name, in same dir) $fileName = basename($file); -$fileNameExtPos = strrpos($fileName,"."); $filePieces = explode(".",$file); $fileExt = $filePieces[count($filePieces)-1]; @@ -25,7 +24,7 @@ if (strtolower($fileExt) == "scss" && file_exists(dirname(__FILE__)."/../plugins try { $scssContent = $scss->compile('@import "'.$fileName.'"'); - $fh = fopen(substr($file, 0, -$fileNameExtPos)."css", 'w'); + $fh = fopen(substr($file, 0, -4)."css", 'w'); fwrite($fh, $scssContent); fclose($fh); } catch (Exception $e) { @@ -44,7 +43,7 @@ if (strtolower($fileExt) == "less" && file_exists(dirname(__FILE__)."/../plugins $less->setPreserveComments(false); // true or false try { - $less->checkedCompile($file, substr($file, 0, -$fileNameExtPos)."css"); // Note: Only recompiles if changed + $less->checkedCompile($file, substr($file, 0, -4)."css"); // Note: Only recompiles if changed } catch (Exception $e) { echo ";top.ICEcoder.message('Couldn\'t compile your LESS, error info below:\\n\\n".$e->getMessage()."');"; }