From 0f29baf5049b690552906797f1b0ffb82e0d7360 Mon Sep 17 00:00:00 2001
From: Matt Pass <matt@mattpass.com>
Date: Tue, 30 Jun 2015 17:17:55 +0100
Subject: [PATCH] Tweaks and comments

Need a semi colon for inline JS, improved and added comments
---
 lib/file-control-xhr.php | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/lib/file-control-xhr.php b/lib/file-control-xhr.php
index 119cae9..bf19fa7 100644
--- a/lib/file-control-xhr.php
+++ b/lib/file-control-xhr.php
@@ -121,14 +121,15 @@ if (!$error && $_GET['action']=="save") {
 							overwriteOK = top.ICEcoder.ask("'.$t['That file exists...'].'");
 						} else {
 							noConflictSave = true;
-						}
+						};
 						
-						/* Saving under conditions: New filename or confirmation of overwrite */
+						/* Saving under conditions: Confirmation of overwrite or there is no filename conflict, it is a new file, in either case we can save */
 						if (overwriteOK || noConflictSave) {
 							newFileName = "'.$docRoot.'" + newFileName;
 							saveURL = "lib/file-control-xhr.php?action=save'.$fileMDTURLPart.'&csrf='.$_GET["csrf"].'";
 
 							var xhr = top.ICEcoder.xhrObj();
+
 							xhr.onreadystatechange=function() {
 								if (xhr.readyState==4 && xhr.status==200) {
 									/* console.log(xhr.responseText); */
@@ -147,6 +148,7 @@ if (!$error && $_GET['action']=="save") {
 
 								}
 							};
+
 							/* console.log(\'Calling \'+saveURL+\' via XHR\'); */
 							xhr.open("POST",saveURL,true);
 							xhr.setRequestHeader(\'Content-type\', \'application/x-www-form-urlencoded\');
@@ -157,6 +159,7 @@ if (!$error && $_GET['action']=="save") {
 				},10);
 			};
 
+			/* UI dialog cancelling and saving contents for save as looparound */
 			if (!newFileName || newFileName && !overwriteOK) {
 				top.ICEcoder.saveAsContent = top.document.getElementById(\'saveTemp1\').value;
 				top.ICEcoder.serverMessage();top.ICEcoder.serverQueue("del",0);
@@ -616,6 +619,7 @@ if (!$error && $_GET['action']=="perms") {
 
 if (!$error && $_GET['action']=="checkExists") {
 	// This action is called under seperate AJAX call and the responseText object stored in top.ICEcoder.lastFileDirCheckStatusObj
+	// Nothing really done here though, we do something with the responseText
 	$finalAction = "checkExists";
 	$doNext = 'top.ICEcoder.serverMessage();top.ICEcoder.serverQueue("del",0);';
 };