Commit Graph

2121 Commits

Author SHA1 Message Date
Jukka Kurkela
22c02ede02 Fix updating of active elements (#9261) 2021-06-12 14:19:33 -04:00
Evert Timberg
dc373f3aaa Replace [...set] with Array.from(set) (#9260) 2021-06-12 20:34:54 +03:00
Evert Timberg
9db3680440 null or undefined should skip grid lines in the time scale (#9252)
* `null` or `undefined` should skip grid lines in the time scale

* Refactor implementation per code review
2021-06-12 10:47:14 -04:00
Jacco van den Berg
1a7212dff5 Barheight no longer undefined (#9208) 2021-06-02 22:48:42 +03:00
Evert Timberg
be011768fe Fix rtl legend text alignment (#9199)
* Start fixing RTL

* Broken test

* Fix right alignment for horizontal legends
2021-06-01 18:36:55 +03:00
Evert Timberg
599e23abfd Tick backdrop padding is not scriptable (#9191)
* Tick backdrop padding is not scriptable
* Remove unneeded change
* Update _scriptable for callback
2021-05-30 16:59:49 -04:00
Jukka Kurkela
4ac38d033e Make sure data is parsed before updateElements (#9187)
* Make sure data is parsed before updateElements
* Add test
2021-05-30 14:51:11 -04:00
Jukka Kurkela
9326309afd Fix error when swapping dataset locations (#9183) 2021-05-30 07:39:00 -04:00
Evert Timberg
c853ca6942 Allow setting a constance spacing between arc elements (#9180) 2021-05-29 17:47:44 -04:00
Jukka Kurkela
db74d2f44c Linear: Respect bounds option in tick generation (#9181)
* Linear: Respect bounds option in tick generation
* Remove leftover _filterBetween
2021-05-29 17:32:03 -04:00
Jukka Kurkela
188da82206 Fix clearStacks with custom scaleId (#9170) 2021-05-28 07:36:59 +03:00
Jukka Kurkela
77cfac1785 Ignore items outside chart area for interaction (#9171) 2021-05-27 17:15:50 -04:00
Jukka Kurkela
03eb826f8c Stop mutating arc state while drawing (#9153)
* Stop mutating arc state while drawing

* No need for default values

* Nits

* Remove #9152

* Use correct endAngle for clipping
2021-05-25 08:13:37 -04:00
Jukka Kurkela
1d047355e7 Fix: Arc getCenterPoint when full circle (#9152) 2021-05-24 16:14:35 -04:00
Evert Timberg
087f9c30c5 Improved error message when no date adapter provided (#9147) 2021-05-22 08:59:02 -04:00
Jukka Kurkela
a6f0b37dfe Further improve linear tick collision estimation (#9129)
* Further improve linear tick collision estimation

* More tolerance

* Re-create fixtures

* And more tolerance
2021-05-20 10:01:47 +03:00
Evert Timberg
78009390ad Show correct decimal places when using count but min is not an integer (#9122)
* Show correct decimal places when using count but `min` is not an integer
* Fix lint issues
2021-05-19 18:31:15 -04:00
Jukka Kurkela
939ffe02ab Fix arc offset calculation (#9118) 2021-05-18 19:24:57 -04:00
Jukka Kurkela
749d1fc942 Fix animations when data is replaced (#9120) 2021-05-18 19:24:35 -04:00
Jukka Kurkela
a553d57033 Fix doughnut rotation on float edge cases (#9121) 2021-05-18 19:24:23 -04:00
Jukka Kurkela
d1a243efec Delay data to elements synchronization to update (#9105) 2021-05-15 08:22:15 -04:00
Jukka Kurkela
fbff165942 Make sure context indices are up to date (#9101) 2021-05-14 17:16:22 -04:00
Akihiko Kusanagi
0ba5c70618 Support monotone cubic interpolation for vertical line charts (#9084)
* Support monotone cubic interpolation for vertical line charts

* Use more more intuitive veriable names
2021-05-14 17:07:26 -04:00
Akihiko Kusanagi
953b23b4ef Fix element reset animations in vertical line and bubble charts (#9088) 2021-05-13 16:22:58 -04:00
Jukka Kurkela
f1ca99bfd4 Fix setting options in array of objects (#9062)
* Fix setting options in array of objects

* CC
2021-05-12 23:08:17 +03:00
Evert Timberg
024f406223 Fix polar area tooltip item label (#9067) 2021-05-12 07:54:21 -04:00
Josh Kelley
1df4883aff Fix detecting changed events (#9050)
* Fix detecting changed events

Because `this._listeners` may contain both event handlers from options and internal event handlers for responsive support, the `setsEqual` check would often fail, causing event handlers to be unnecessarily detached and reattached and fired.

If I'm understanding correctly, this is the root cause of #9049.

* Use a separate object for responsive listeners

Correctly update events when responsive property changes as well as when requested events change.

* Code review feedback
2021-05-10 08:48:03 -04:00
Toni Dietze
c955ffad64 Round canvas.style dimensions to avoid blurring (#9015)
When canvas.height and canvas.width are set, the numbers are rounded to
integers. The same rounding must be applied to canvas.style.height and
canvas.style.width to avoid scaling of the canvas which would lead to
blurring.

Acknowledging that canvas.height and canvas.width are integers, the
framebuffer is now only redrawn if those integer values change.
2021-05-08 08:11:52 +03:00
Jukka Kurkela
33c16382b3 Allow scale to auto-adjust it's min when stacked (#9045) 2021-05-07 15:48:55 -04:00
Jukka Kurkela
7c3a412887 Add includeBounds option for cartesian ticks (#9020)
* Add includeBounds option for cartesian ticks

* Types, test and fix

* lint

* Improve linear tick min/max collision detection

* Update comments
2021-05-07 09:03:37 +03:00
Jukka Kurkela
137b51d87d Fix line segments with alignToPixel (#9042) 2021-05-06 21:06:40 -04:00
Jukka Kurkela
1a1e677699 Fix: Avoid negative layout dimensions (#9027) 2021-05-05 07:49:44 -04:00
Akihiko Kusanagi
dffc086ad4 Fix for enabling monotone cubicInterpolationMode when tension is 0 (#9008) 2021-04-30 08:14:13 -04:00
Jukka Kurkela
12bf256fd5 Ignore truncated pixels in bar width calculation (#8995) 2021-04-28 16:42:08 -04:00
Jukka Kurkela
44e62e77ca Improve linear tick generators collision estimation (#8983)
* Increase distance to min/max tick to 1/3 space

* Better estimation on linear tick collision

* Lint fix

* Remove unused change
2021-04-28 16:41:57 -04:00
Jukka Kurkela
eaa3a68cea Add drawTime: beforeDraw option to filler (#8973) 2021-04-24 15:27:52 -04:00
Jukka Kurkela
0ad0d35c09 Fix skipNull for subsequent datasets (#8972) 2021-04-24 15:20:52 -04:00
Evert Timberg
b92f9e52fd Only enable the bar borderRadius at the end of the stacks (#8941)
* Only enable the bar borderRadius at the end of the stacks
* Float bars always get borders enabled
* Tests
* Update documentation
2021-04-18 16:30:54 -04:00
Jukka Kurkela
3e319f79ab Scale: draw border on separate layer after grid (#8936) 2021-04-18 07:38:46 -04:00
Jukka Kurkela
e1404ac834 Time: cache options needed by parse (#8933) 2021-04-18 07:30:54 -04:00
Prateek R Patil
c107f895aa Fix for allowing parsing:false with stacks (#8934)
* Initial fix for allowing parsing:false with stacks

* Added test from #8935 as requested.

Co-authored-by: tinfoilpancakes <tfm357@gmail.com>
2021-04-18 07:28:56 -04:00
Evert Timberg
af7965fc31 Cartesian scale tick backdrop (#8931) 2021-04-18 12:49:22 +03:00
Evert Timberg
e29ba78cd1 Allow the events option to be changed at runtime (#8928) 2021-04-17 14:08:36 -04:00
Jukka Kurkela
ca50287a76 Add initial property to animation callbacks (#8926) 2021-04-17 08:09:22 -04:00
Jukka Kurkela
ef4f504db9 Fix: Fill vertical lines (#8919) 2021-04-17 07:31:58 -04:00
Jukka Kurkela
853f094937 Scale: Make sure grace is applied only once (#8913)
* Scale: Make sure grace is applied only once
* Add description to fixture
2021-04-17 07:31:15 -04:00
Jukka Kurkela
9e06f90d14 Fix: Initialize data object when replaced (#8918) 2021-04-17 07:29:41 -04:00
Jukka Kurkela
8e535c574c Skip ticks by callback value as documented (#8914) 2021-04-17 07:28:33 -04:00
Jukka Kurkela
f94e8828ae Fix: don't draw segments out of bounds (#8911) 2021-04-16 17:14:55 -04:00
Evert Timberg
cc4ce7adef Do not redraw endlessly on mouse move (#8898)
* Do not redraw endlessly on mouse move

The tooltip incorrectly determined that the position changed leading to many redraws

* Code review feedback
2021-04-15 16:36:03 -04:00